Patch Detail
Show a patch.
GET /api/patches/26417/?format=api
{ "id": 26417, "url": "https://patchwork.libcamera.org/api/patches/26417/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26417/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260405191443.1209948-2-laurent.pinchart@ideasonboard.com>", "date": "2026-04-05T19:14:33", "name": "[01/11] libcamera: software_isp: Convert TODO list to markdown", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6b0e16d60927a277da8bf611b41dcd68b3d1cd61", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26417/mbox/", "series": [ { "id": 5866, "url": "https://patchwork.libcamera.org/api/series/5866/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5866", "date": "2026-04-05T19:14:32", "name": "libcamera: Fix missing license information", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5866/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26417/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26417/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1F062BEFBE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 5 Apr 2026 19:14:50 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B453862D0D;\n\tSun, 5 Apr 2026 21:14:47 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B111362D0D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 5 Apr 2026 21:14:46 +0200 (CEST)", "from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 7E6996AF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 5 Apr 2026 21:13:20 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"U9LJln6F\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775416400;\n\tbh=YGfncuotm3xqlMnSeguoHw5Q00Y08xmTfCO/tvago1U=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=U9LJln6FjTEd8GIdKH4yZGctq/cQlyayzReThQ1ROpz1Bj4I4FQzg+Uz17H3phBB9\n\tTeFnOnEg5ipU7o7MI4eLABLKCfU7GzTLax/YtodtuMojGyYm7dYRN4DQoHke+hPycx\n\tEVrKxN3zCuz5hSmXgyHEWtrtLKEcKM4j7oh5G9OM=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH 01/11] libcamera: software_isp: Convert TODO list to markdown", "Date": "Sun, 5 Apr 2026 22:14:33 +0300", "Message-ID": "<20260405191443.1209948-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260405191443.1209948-1-laurent.pinchart@ideasonboard.com>", "References": "<20260405191443.1209948-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "To prepare for merging the two software ISP TODO lists (TODO and\ngpuisp-todo.txt), convert the TODO file to markdown.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/software_isp/{TODO => TODO.md} | 50 ++++++++++++--------\n utils/tuning/config-example.yaml | 2 +-\n 2 files changed, 32 insertions(+), 20 deletions(-)\n rename src/libcamera/software_isp/{TODO => TODO.md} (91%)", "diff": "diff --git a/src/libcamera/software_isp/TODO b/src/libcamera/software_isp/TODO.md\nsimilarity index 91%\nrename from src/libcamera/software_isp/TODO\nrename to src/libcamera/software_isp/TODO.md\nindex f19e15ae27a0..bdd4a7421766 100644\n--- a/src/libcamera/software_isp/TODO\n+++ b/src/libcamera/software_isp/TODO.md\n@@ -1,5 +1,16 @@\n-2. Reconsider stats sharing\n+# Software ISP TODO list\n \n+This file contains the TODO list for the software ISP.\n+\n+## Common code and CPU-based implementation\n+\n+The TODO items in this section gather comments from patch review that were not\n+deemed to require being addressed right away. The text in block quotes is\n+copied directly from e-mail review.\n+\n+### Reconsider stats sharing\n+\n+```\n >>> +void SwStatsCpu::finishFrame(void)\n >>> +{\n >>> +\t*sharedStats_ = stats_;\n@@ -22,11 +33,11 @@\n \n That would match how we deal with hardware ISPs, and I think that's a\n good idea. It will help decoupling the processing side from the IPA.\n+```\n \n----\n-\n-3. Remove statsReady signal\n+### Remove statsReady signal\n \n+```\n > class SwStatsCpu\n > {\n > \t/**\n@@ -50,11 +61,11 @@ Removing the signal and refactoring those classes doesn't have to be\n addressed now, I think it would be part of a larger refactoring\n (possibly also considering platforms that have no ISP but can produce\n stats in hardware, such as the i.MX7), but please keep it on your radar.\n+```\n \n----\n-\n-5. Store ISP parameters in per-frame buffers\n+### Store ISP parameters in per-frame buffers\n \n+```\n > /**\n > * \\fn void Debayer::process(FrameBuffer *input, FrameBuffer *output, DebayerParams params)\n > * \\brief Process the bayer data into the requested format.\n@@ -68,11 +79,11 @@ stats in hardware, such as the i.MX7), but please keep it on your radar.\n \n Possibly something to address later, by storing ISP parameters in\n per-frame buffers like we do for hardware ISPs.\n+```\n \n----\n-\n-8. DebayerCpu cleanups\n+### DebayerCpu cleanups\n \n+```\n > >> class DebayerCpu : public Debayer, public Object\n > >> const SharedFD &getStatsFD() { return stats_->getStatsFD(); }\n > >\n@@ -105,21 +116,21 @@ the need for performances and the need for a maintainable architecture.\n > I think this falls under the lets wait until we have a GPU\n > based SoftISP MVP/POC and then do some refactoring to see which\n > bits should go where.\n+```\n \n----\n-\n-8. Decouple pipeline and IPA naming\n+### Decouple pipeline and IPA naming\n \n+```\n > The current src/ipa/meson.build assumes the IPA name to match the\n > pipeline name. For this reason \"-Dipas=simple\" is used for the\n > Soft IPA module.\n \n This should be addressed.\n+```\n \n----\n-\n-9. Doxyfile cleanup\n+### Doxyfile cleanup\n \n+```\n >> diff --git a/Documentation/Doxyfile.in b/Documentation/Doxyfile.in\n >> index a86ea6c1..2be8d47b 100644\n >> --- a/Documentation/Doxyfile.in\n@@ -160,13 +171,14 @@ Yes, because, well... all the other IPAs were doing that...\n \n > It doesn't have to be done before merging, but could you\n > address this sooner than later ?\n+```\n \n----\n-\n-13. Improve black level and colour gains application\n+### Improve black level and colour gains application\n \n+```\n I think the black level should eventually be moved before debayering, and\n ideally the colour gains as well. I understand the need for optimizations to\n lower the CPU consumption, but at the same time I don't feel comfortable\n building up on top of an implementation that may work a bit more by chance than\n by correctness, as that's not very maintainable.\n+```\ndiff --git a/utils/tuning/config-example.yaml b/utils/tuning/config-example.yaml\nindex 5593eaef809e..680f9213b269 100644\n--- a/utils/tuning/config-example.yaml\n+++ b/utils/tuning/config-example.yaml\n@@ -51,4 +51,4 @@ general:\n macbeth:\n small: 1\n show: 0\n-# blacklevel: 32\n\\ No newline at end of file\n+# blacklevel: 32\n", "prefixes": [ "01/11" ] }