Patch Detail
Show a patch.
GET /api/patches/26349/?format=api
{ "id": 26349, "url": "https://patchwork.libcamera.org/api/patches/26349/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26349/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260325151416.2114564-8-stefan.klug@ideasonboard.com>", "date": "2026-03-25T15:13:39", "name": "[v2,07/32] libipa: fc_queue: Rename template argument to FC", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6fd2a64bd6106a2a5e15cfbd9fb98a2e107d624c", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26349/mbox/", "series": [ { "id": 5849, "url": "https://patchwork.libcamera.org/api/series/5849/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5849", "date": "2026-03-25T15:13:32", "name": "rkisp1: pipeline rework for PFC", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5849/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26349/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26349/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0B3D5C32F8\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 25 Mar 2026 15:15:03 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E898E62852;\n\tWed, 25 Mar 2026 16:15:02 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5D9D8627D7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 25 Mar 2026 16:15:01 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:b16a:5ed9:4ada:a95a])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 5A5F712BB; \n\tWed, 25 Mar 2026 16:13:43 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TgzmCRLS\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1774451623;\n\tbh=VOqC7Xke0kB/p9Ixwo8tICQdTYGuG+M0+xf5hv/yUqw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=TgzmCRLSWInV3cFxyG+bmLWe2U7YcVC3KIisPhIs4xX+tiHO4Caz1OOItyJHNnU7z\n\tDsv2VDNBcIwJQwkW/GvUr8eb0CilabihlkYWVvCU44bUqNkd+ACym2YvjD76bTEFeq\n\tAL+MaTmpEYgcNJ9X/PXupR+71nVXbYfKQR0VzX8A=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH v2 07/32] libipa: fc_queue: Rename template argument to FC", "Date": "Wed, 25 Mar 2026 16:13:39 +0100", "Message-ID": "<20260325151416.2114564-8-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20260325151416.2114564-1-stefan.klug@ideasonboard.com>", "References": "<20260325151416.2114564-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The FCQueue has a template argument called FrameContext which is easily\nconfused with the class FrameContext defined in the same file.\n\nReduce that confusion by renaming the template argument to FC.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\n\nChanges in v2:\n- Collected tag\n---\n src/ipa/libipa/fc_queue.h | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/src/ipa/libipa/fc_queue.h b/src/ipa/libipa/fc_queue.h\nindex a1d136521107..1f4f84c27fbc 100644\n--- a/src/ipa/libipa/fc_queue.h\n+++ b/src/ipa/libipa/fc_queue.h\n@@ -28,7 +28,7 @@ private:\n \tbool initialised = false;\n };\n \n-template<typename FrameContext>\n+template<typename FC>\n class FCQueue\n {\n public:\n@@ -39,15 +39,15 @@ public:\n \n \tvoid clear()\n \t{\n-\t\tfor (FrameContext &ctx : contexts_) {\n+\t\tfor (FC &ctx : contexts_) {\n \t\t\tctx.initialised = false;\n \t\t\tctx.frame = 0;\n \t\t}\n \t}\n \n-\tFrameContext &alloc(const uint32_t frame)\n+\tFC &alloc(const uint32_t frame)\n \t{\n-\t\tFrameContext &frameContext = contexts_[frame % contexts_.size()];\n+\t\tFC &frameContext = contexts_[frame % contexts_.size()];\n \n \t\t/*\n \t\t * Do not re-initialise if a get() call has already fetched this\n@@ -69,9 +69,9 @@ public:\n \t\treturn frameContext;\n \t}\n \n-\tFrameContext &get(uint32_t frame)\n+\tFC &get(uint32_t frame)\n \t{\n-\t\tFrameContext &frameContext = contexts_[frame % contexts_.size()];\n+\t\tFC &frameContext = contexts_[frame % contexts_.size()];\n \n \t\t/*\n \t\t * If the IPA algorithms try to access a frame context slot which\n@@ -122,14 +122,14 @@ public:\n \t}\n \n private:\n-\tvoid init(FrameContext &frameContext, const uint32_t frame)\n+\tvoid init(FC &frameContext, const uint32_t frame)\n \t{\n \t\tframeContext = {};\n \t\tframeContext.frame = frame;\n \t\tframeContext.initialised = true;\n \t}\n \n-\tstd::vector<FrameContext> contexts_;\n+\tstd::vector<FC> contexts_;\n };\n \n } /* namespace ipa */\n", "prefixes": [ "v2", "07/32" ] }