Patch Detail
Show a patch.
GET /api/patches/26341/?format=api
{ "id": 26341, "url": "https://patchwork.libcamera.org/api/patches/26341/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26341/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260325-mali-cru-v6-7-b16b0c49819a@ideasonboard.com>", "date": "2026-03-25T14:44:14", "name": "[v6,7/7] libcamera: mali-c55: Fix sensor size computation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "6c316a80ebcbf0901c3362311a408f227862c38e", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26341/mbox/", "series": [ { "id": 5848, "url": "https://patchwork.libcamera.org/api/series/5848/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5848", "date": "2026-03-25T14:44:07", "name": "libcamera: mali-c55: Add support for memory-to-memory", "version": 6, "mbox": "https://patchwork.libcamera.org/series/5848/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26341/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26341/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D3C0EC32F9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 25 Mar 2026 14:44:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 684F46283D;\n\tWed, 25 Mar 2026 15:44:27 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 13B606274D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 25 Mar 2026 15:44:21 +0100 (CET)", "from [192.168.1.104] (net-93-65-100-155.cust.vodafonedsl.it\n\t[93.65.100.155])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0A0071943;\n\tWed, 25 Mar 2026 15:43:03 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JyPWibXy\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1774449783;\n\tbh=LATrMea+GPrXRekBlXe2H8bkzQeumpp9rKZdniQ4tDo=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=JyPWibXyptsIg76YU346NCcHErRlKfKzbUWNBqyLqbK9iWFQtqjVDRaa/szOrZ9xs\n\tdqQk83eWgj7HytIP7vfSYEo73t/LCwoKkNcGE/v5bwfkxhaRqh46IaYNtIgSK2O8vX\n\t7XGSu92Ml47uySKQKNp8jw+zQDBdD0vcz2ysHO5w=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Wed, 25 Mar 2026 15:44:14 +0100", "Subject": "[PATCH v6 7/7] libcamera: mali-c55: Fix sensor size computation", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260325-mali-cru-v6-7-b16b0c49819a@ideasonboard.com>", "References": "<20260325-mali-cru-v6-0-b16b0c49819a@ideasonboard.com>", "In-Reply-To": "<20260325-mali-cru-v6-0-b16b0c49819a@ideasonboard.com>", "To": "Daniel Scally <dan.scally@ideasonboard.com>, \n\tlibcamera-devel@lists.libcamera.org", "Cc": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>,\n\tJacopo Mondi <jacopo.mondi@ideasonboard.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1117;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=LATrMea+GPrXRekBlXe2H8bkzQeumpp9rKZdniQ4tDo=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpw/TCqNkulhKYAxGira/OXUZWmhy0laqZUlUoD\n\t/lvo4odNuiJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCacP0wgAKCRByNAaPFqFW\n\tPDl2D/9s4IbZnonhJ4WOei8PpsDewT0uUESLdGz3wv7gyfkUPcWLswzGwVtGkufzph0N0oTCCoQ\n\tcorKaqLHBUnJjmtPoizKZkDkKNfgCzwRCu7jAkhehlC6SRhbusGtvnWTKDoEF4mWOqm4IGTi/1/\n\thr9mlOu7Kbm4Yr8frEKwsKGvC55PlNz2FNYkZlYGuvUQ0mRzGDqapYDuYT0zt8Mtg8gR0YXv3EI\n\t9k4FCXNL34S+FYwZPXUeAm516OSEI121pRnYnuCWWQeYq3ACnn+aDnxhtwA4g1hf5u9Q8pNvEXv\n\tnDkh/8IfV5j/F0chAm9uCKgt6mCiW/CGyzfuuraFoDPnHAe5BywY5QLIehBrwGGUt/cP8RJaFMj\n\t2WNm7J9fb/s1ff30eaTNA7YHoBrsvCclcmzje6ugRrDau3edogEE3Tud6kvAP4vshBI/uL7PIPU\n\t99hhbH9/L+IUGmal58QEak1CoK7jK+YMTE5YWOR9tWMQSr2V8mH7/sV1B6g7Mt2iIdqeIEwGs66\n\tQ9FL7mtAkNp4pIdPKwOBxJB3sezDoFhvnEnVXU9bnpPIxg7Dc8Tn4gGBxcTwpyANHFsrusrI0GY\n\trBFzsliwsyIEYuL96mQyqYFV5KK0fL8D0EXGnhXq/RtD47k+trS/48tVN5CRGrbrZeiPGU/Oq1y\n\tCEQptqZPWqhue2Q==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The last size in the list is always selected unconditionally because\nthe current best distance is not updated properly during the search.\n\nFix the size computation procedure which has an inverted assignment.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Daniel Scally <dan.scally@ideasonboard.com>\nTested-by: Daniel Scally <dan.scally@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 10848c412849..2ba403fb348e 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -660,7 +660,7 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate()\n \t\t\t\tstd::abs(static_cast<int>(minSensorSize.height) -\n \t\t\t\t\t static_cast<int>(size.height));\n \t\tif (dist < distance) {\n-\t\t\tdist = distance;\n+\t\t\tdistance = dist;\n \t\t\tbestSize = size;\n \t\t}\n \t}\n", "prefixes": [ "v6", "7/7" ] }