Patch Detail
Show a patch.
GET /api/patches/26298/?format=api
{ "id": 26298, "url": "https://patchwork.libcamera.org/api/patches/26298/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26298/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260313-mali-cru-v5-7-48f93e431294@ideasonboard.com>", "date": "2026-03-13T16:14:41", "name": "[v5,7/7] libcamera: mali-c55: Fix sensor size computation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "6c316a80ebcbf0901c3362311a408f227862c38e", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26298/mbox/", "series": [ { "id": 5830, "url": "https://patchwork.libcamera.org/api/series/5830/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5830", "date": "2026-03-13T16:14:34", "name": "libcamera: mali-c55: Add support for memory-to-memory", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5830/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26298/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26298/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C7517BE086\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 13 Mar 2026 16:14:59 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7917F626EE;\n\tFri, 13 Mar 2026 17:14:59 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2F25F626BE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 13 Mar 2026 17:14:57 +0100 (CET)", "from [192.168.224.131] (unknown [37.159.122.93])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 58DEF103D;\n\tFri, 13 Mar 2026 17:13:47 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DXO+xN24\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1773418428;\n\tbh=deapVA1Shx6XLGOt2/xUg2Rv4+jLetI/mAuFJF4dFRw=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=DXO+xN24+oeVOj5lI2w0iF1e7eVJdJXY6x12M5qujvpXIPdMeYGO1gl4Nhb6a+KD1\n\tw8F7OF24FjSQRFIeYtD47OWYGze8TdCvt31oQbV7vp+/72lQT/U1BC3YUWAi9DeyiC\n\tQ3pNqaQvvz3toBInJiBq8fkNO+OuYfSDiiVogmCc=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Fri, 13 Mar 2026 17:14:41 +0100", "Subject": "[PATCH v5 7/7] libcamera: mali-c55: Fix sensor size computation", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260313-mali-cru-v5-7-48f93e431294@ideasonboard.com>", "References": "<20260313-mali-cru-v5-0-48f93e431294@ideasonboard.com>", "In-Reply-To": "<20260313-mali-cru-v5-0-48f93e431294@ideasonboard.com>", "To": "Daniel Scally <dan.scally@ideasonboard.com>, \n\tlibcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>, =?utf-8?b?QmFybmFiw6Fz?=\n\t=?utf-8?q?_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1117;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=deapVA1Shx6XLGOt2/xUg2Rv4+jLetI/mAuFJF4dFRw=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBptDfzhgBv1razLzojfnR6Gbt04ATDTm87Gl/wy\n\tIQOsS1aOIqJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCabQ38wAKCRByNAaPFqFW\n\tPDHtD/9j7CjbV8bOjiK1hr3dfK36LG3zpahgLmtvpVnr1hIXM40P+Sk2eUpv2R1k68NwG3IVdEi\n\tl4Q5tnmuOSpnCMlXjcsQsekWaCdcvxPVWN3jc4vU3qnTFcseBDqo9jOkxCoTS6ctE9TzYVbN5ID\n\tFe34EWjxJHNH+eQdIIZYL0m1HEFL39olXTvPcS95xxp7OTWvwwLfpDrmMqsZi+ipeM06ZduWr5u\n\toOKZ2Bp3Bl1YUSaN+CjtcbMtsBpMbjW284fDqIxp7y0+Y2uwJsRLx27d7D8sR8Cf5aDU92GBlaa\n\t7Bzi4dpWwjg0MgIVm38LrnXdaW6RP+1Sk9Gjd76PhylbYZ1iFIwndoeI9oCBzIVYr5hMAtB8x1F\n\tvt57y2ByA2nFsFDWfqXEI781WnrJKjDPFDgWLe8wN+rWMI3mL3CiHA5YESSFIO76ba1m30mI7z0\n\t2DEhyespQjlBxuUyFW0WQw4p5PjjU44e8kqBmomng9W9M9H7SiE/mwuj+jWZczAaJvRjOmSxEEO\n\tE0WGCDKns59qy4xy00d1OzGrDbLTSkEevZI8FFv1uQgwUaIF7NSRbh8Jjhy7Gbs+YMelniiD8bd\n\tijQlGbienFDi9l19frtNjdTj+pYdPZILYNw42H02xI7+Z1yAEXvebKyTqlaHrr30svrvDYot9ok\n\teQDA4CgPCfb+SIg==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The last size in the list is always selected unconditionally because\nthe current best distance is not updated properly during the search.\n\nFix the size computation procedure which has an inverted assignment.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Daniel Scally <dan.scally@ideasonboard.com>\nTested-by: Daniel Scally <dan.scally@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 84c2a030b470..33c69342cd49 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -695,7 +695,7 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate()\n \t\t\t\tstd::abs(static_cast<int>(minSensorSize.height) -\n \t\t\t\t\t static_cast<int>(size.height));\n \t\tif (dist < distance) {\n-\t\t\tdist = distance;\n+\t\t\tdistance = dist;\n \t\t\tbestSize = size;\n \t\t}\n \t}\n", "prefixes": [ "v5", "7/7" ] }