Patch Detail
Show a patch.
GET /api/patches/26296/?format=api
{ "id": 26296, "url": "https://patchwork.libcamera.org/api/patches/26296/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26296/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260313-mali-cru-v5-5-48f93e431294@ideasonboard.com>", "date": "2026-03-13T16:14:39", "name": "[v5,5/7] libcamera: mali-c55: Configure camera in memory-to-memory", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "46c4a2620f17fe935c659c912911b512a61db756", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26296/mbox/", "series": [ { "id": 5830, "url": "https://patchwork.libcamera.org/api/series/5830/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5830", "date": "2026-03-13T16:14:34", "name": "libcamera: mali-c55: Add support for memory-to-memory", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5830/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26296/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26296/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 88F39C32B5\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 13 Mar 2026 16:14:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 379506271D;\n\tFri, 13 Mar 2026 17:14:54 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D72056271D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 13 Mar 2026 17:14:51 +0100 (CET)", "from [192.168.224.131] (unknown [37.159.122.93])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8CBAB1D98;\n\tFri, 13 Mar 2026 17:13:41 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"p5p0UKhz\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1773418422;\n\tbh=AsomUuJdFnFq0ZzK2S3TIpdAp6bgAC4XuKCZHuC6+HE=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=p5p0UKhzIsDk7rsGGTzjN87VRU74q7usoizsZ3jWvKKies0gnBvXKAjvSYGXw4n8Y\n\tdONuI/Jg7d4LXACt9TzM08dXleZJaIEcmuMgq9bYchh4CM3jQ8OT1NJwYSQ0LSDGu1\n\tMHfKu3zucVPNZq2CYWClrlh2MoPWiCPwHtBIoSLs=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Fri, 13 Mar 2026 17:14:39 +0100", "Subject": "[PATCH v5 5/7] libcamera: mali-c55: Configure camera in\n\tmemory-to-memory", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260313-mali-cru-v5-5-48f93e431294@ideasonboard.com>", "References": "<20260313-mali-cru-v5-0-48f93e431294@ideasonboard.com>", "In-Reply-To": "<20260313-mali-cru-v5-0-48f93e431294@ideasonboard.com>", "To": "Daniel Scally <dan.scally@ideasonboard.com>, \n\tlibcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1799;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=AsomUuJdFnFq0ZzK2S3TIpdAp6bgAC4XuKCZHuC6+HE=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBptDfzTXbzskx/VLtLyd4AGfMT2l4vM7NUHAchh\n\tAa9+/v10hyJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCabQ38wAKCRByNAaPFqFW\n\tPGNiD/wOXIvzaj1+u+TMEXhKvfhGGqKd7Huu3WWanMMk99zXKJIFvLiVoqTrNs9/4izEZiAhFVb\n\ttVuP8q3nCb0WBrROGqGx9e2OW+XWqmmbkpds8Pm66QQZk2c68N1BdaMruwRTX708UCSGLEWL/Fa\n\tzURdx3cO5jWB9kNcTJLaHZ/SzJ2+7+Hs+tj2z2GvYDLLOCn0vP4BSOOX+RQgIXzpiZJrhE6oOk7\n\tIDRrX6uzgP4XqKhsTTroXPKQ7Dqsaut7CLzP/DM1Hj+IqAsc9CUAznUfsAZYrpmGCAmyncmwueQ\n\tN8wohkZBGEic8nojmqjjY+DA34MNwk7YP+U+FdpeGZdupBgcVczvve/XzWDH6s/gTkQcr/tZG2B\n\tojmZpV/KXX6eyYaLgZuq1zo6DnTFEITGmt7gQKCOrHFqS1rgnV/N11L3BUTaCofNoIT3IbLIqdK\n\t0yTaOPfM8eAdppJN0gZnNfpnNsYcWf0TALS3B5MmyUxP+7/pcFCoIULtfWdNhqUTQUNl1C9PPbJ\n\tefhHfTZ/IAoevGG+P17irn1XgD8k+RIic8zyRg/nP8AVmuZ5DjIb1jjE+zZoZBqpKW7AwZFEHqr\n\tKyxT6rRogMcf/jAQPq8HZb9uuwJseKrmzCeup1UjoGHtf+LpFoQoahx7VVAberD+KZUe+fZwQAq\n\tKcIcE5oMCxkLQTg==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add support for memory-to-memory Camera to the\nPipelineHandlerMaliC55::configure() function.\n\nStart by enabling the IVC links, then configure the CRU and\npropagate the format to the IVC.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 24 ++++++++++++++++++++----\n 1 file changed, 20 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 5e93d66b01cd..9b83927d8441 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -1048,8 +1048,9 @@ int PipelineHandlerMaliC55::configure(Camera *camera,\n \t\t\tconst MediaEntity *csi2Entity = in.csi2_->entity();\n \t\t\treturn csi2Entity->getPadByIndex(1)->links()[0]->setEnabled(true);\n \t\t},\n-\t\t[](MaliC55CameraData::Memory &) {\n-\t\t\treturn 0;\n+\t\t[&](MaliC55CameraData::Memory &) {\n+\t\t\tconst MediaEntity *ivcEntity = ivcSd_->entity();\n+\t\t\treturn ivcEntity->getPadByIndex(1)->links()[0]->setEnabled(true);\n \t\t}\n \t}, data->input_);\n \tif (ret)\n@@ -1076,8 +1077,23 @@ int PipelineHandlerMaliC55::configure(Camera *camera,\n \n \t\t\treturn data->csi2()->getFormat(1, &subdevFormat);\n \t\t},\n-\t\t[](MaliC55CameraData::Memory &) {\n-\t\t\treturn 0;\n+\t\t[&](MaliC55CameraData::Memory &) {\n+\t\t\tV4L2DeviceFormat inputFormat;\n+\n+\t\t\tret = data->cru()->configure(&subdevFormat, &inputFormat);\n+\t\t\tif (ret)\n+\t\t\t\treturn ret;\n+\n+\t\t\t/* Propagate the CRU format to the IVC input. */\n+\t\t\tret = ivcSd_->setFormat(0, &subdevFormat);\n+\t\t\tif (ret)\n+\t\t\t\treturn ret;\n+\n+\t\t\tret = ivcSd_->getFormat(1, &subdevFormat);\n+\t\t\tif (ret)\n+\t\t\t\treturn ret;\n+\n+\t\t\treturn ivc_->setFormat(&inputFormat);\n \t\t}\n \t}, data->input_);\n \tif (ret)\n", "prefixes": [ "v5", "5/7" ] }