Patch Detail
Show a patch.
GET /api/patches/26290/?format=api
{ "id": 26290, "url": "https://patchwork.libcamera.org/api/patches/26290/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26290/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260313-mali-cru-v4-7-c0d9bc8cd8fa@ideasonboard.com>", "date": "2026-03-13T11:33:48", "name": "[v4,7/7] libcamera: mali-c55: Fix sensor size computation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "6c316a80ebcbf0901c3362311a408f227862c38e", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26290/mbox/", "series": [ { "id": 5829, "url": "https://patchwork.libcamera.org/api/series/5829/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5829", "date": "2026-03-13T11:33:41", "name": "libcamera: mali-c55: Add support for memory-to-memory", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5829/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26290/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26290/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9F7ADC32B5\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 13 Mar 2026 11:34:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 587A562714;\n\tFri, 13 Mar 2026 12:34:34 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 88AB16267F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 13 Mar 2026 12:34:32 +0100 (CET)", "from [192.168.224.131] (unknown [37.159.92.229])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EE9C01783;\n\tFri, 13 Mar 2026 12:33:22 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"X/nHvBf5\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1773401603;\n\tbh=RODaCUPDemFMAoR1fwRD2HIo2c+Jvu0vwlMja1pXbkQ=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=X/nHvBf5b8L35y4N9siLe1i/GkJGewI5AxgBShrp2XY1bEHPQlwQmMsaAn5eCESkx\n\tkJiJHdpH4y06lB1go6ILOb27+PEFjKuzyiO/nHgwscfnxD46Bx2fHAhEb1fi7NrztX\n\t/N/70f+VgNbOnOipKddPR4eRpUppkQXV4fZegMn0=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Fri, 13 Mar 2026 12:33:48 +0100", "Subject": "[PATCH v4 7/7] libcamera: mali-c55: Fix sensor size computation", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260313-mali-cru-v4-7-c0d9bc8cd8fa@ideasonboard.com>", "References": "<20260313-mali-cru-v4-0-c0d9bc8cd8fa@ideasonboard.com>", "In-Reply-To": "<20260313-mali-cru-v4-0-c0d9bc8cd8fa@ideasonboard.com>", "To": "Daniel Scally <dan.scally@ideasonboard.com>, \n\tlibcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>, =?utf-8?b?QmFybmFiw6Fz?=\n\t=?utf-8?q?_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1117;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=RODaCUPDemFMAoR1fwRD2HIo2c+Jvu0vwlMja1pXbkQ=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBps/Y1t3gBkcWJ+5x/OVZdwStVpeeQTrrLdZtCG\n\toT6iLs8m76JAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCabP2NQAKCRByNAaPFqFW\n\tPMgIEACORgRZYa67DVYJpZbWbq3KucAaPgxOJkNCMRV1/VZ9E/kf5/maYhKFczLX0QhAK3248ui\n\tuq91orfZ/JLteo6mileTwJqDwxdZRh0IffXNheuY0xUm47U4Qrcn8Ei5z+vhaQegw5W+ShuhE9+\n\tWVgnQbrlF1TrSk0P9KB/O+zOVSapMwwmdLuWoqj4tvSuI460aSvSidXj1+Cm5Gj9qUtTNANSjkf\n\t/sMB8cX1mJaIsgCFm+BeqdcXtqgk7i/30RrFgn7SwHOWGrTS9PcyEtOwwg+nhL0qfkR/1QXSLKV\n\tPqxS0NLOqTLnWnXvWja4xDm9F3AmaCbv4GxiXvvJQ3daIOx3XqoAcpX9vrtwy/irngurqvYfJo6\n\tnjdIuu59QRVAEQLj9nCEGDGTchX0D7S4XUnVvfLXoi7bwqDJO7cyLExMvY4z+cl53HreRSX1d+Y\n\th/mmbNckTz+Z9eNNwO7uWmnApEXJFzuo3KEkel8y6MdPrweDubjXiJlpZo4KvkTvFE2dfIIggbv\n\toSGTRCeQBRj7y/Pfj1JMOYhVcOodaRPcFsKOx9llPRtyKpRQ3C7cZ+JJtkWvj1QuL6dpBuBVJtJ\n\tN6fTzkhcyZb9rmggdw6wVE7WOnF3dq7ihNplOVsbpiV0DylDFw63hWIJu10gwL0ELP/UvR8k4pr\n\tQwXMMa4DYMAR24A==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The last size in the list is always selected unconditionally because\nthe current best distance is not updated properly during the search.\n\nFix the size computation procedure which has an inverted assignment.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Daniel Scally <dan.scally@ideasonboard.com>\nTested-by: Daniel Scally <dan.scally@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex a2f8f4b8e881..71bd249a00e9 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -695,7 +695,7 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate()\n \t\t\t\tstd::abs(static_cast<int>(minSensorSize.height) -\n \t\t\t\t\t static_cast<int>(size.height));\n \t\tif (dist < distance) {\n-\t\t\tdist = distance;\n+\t\t\tdistance = dist;\n \t\t\tbestSize = size;\n \t\t}\n \t}\n", "prefixes": [ "v4", "7/7" ] }