Patch Detail
Show a patch.
GET /api/patches/26274/?format=api
{ "id": 26274, "url": "https://patchwork.libcamera.org/api/patches/26274/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26274/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260310120106.79922-5-johannes.goede@oss.qualcomm.com>", "date": "2026-03-10T12:01:05", "name": "[v7,4/5] software_isp: Log input config from configure()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "93c9a5453fc1d9d8048bd86d2d99f47fb5d97f10", "submitter": { "id": 242, "url": "https://patchwork.libcamera.org/api/people/242/?format=api", "name": "Hans de Goede", "email": "johannes.goede@oss.qualcomm.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26274/mbox/", "series": [ { "id": 5825, "url": "https://patchwork.libcamera.org/api/series/5825/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5825", "date": "2026-03-10T12:01:01", "name": "software_isp: debayer_cpu: Add multi-threading support", "version": 7, "mbox": "https://patchwork.libcamera.org/series/5825/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26274/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26274/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BE2E5C32B5\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 10 Mar 2026 12:01:24 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 724216266B;\n\tTue, 10 Mar 2026 13:01:24 +0100 (CET)", "from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n\t[205.220.168.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 45A7462663\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 Mar 2026 13:01:20 +0100 (CET)", "from pps.filterd (m0279863.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n\t62A8jpRB2460657 for <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 Mar 2026 12:01:18 GMT", "from mail-ua1-f69.google.com (mail-ua1-f69.google.com\n\t[209.85.222.69])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4csyv1c5ek-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 Mar 2026 12:01:18 +0000 (GMT)", "by mail-ua1-f69.google.com with SMTP id\n\ta1e0cc1a2514c-94e9c0edfcfso24791316241.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 Mar 2026 05:01:18 -0700 (PDT)", "from t14s\n\t(2001-1c00-0c32-7800-beb3-9058-f5fe-3f2e.cable.dynamic.v6.ziggo.nl.\n\t[2001:1c00:c32:7800:beb3:9058:f5fe:3f2e])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-48541aa7aacsm87843405e9.13.2026.03.10.05.01.15\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 10 Mar 2026 05:01:15 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=qualcomm.com header.i=@qualcomm.com\n\theader.b=\"OBko4Tav\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n\theader.b=\"RaHAvyMi\"; dkim-atps=neutral", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n\tTmCwSNRDjMXD7FyELSBffXtyHj68sIz12Xk5gBuElFA=; b=OBko4Tavv52bT+tT\n\tN9PwwFNwre35pWL35EvgWQOJeJZioPtS6cBKWnXQuOJqfHVMLI+bMOg9gw6RQiiU\n\t7f5OIS8sS2Zh3E0+gCrnVAE4JzYXxDH/BmTPouWTZh95CrAlFc/Uwvx25KxWdeRU\n\tBBtlyGAI/U33EOw1NQhPkAdNVw7ALCPeoQcPJlXBLluD+quvyUQ+CX1ByMkZjxuP\n\to2lFY2U7eJghnKLq0INQWF/PbA77ZVg1hlsDgPTwR8awNaw132SQRNC0m5a0iJNf\n\t+FtjJojkEBHHffHRhacAVKdyxumsZz1ET6ylmcnT/5hLwVc86VeRFsAY9iMp1JR/\n\tzxNGyw==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=oss.qualcomm.com; s=google; t=1773144077; x=1773748877;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=TmCwSNRDjMXD7FyELSBffXtyHj68sIz12Xk5gBuElFA=;\n\tb=RaHAvyMi6jDQk6wRAjDLW1R0M5BHBs7q+ZbylXRZZyBmUAFsW663oDZAlCpQMmcEkM\n\tyFv2DvnPFNUoZlxhKdxremHoQwjbS2pQ8GVG57dxq5FjO1N779NSGYWxxWL+wQETaTWV\n\t3tfwj32wS33zu6eMv+BoCRlUD+q61qcKChDSxBfNJHnYymdipGHR4MAANjojLReaCK9p\n\t42VdGLpBykcReul5hecF1/ZIgTdg6o00o0e3VVFR+IZX/4fgVtrBLa5xAvjvTrYuuYGo\n\tPTIbVzMy058xo8WkYhIb8GHYo7525u3JO1o6vv4Kvp8U5tIU60+EgZkNmtIS2e0/vD+b\n\tPiew==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1773144077; x=1773748877;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=TmCwSNRDjMXD7FyELSBffXtyHj68sIz12Xk5gBuElFA=;\n\tb=DSTS+YvnaoZoLT005PCe0A6XaHwKWDOg93UTPhKQ7/OZqEA4lNgALpnwQp1CtvlYlk\n\tfgsUuBjR7lGOFXWsRLininRyyAlDh3CbpbBMT48rsVWKOO69/FhccaHfUWa7+Yxwqzhv\n\tRvlzlNUseuxjcny+QeJ80yfnaf7a+NTtThBfP55zk4y/cZWCgwheDB1YVGuI6GKuQKm2\n\tviT2rjIL8aVBp+aUnd/cDr7O9PgJgn6kkMpQu+pA0rTp6ZeQlsinrytj+ikfJrPqPSHI\n\tyyMw86faMX3A7XU9t4wDfuxRM08z/UCnpeYwGdVv60IeGsMceKwLdxfcyGNF6eooz8f9\n\t/7xg==", "X-Gm-Message-State": "AOJu0YxZEHwfmTAcsGJSvP41bbkHAAfpGZG8+qzGfUZVtj3Fk13dFFLO\n\tBx52C1FhmDltvhIwTuIfuAif3IBYCEXkFOQPxuGjXj9vk6fw+Hlwul7yvwRK0VkOQkL9tGs71VL\n\tBTemAHyPGRBh1okVmLb6BuoWWyKio0d5h6QyAawuXd6LEeEFfff6Yuykc2ZowENgZIYwPtkkc8y\n\tTp0tOx5uGs", "X-Gm-Gg": "ATEYQzy/9Ey2b7M+k4WmhuBnC2cdB/aqX5X5DGgB4hhC7EGTjkpLI1MXRYxUfCQqY6x\n\tRutVNho9Zw+q0JYnadZ0/Bn+1RTFfs9zUBfK2kvwS2WLpAPCPNHsY+aj2HARjrQfgjrAKaDbgx9\n\tunJQ5tEk/CrXn61JSQM5LbIctBtauep7tgflZmXHrKFiGerksuAp+cLBAvjteVsfVp5pVdB8xZy\n\t8uCkvEq41IBF+lk8SuW5fwZKxrKEQDAhaeREwzLst1WKhvKCDKa5ciZDg43ZC8CVxw0IXLN4A3R\n\ty+TSu4P7mdD034PWMvXOy2AyAqIhsc5tOisB3LVDQ/ZTlJu8Tu51IFd0GxmCVHu35beL/4aOUGY\n\tm3al8BH2sIo/S8eywUab/iwqTFTcl/5sV22uwAEHcjGU3bWGZg66Y9472jr+mIUPFZ/s10Lw3vr\n\teTgSLk4fjxLnFVrlK2kGV9eEK93sS64vDAnA==", "X-Received": [ "by 2002:a05:6102:a51:b0:5ff:d434:b507 with SMTP id\n\tada2fe7eead31-5ffe5fcffc4mr5824044137.17.1773144076999; \n\tTue, 10 Mar 2026 05:01:16 -0700 (PDT)", "by 2002:a05:6102:a51:b0:5ff:d434:b507 with SMTP id\n\tada2fe7eead31-5ffe5fcffc4mr5823993137.17.1773144076369; \n\tTue, 10 Mar 2026 05:01:16 -0700 (PDT)" ], "From": "Hans de Goede <johannes.goede@oss.qualcomm.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, Hans de Goede\n\t<johannes.goede@oss.qualcomm.com>, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t<barnabas.pocze@ideasonboard.com>", "Subject": "[PATCH v7 4/5] software_isp: Log input config from configure()", "Date": "Tue, 10 Mar 2026 13:01:05 +0100", "Message-ID": "<20260310120106.79922-5-johannes.goede@oss.qualcomm.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260310120106.79922-1-johannes.goede@oss.qualcomm.com>", "References": "<20260310120106.79922-1-johannes.goede@oss.qualcomm.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Proofpoint-GUID": "jEx6vGWOmmJtkGjIMqU_cKy4p9_KA2ar", "X-Proofpoint-ORIG-GUID": "jEx6vGWOmmJtkGjIMqU_cKy4p9_KA2ar", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMzEwMDEwNCBTYWx0ZWRfX9NepCGqlBNSA\n\tJuwZTD9iNeDnQxUjR0F56Yux78yAc63wyKTcCBjLinvTtxhlck4Y35IFw/jV8rHE7VGklwTWAUa\n\tsBXhbEg1AYpNDWU8kNzmkF2RnDgfbXFgmSZ/njRMJM4vG9MXMOBzrFDxse8TEy1mCgzZgPYPvEO\n\tBGR+MmSHVEVSu5F04hNVCuVFOp6tICEXjBibn8rRHsSYYlgwUBmbth90mpXyrLJTKCf2uuPMIr5\n\ttvU84zTqJ5jZMlfZOy2j5fYO/YUZOhyCw5wSG+8AYUaieRh7Em2oPWIgk0iWjaijfn4NaYKU893\n\tRSrYBQ/dF0pISbQQrswYgdCJKu3+oZ2aWdooMVHnKU4KlBGlwXXbM/CZqlEP/xTsjbL+zt+ePQk\n\tldMozuK7Z6+rTfahGDCGECjrNhRCH/Ua8epKbZsXeJCF3b8d0GQ3AMDV/B9ojIoLz9R0bLxtVDj\n\tXnCVrFar7E6isFV948w==", "X-Authority-Analysis": "v=2.4 cv=Cuays34D c=1 sm=1 tr=0 ts=69b0080e cx=c_pps\n\ta=UbhLPJ621ZpgOD2l3yZY1w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10\n\ta=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22\n\ta=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=20KFwNOVAAAA:8\n\ta=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=mKg8M22OkPar6P-70WAA:9\n\ta=3ZKOabzyN94A:10\n\ta=QEXdDO2ut3YA:10 a=TOPH6uDL9cOC6tEoww4z:22 a=D0XLA9XvdZm18NrgonBM:22", "X-Proofpoint-Virus-Version": "vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1143, Hydra:6.1.51,\n\tFMLib:17.12.100.49\n\tdefinitions=2026-03-10_02,2026-03-09_02,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tmalwarescore=0 clxscore=1015 spamscore=0 adultscore=0\n\tpriorityscore=1501\n\tphishscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0\n\timpostorscore=0\n\tclassifier=typeunknown authscore=0 authtc= authcc= route=outbound\n\tadjust=0\n\treason=mlx scancount=1 engine=8.22.0-2602130000\n\tdefinitions=main-2603100104", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "As shown by commit 94d32fdc55a3 (\"pipeline: simple: Consider output sizes\nwhen choosing pipe config\"), the extra pixel columns CPU debayering\nrequires on the input side makes resolution selection non trivial.\n\nAdd logging of the selected input config on a successful configure() so\nthat the logs clearly show which sensor mode has been selected.\n\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nSigned-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>\n---\nChanges in v2:\n- Move from DebayerCpu::configure() to SoftwareIsp::configure() so that\n the input fmt also gets logged when using the DebayerEgl class\n---\n src/libcamera/software_isp/software_isp.cpp | 12 +++++++++++-\n 1 file changed, 11 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 562cdba22..4cf5639d9 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -21,6 +21,7 @@\n #include <libcamera/formats.h>\n #include <libcamera/stream.h>\n \n+#include \"libcamera/internal/bayer_format.h\"\n #include \"libcamera/internal/framebuffer.h\"\n #include \"libcamera/internal/ipa_manager.h\"\n #include \"libcamera/internal/software_isp/debayer_params.h\"\n@@ -270,7 +271,16 @@ int SoftwareIsp::configure(const StreamConfiguration &inputCfg,\n \tif (ret < 0)\n \t\treturn ret;\n \n-\treturn debayer_->configure(inputCfg, outputCfgs, ccmEnabled_);\n+\tret = debayer_->configure(inputCfg, outputCfgs, ccmEnabled_);\n+\tif (ret < 0)\n+\t\treturn ret;\n+\n+\tLOG(SoftwareIsp, Info)\n+\t\t<< \"Input \" << inputCfg.size\n+\t\t<< \"-\" << BayerFormat::fromPixelFormat(inputCfg.pixelFormat)\n+\t\t<< \" stride \" << inputCfg.stride;\n+\n+\treturn 0;\n }\n \n /**\n", "prefixes": [ "v7", "4/5" ] }