Patch Detail
Show a patch.
GET /api/patches/26236/?format=api
{ "id": 26236, "url": "https://patchwork.libcamera.org/api/patches/26236/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26236/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260224193745.106186-5-johannes.goede@oss.qualcomm.com>", "date": "2026-02-24T19:37:45", "name": "[v3,4/4] software_isp: Log input config from configure()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "93c9a5453fc1d9d8048bd86d2d99f47fb5d97f10", "submitter": { "id": 242, "url": "https://patchwork.libcamera.org/api/people/242/?format=api", "name": "Hans de Goede", "email": "johannes.goede@oss.qualcomm.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26236/mbox/", "series": [ { "id": 5811, "url": "https://patchwork.libcamera.org/api/series/5811/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5811", "date": "2026-02-24T19:37:41", "name": "software_isp: debayer_cpu: Add multi-threading support", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5811/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26236/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26236/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E2E51C32C8\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 24 Feb 2026 19:37:59 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8E106622AB;\n\tTue, 24 Feb 2026 20:37:59 +0100 (CET)", "from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com\n\t[205.220.180.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C84C6622AB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 Feb 2026 20:37:53 +0100 (CET)", "from pps.filterd (m0279873.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n\t61OFO7C52432689 for <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 Feb 2026 19:37:52 GMT", "from mail-qv1-f69.google.com (mail-qv1-f69.google.com\n\t[209.85.219.69])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4chekj8yh1-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 Feb 2026 19:37:52 +0000 (GMT)", "by mail-qv1-f69.google.com with SMTP id\n\t6a1803df08f44-899b041cc64so41666356d6.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 Feb 2026 11:37:52 -0800 (PST)", "from shalem\n\t(2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl.\n\t[2001:1c00:c32:7800:5bfa:a036:83f0:f9ec])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-b9084e8cb3fsm458232866b.48.2026.02.24.11.37.50\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 24 Feb 2026 11:37:50 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=qualcomm.com header.i=@qualcomm.com\n\theader.b=\"hhw1OqXp\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n\theader.b=\"hz+biL5J\"; dkim-atps=neutral", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:date:from:in-reply-to:message-id\n\t:mime-version:references:subject:to; s=qcppdkim1; bh=ia9XTQD3rvi\n\tOTPlc4kW0P9cX6uRJDrqGvpie2wAkg40=; b=hhw1OqXpkRgRqSHJclFcvs9D4R6\n\thD7z1t9ilaCGzdNEJ6+kTr2qutl7itHUTuWVOxWX6QEtR6FMbIRS8QuFcVZvFyIZ\n\tssDPkMGFIPa/fainaiLVQMP16gR0WWZC+q/TjJe3iLZgun6MmuDYURTxBkupPd6R\n\tISKbbXORsSNOkcvuj7/44QT6lIRJHQhyktuhJJpH9tCxk46mkjU65GponJwhNZUq\n\tMwqZFQzBvdO+uUwaYOiy94KIGGea5x7Jp5AyVJG9DZtartyQAU/x5SVFwWopHNCY\n\tTmY3UVTSFz/VTLZh81ZAjByon+jAtWo2kYsk6t+yfDTGnr5o3kZUk+Da8+g==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=oss.qualcomm.com; s=google; t=1771961871; x=1772566671;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=ia9XTQD3rviOTPlc4kW0P9cX6uRJDrqGvpie2wAkg40=;\n\tb=hz+biL5JAoRVzcNnxxV1S2OZyq7QkmOVB00X0/mlB8CDMvp7RxedC1+uoY5+RtHHdY\n\tjD9auW0+3HzqVS8TFMMYXMqgN8D39e940ErLfl1Km398oIQkE7zM/b5ZQlGJFLL/+U00\n\tV2+WCTF1kKt+6XqZCEJrkv7w5sumR68amGY3YkWengX51vI81tHgKkWl1PUrKE+nWzBv\n\tzL8V0ApoauHMORQjGf3+fBfxZHdaskxqEkzAz+nQnrOwNwuSd/e2I8ZJYL9i0LdWrXG0\n\tKlw47imS9MB4svEivD5VvkM8/Lx5KdD3EuA2eqYX4MvUDQmBrC3rJu9YDkK8kOdB3I5U\n\trG0g==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1771961871; x=1772566671;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=ia9XTQD3rviOTPlc4kW0P9cX6uRJDrqGvpie2wAkg40=;\n\tb=XvFVPXTY+ZF8QVsJsUPbwCw9uiOAwLqZKOTkgiErSOPjsLPtv1PQR5TyN8+7rzAGiS\n\tvMM50rRIW/fti7icCYeQw7Hgb6pR2DAKLXIM1CB5vfOlFnIB1OT8/1YVoOq8arH1SU9G\n\tlMJXkwwJWE9Q6gWfGXkJmQGYMlYy/38vKuANjttDzQElVmHZdwxp0YOG6WQ7IoNgKJhV\n\tA8mpotxAHkNHOh6MrtPe4PBiZ4w7vwm7fpSjqVd6QSiaxQZghaHKWneSKyZ5DADDl1lB\n\t/SO/avt2UDxUB5Zif6EiqXK7d4V1IfZ5dGo8p7fBYtayzNEO6p60Xve0fy/NC3yvkjGC\n\tbqAA==", "X-Gm-Message-State": "AOJu0YyMKjT8IL+X8wN8kuRE8doeufds69nb9IA3VQtzzCy8addEycO3\n\twKWJrKgBlwI9nJoAqyCO+ydrjjLAUMyLpT2oWTl8d/Mr4YIlSs7zaUMCmz3/jDUhSorBN82XTcB\n\tT761AKNERJSIzpQ0DQG7C8/QxaZzdCi0pDRiH1xlezeVj2V26TewJ1xWeAJ42DKchDzh/l/LcOH\n\tgwANlhIJ+t", "X-Gm-Gg": "AZuq6aIAPYglFSZDu9SvAe5Ty4I6FV8O7BU01YC59tXFDeO9SOpqeGl1YQ5+hVcKKOt\n\tQEzeb78jbSkNu2cfypLO+FITagnDJzo/dTuQTKc7ytTrXjfVTaOAkExVIGS57FOhmyL03jD28V7\n\t3VG7ODMZ+ZksCUAR34/8/8lC6DnD5UDfHhvt96rojsohLMnvwb58oyt0k6n9DTWyACWEpWcCuHy\n\tA4T7iONEhK1Xun1BhJrShBmSfoMEWqhv/F1lHdKw/2vYJqegyXPf9pPubqOtkGkyffnDCa8xfso\n\tWkXKyihLWqa6QBKv45F0BZVe6CVgjkTjXL62zfOds/1Ua+Iu/RN0tk04ihxP7KnUG9YT06msP17\n\t3Cw/2FAnu5UiZn+1RPbgH306XDM/15n9VlSgN/F/7qdvf3/YpiQws5PnbuidBoeYiChDrQTFTgN\n\tRxoYY4kla42i4V23WasZWPsAKLwBKjCzUUNFTl", "X-Received": [ "by 2002:a05:620a:7114:b0:8ca:934a:5e39 with SMTP id\n\taf79cd13be357-8cb8c9fe514mr1942639885a.19.1771961871566; \n\tTue, 24 Feb 2026 11:37:51 -0800 (PST)", "by 2002:a05:620a:7114:b0:8ca:934a:5e39 with SMTP id\n\taf79cd13be357-8cb8c9fe514mr1942635385a.19.1771961871016; \n\tTue, 24 Feb 2026 11:37:51 -0800 (PST)" ], "From": "Hans de Goede <johannes.goede@oss.qualcomm.com>", "To": "libcamera-devel@lists.libcamera.org, Milan Zamazal <mzamazal@redhat.com>", "Cc": "Hans de Goede <johannes.goede@oss.qualcomm.com>", "Subject": "[PATCH v3 4/4] software_isp: Log input config from configure()", "Date": "Tue, 24 Feb 2026 20:37:45 +0100", "Message-ID": "<20260224193745.106186-5-johannes.goede@oss.qualcomm.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260224193745.106186-1-johannes.goede@oss.qualcomm.com>", "References": "<20260224193745.106186-1-johannes.goede@oss.qualcomm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Authority-Analysis": "v=2.4 cv=RNe+3oi+ c=1 sm=1 tr=0 ts=699dfe10 cx=c_pps\n\ta=wEM5vcRIz55oU/E2lInRtA==:117 a=xqWC_Br6kY4A:10 a=HzLeVaNsDn8A:10\n\ta=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22\n\ta=rJkE3RaqiGZ5pbrm-msn:22 a=20KFwNOVAAAA:8 a=EUspDBNiAAAA:8\n\ta=mKg8M22OkPar6P-70WAA:9 a=OIgjcC2v60KrkQgK7BGD:22", "X-Proofpoint-ORIG-GUID": "IZAbtlJY_qdpP7ejR8K79SVZJeoCPAHL", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMjI0MDE2OCBTYWx0ZWRfX/HdZFxqNp/f7\n\tL/DsZs4d7axTsIA4rH2GPSS51jvxzCwXylOun81Ny+Bi5qddijSGZMO7Lu72IvfnHoJnMI+1s61\n\thsLHuTtMSZufbeDnQSbNxj14qZ4K5fpknBM6eswT9wCmOQiI82MX+rUSVEU2WXpvNOevBG6QE1K\n\t5WxlaAEm0FdRkacpQ8HzTzsQ1WfSHi6uQ04v9for3OPaoBdLQw1IabcdaF/X0QoCSHEyADag9fE\n\tQp9pyVHhJzxC79VXiN2hiyFk1UI45NrEW4/orRfoLcF5ve3oV5cY9XcJC3jgd/7jD6Sq6o09jS2\n\tentoYTWn8ZA3/zP6L0mt+vKPDS9qocAxDRqBbFbLP6jKbPGNzjK1iocdh6jCZmwsyxSai1IrX+S\n\tUKBDbXp0bhem+ov1Pscf+CRr0ul8EPieWVOQSir691ZQT5pB5plqskBfhJ2V7gAs0IV9tBZnAEm\n\tqWonAenTtUZ2HP+vpsQ==", "X-Proofpoint-GUID": "IZAbtlJY_qdpP7ejR8K79SVZJeoCPAHL", "X-Proofpoint-Virus-Version": "vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1121, Hydra:6.1.51,\n\tFMLib:17.12.100.49\n\tdefinitions=2026-02-24_02,2026-02-23_03,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tbulkscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501\n\tphishscore=0\n\tclxscore=1015 spamscore=0 impostorscore=0 suspectscore=0\n\tmalwarescore=0\n\tclassifier=typeunknown authscore=0 authtc= authcc= route=outbound\n\tadjust=0\n\treason=mlx scancount=1 engine=8.22.0-2602130000\n\tdefinitions=main-2602240168", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "As shown by commit 94d32fdc55a3 (\"pipeline: simple: Consider output sizes\nwhen choosing pipe config\"), the extra pixel columns CPU debayering\nrequires on the input side makes resolution selection non trivial.\n\nAdd logging of the selected input config on a successful configure() so\nthat the logs clearly show which sensor mode has been selected.\n\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>\n---\nChanges in v3:\n- Move from DebayerCpu::configure() to SoftwareIsp::configure() so that\n the input fmt also gets logged when using the DebayerEgl class\n\nChanges in v2:\n- New patch in v2 series\n---\n src/libcamera/software_isp/software_isp.cpp | 12 +++++++++++-\n 1 file changed, 11 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 562cdba2..4cf5639d 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -21,6 +21,7 @@\n #include <libcamera/formats.h>\n #include <libcamera/stream.h>\n \n+#include \"libcamera/internal/bayer_format.h\"\n #include \"libcamera/internal/framebuffer.h\"\n #include \"libcamera/internal/ipa_manager.h\"\n #include \"libcamera/internal/software_isp/debayer_params.h\"\n@@ -270,7 +271,16 @@ int SoftwareIsp::configure(const StreamConfiguration &inputCfg,\n \tif (ret < 0)\n \t\treturn ret;\n \n-\treturn debayer_->configure(inputCfg, outputCfgs, ccmEnabled_);\n+\tret = debayer_->configure(inputCfg, outputCfgs, ccmEnabled_);\n+\tif (ret < 0)\n+\t\treturn ret;\n+\n+\tLOG(SoftwareIsp, Info)\n+\t\t<< \"Input \" << inputCfg.size\n+\t\t<< \"-\" << BayerFormat::fromPixelFormat(inputCfg.pixelFormat)\n+\t\t<< \" stride \" << inputCfg.stride;\n+\n+\treturn 0;\n }\n \n /**\n", "prefixes": [ "v3", "4/4" ] }