Patch Detail
Show a patch.
GET /api/patches/26222/?format=api
{ "id": 26222, "url": "https://patchwork.libcamera.org/api/patches/26222/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26222/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260220221636.216353-7-rui.wang@ideasonboard.com>", "date": "2026-02-20T22:16:35", "name": "[v2,6/7] ipa: rkisp1: filter: add metadata reporting and config logging", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f5c77d9cc768940f8d733c086ef19f1fd66944b2", "submitter": { "id": 241, "url": "https://patchwork.libcamera.org/api/people/241/?format=api", "name": "Rui Wang", "email": "rui.wang@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26222/mbox/", "series": [ { "id": 5806, "url": "https://patchwork.libcamera.org/api/series/5806/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5806", "date": "2026-02-20T22:16:29", "name": "ipa: rkisp1: make Filter tuning-driven and add manual controls", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5806/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26222/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26222/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 45D36C32EF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 20 Feb 2026 22:17:04 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E5ACF62280;\n\tFri, 20 Feb 2026 23:17:03 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 133B262288\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 20 Feb 2026 23:16:58 +0100 (CET)", "from rui-Precision-7560.tail5b760b.ts.net (unknown\n\t[209.216.103.65])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A4DA4591;\n\tFri, 20 Feb 2026 23:16:03 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gyWY9vlb\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1771625764;\n\tbh=FoxKhw+6ex2K6FH+ROijqZo5uUc7tOtAWVaIW4+Pn0I=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=gyWY9vlbTpxgHF+ec9khT/D2oVJUQvlSfrT1G5a3dy1xr80n+m5iaeafZ+X5rRELS\n\t9W64JcPITWwK3Zr8q02cgkD4zOJudk062R8hGO5CKE2oSS9/pRV+pA092z8sTwUR5P\n\ttkJEfwKNBQwffwynoBw4rJrI1PZtBsMrh5iklnl0=", "From": "Rui Wang <rui.wang@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Rui Wang <rui.wang@ideasonboard.com>", "Subject": "[PATCH v2 6/7] ipa: rkisp1: filter: add metadata reporting and\n\tconfig logging", "Date": "Fri, 20 Feb 2026 17:16:35 -0500", "Message-ID": "<20260220221636.216353-7-rui.wang@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260220221636.216353-1-rui.wang@ideasonboard.com>", "References": "<20260220221636.216353-1-rui.wang@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "-Implement filter metadata reporting in process() with fillMetadata(),\n -Add detailed logConfig() dump on updates,\n -Metadata now exports denoise/fac parameters from mode config\n with sharpness override when valid.\n\nSigned-off-by: Rui Wang <rui.wang@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/filter.cpp | 118 +++++++++++++++++++++++++++\n src/ipa/rkisp1/algorithms/filter.h | 7 ++\n 2 files changed, 125 insertions(+)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/filter.cpp b/src/ipa/rkisp1/algorithms/filter.cpp\nindex 48831791..0ac186f8 100644\n--- a/src/ipa/rkisp1/algorithms/filter.cpp\n+++ b/src/ipa/rkisp1/algorithms/filter.cpp\n@@ -400,6 +400,9 @@ void Filter::prepare([[maybe_unused]] IPAContext &context,\n \tconfig->fac_bl0 = modeParams[\"fac_bl0\"];\n \tconfig->fac_bl1 = modeParams[\"fac_bl1\"];\n \n+\tif (frameContext.filter.update)\n+\t\tlogConfig(frameContext);\n+\n \tif (sharpness == 0 or sharpness >= sharpness_.size()) {\n \t\tLOG(RkISP1Filter, Debug)\n \t\t\t<< \"Sharpness value out of range: \" << static_cast<int>(sharpness);\n@@ -418,6 +421,121 @@ void Filter::prepare([[maybe_unused]] IPAContext &context,\n \tconfig->fac_bl1 = sharp.at(\"fac_bl1\");\n }\n \n+void Filter::logConfig(const IPAFrameContext &frameContext) const\n+{\n+\tuint8_t denoise = frameContext.filter.denoise;\n+\tuint8_t sharpness = frameContext.filter.sharpness;\n+\n+\tstd::ostringstream ss;\n+\tss << \"Filter config: mode=\" << static_cast<int>(denoise)\n+\t << \", sharpness=\" << static_cast<int>(sharpness);\n+\n+\t/* Log denoise values from mode config. */\n+\tauto it = modes_.find(denoise);\n+\tif (it != modes_.end()) {\n+\t\tconst auto &modeParams = it->second;\n+\t\tfor (const auto &key : kFilterKeyNames) {\n+\t\t\tauto keyIt = modeParams.find(key);\n+\t\t\tif (keyIt != modeParams.end())\n+\t\t\t\tss << \", \" << key << \"=\" << keyIt->second;\n+\t\t\telse\n+\t\t\t\tss << \", \" << key << \"=<missing>\";\n+\t\t}\n+\t}\n+\n+\t/* No sharpness factors need to be logged. */\n+\tif (sharpness == 0 or sharpness >= sharpness_.size()) {\n+\t\tLOG(RkISP1Filter, Debug) << ss.str();\n+\t\treturn;\n+\t}\n+\n+\t/* Log sharpness factors. */\n+\tif (sharpness < sharpness_.size()) {\n+\t\tconst auto &sharp = sharpness_[sharpness];\n+\t\tfor (const auto &key : kSharpnessKeyNames) {\n+\t\t\tauto keyIt = sharp.find(key);\n+\t\t\tif (keyIt != sharp.end())\n+\t\t\t\tss << \", \" << key << \"=\" << keyIt->second;\n+\t\t\telse\n+\t\t\t\tss << \", \" << key << \"=<missing>\";\n+\t\t}\n+\t}\n+\n+\tLOG(RkISP1Filter, Debug) << ss.str();\n+}\n+\n+void Filter::fillMetadata(IPAFrameContext &frameContext,\n+\t\t\t ControlList &metadata)\n+{\n+\tuint8_t denoise = frameContext.filter.denoise;\n+\tuint8_t sharpness = frameContext.filter.sharpness;\n+\n+\tif (denoise == controls::draft::NoiseReductionModeOff)\n+\t\treturn;\n+\n+\t/* Report denoise values from mode config. */\n+\tauto it = modes_.find(denoise);\n+\tif (it == modes_.end())\n+\t\treturn;\n+\n+\tconst auto &modeParams = it->second;\n+\tmetadata.set(controls::rkisp1::FilterThreshSh0,\n+\t\t static_cast<int32_t>(modeParams.at(\"thresh_sh0\")));\n+\tmetadata.set(controls::rkisp1::FilterThreshSh1,\n+\t\t static_cast<int32_t>(modeParams.at(\"thresh_sh1\")));\n+\tmetadata.set(controls::rkisp1::FilterThreshBl0,\n+\t\t static_cast<int32_t>(modeParams.at(\"thresh_bl0\")));\n+\tmetadata.set(controls::rkisp1::FilterThreshBl1,\n+\t\t static_cast<int32_t>(modeParams.at(\"thresh_bl1\")));\n+\tmetadata.set(controls::rkisp1::FilterDenoiseMode,\n+\t\t static_cast<int32_t>(modeParams.at(\"mode\")));\n+\tmetadata.set(controls::rkisp1::FilterDenoiseLumWeight,\n+\t\t static_cast<int32_t>(modeParams.at(\"lum_weight\")));\n+\tmetadata.set(controls::rkisp1::FilterDenoiseGreenStage1,\n+\t\t static_cast<int32_t>(modeParams.at(\"grn_stage1\")));\n+\tmetadata.set(controls::rkisp1::FilterDenoiseChrVMode,\n+\t\t static_cast<int32_t>(modeParams.at(\"chr_v_mode\")));\n+\tmetadata.set(controls::rkisp1::FilterDenoiseChrHMode,\n+\t\t static_cast<int32_t>(modeParams.at(\"chr_h_mode\")));\n+\tmetadata.set(controls::rkisp1::FilterFacSh0,\n+\t\t static_cast<int32_t>(modeParams.at(\"fac_sh0\")));\n+\tmetadata.set(controls::rkisp1::FilterFacSh1,\n+\t\t static_cast<int32_t>(modeParams.at(\"fac_sh1\")));\n+\tmetadata.set(controls::rkisp1::FilterFacMid,\n+\t\t static_cast<int32_t>(modeParams.at(\"fac_mid\")));\n+\tmetadata.set(controls::rkisp1::FilterFacBl0,\n+\t\t static_cast<int32_t>(modeParams.at(\"fac_bl0\")));\n+\tmetadata.set(controls::rkisp1::FilterFacBl1,\n+\t\t static_cast<int32_t>(modeParams.at(\"fac_bl1\")));\n+\n+\tif (sharpness == 0 or sharpness >= sharpness_.size())\n+\t\treturn;\n+\n+\tconst auto &sharp = sharpness_[sharpness];\n+\n+\tmetadata.set(controls::rkisp1::FilterFacSh0,\n+\t\t static_cast<int32_t>(sharp.at(\"fac_sh0\")));\n+\tmetadata.set(controls::rkisp1::FilterFacSh1,\n+\t\t static_cast<int32_t>(sharp.at(\"fac_sh1\")));\n+\tmetadata.set(controls::rkisp1::FilterFacMid,\n+\t\t static_cast<int32_t>(sharp.at(\"fac_mid\")));\n+\tmetadata.set(controls::rkisp1::FilterFacBl0,\n+\t\t static_cast<int32_t>(sharp.at(\"fac_bl0\")));\n+\tmetadata.set(controls::rkisp1::FilterFacBl1,\n+\t\t static_cast<int32_t>(sharp.at(\"fac_bl1\")));\n+}\n+\n+/**\n+ * \\copydoc libcamera::ipa::Algorithm::process\n+ */\n+void Filter::process([[maybe_unused]] IPAContext &context, [[maybe_unused]] const uint32_t frame,\n+\t\t IPAFrameContext &frameContext,\n+\t\t [[maybe_unused]] const rkisp1_stat_buffer *stats,\n+\t\t ControlList &metadata)\n+{\n+\tfillMetadata(frameContext, metadata);\n+}\n+\n REGISTER_IPA_ALGORITHM(Filter, \"Filter\")\n \n } /* namespace ipa::rkisp1::algorithms */\ndiff --git a/src/ipa/rkisp1/algorithms/filter.h b/src/ipa/rkisp1/algorithms/filter.h\nindex e6f36df3..58df3d8d 100644\n--- a/src/ipa/rkisp1/algorithms/filter.h\n+++ b/src/ipa/rkisp1/algorithms/filter.h\n@@ -28,6 +28,10 @@ public:\n \tvoid prepare(IPAContext &context, const uint32_t frame,\n \t\t IPAFrameContext &frameContext,\n \t\t RkISP1Params *params) override;\n+\tvoid process(IPAContext &context, const uint32_t frame,\n+\t\t IPAFrameContext &frameContext,\n+\t\t const rkisp1_stat_buffer *stats,\n+\t\t ControlList &metadata) override;\n \n private:\n \tint parseConfig(const YamlObject &tuningData);\n@@ -37,6 +41,9 @@ private:\n \t\t\t\t std::unordered_map<std::string, uint32_t> &sharpParams);\n \tvoid registerControls(IPAContext &context);\n \tbool parseControls(const ControlList &controls);\n+\tvoid fillMetadata(IPAFrameContext &frameContext,\n+\t\t\t ControlList &metadata);\n+\tvoid logConfig(const IPAFrameContext &frameContext) const;\n \n \tstd::unordered_map<int32_t, std::unordered_map<std::string, uint32_t>> modes_;\n \tstd::vector<std::unordered_map<std::string, uint32_t>> sharpness_;\n", "prefixes": [ "v2", "6/7" ] }