Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 26194,
    "url": "https://patchwork.libcamera.org/api/patches/26194/?format=api",
    "web_url": "https://patchwork.libcamera.org/patch/26194/",
    "project": {
        "id": 1,
        "url": "https://patchwork.libcamera.org/api/projects/1/?format=api",
        "name": "libcamera",
        "link_name": "libcamera",
        "list_id": "libcamera_core",
        "list_email": "libcamera-devel@lists.libcamera.org",
        "web_url": "",
        "scm_url": "",
        "webscm_url": ""
    },
    "msgid": "<20260219144040.1615042-3-laurent.pinchart@ideasonboard.com>",
    "date": "2026-02-19T14:40:38",
    "name": "[v3,2/4] libcamera: Replace iterators with range-based for loops",
    "commit_ref": "a736fe8531b27c4ebb0a71064beaecd35be69250",
    "pull_url": null,
    "state": "accepted",
    "archived": false,
    "hash": "b88bdc3d7b44b9d2c9c97af8a95b2abfb12c1cd1",
    "submitter": {
        "id": 2,
        "url": "https://patchwork.libcamera.org/api/people/2/?format=api",
        "name": "Laurent Pinchart",
        "email": "laurent.pinchart@ideasonboard.com"
    },
    "delegate": null,
    "mbox": "https://patchwork.libcamera.org/patch/26194/mbox/",
    "series": [
        {
            "id": 5801,
            "url": "https://patchwork.libcamera.org/api/series/5801/?format=api",
            "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5801",
            "date": "2026-02-19T14:40:36",
            "name": "libcamera: Clean up iterators",
            "version": 3,
            "mbox": "https://patchwork.libcamera.org/series/5801/mbox/"
        }
    ],
    "comments": "https://patchwork.libcamera.org/api/patches/26194/comments/",
    "check": "pending",
    "checks": "https://patchwork.libcamera.org/api/patches/26194/checks/",
    "tags": {},
    "headers": {
        "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>",
        "X-Original-To": "parsemail@patchwork.libcamera.org",
        "Delivered-To": "parsemail@patchwork.libcamera.org",
        "Received": [
            "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A458BC31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 19 Feb 2026 14:40:52 +0000 (UTC)",
            "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5F82162254;\n\tThu, 19 Feb 2026 15:40:52 +0100 (CET)",
            "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 73E07620C9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 19 Feb 2026 15:40:51 +0100 (CET)",
            "from killaraus.ideasonboard.com (unknown [83.245.237.175])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 3CE6F55C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 19 Feb 2026 15:39:58 +0100 (CET)"
        ],
        "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"B8h8/r62\"; dkim-atps=neutral",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1771511998;\n\tbh=V/QLsmVjr2Ft6/BYA5jf2q0T6yRj9aEjy3TZ0j51G8Y=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=B8h8/r62F6SMX8DLmC66ZL8v+P4asGRyoj2OPyZN0SRDjCoWo2f3htDymNrZFkrJe\n\t1A2xgJE4+nGTOGG0u6jtB3gNH0HH7cuomKphEJgs7S5itIYq+pTzYB20VHfm+j/lFT\n\th3XJoQxhpzqku0egOk6Of9z4wgXYR2kYIK23ufgE=",
        "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>",
        "To": "libcamera-devel@lists.libcamera.org",
        "Subject": "[PATCH v3 2/4] libcamera: Replace iterators with range-based for\n\tloops",
        "Date": "Thu, 19 Feb 2026 15:40:38 +0100",
        "Message-ID": "<20260219144040.1615042-3-laurent.pinchart@ideasonboard.com>",
        "X-Mailer": "git-send-email 2.52.0",
        "In-Reply-To": "<20260219144040.1615042-1-laurent.pinchart@ideasonboard.com>",
        "References": "<20260219144040.1615042-1-laurent.pinchart@ideasonboard.com>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=UTF-8",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "libcamera-devel@lists.libcamera.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "<libcamera-devel.lists.libcamera.org>",
        "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>",
        "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>",
        "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>",
        "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>",
        "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>",
        "Errors-To": "libcamera-devel-bounces@lists.libcamera.org",
        "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"
    },
    "content": "Use range-based for loops instead of iterators when iterating over a\ncontainer. This improves readability.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n include/libcamera/base/utils.h       |  8 ++---\n src/gstreamer/gstlibcamera-utils.cpp | 50 +++++++++++-----------------\n src/ipa/rpi/controller/rpi/agc.cpp   |  4 +--\n 3 files changed, 26 insertions(+), 36 deletions(-)",
    "diff": "diff --git a/include/libcamera/base/utils.h b/include/libcamera/base/utils.h\nindex 4373bc20d42e..37f0d065f82f 100644\n--- a/include/libcamera/base/utils.h\n+++ b/include/libcamera/base/utils.h\n@@ -110,13 +110,13 @@ std::string join(const Container &items, const std::string &sep, UnaryOp op)\n \tstd::ostringstream ss;\n \tbool first = true;\n \n-\tfor (auto it = std::begin(items); it != std::end(items); ++it) {\n+\tfor (const auto &item : items) {\n \t\tif (!first)\n \t\t\tss << sep;\n \t\telse\n \t\t\tfirst = false;\n \n-\t\tss << op(*it);\n+\t\tss << op(item);\n \t}\n \n \treturn ss.str();\n@@ -128,13 +128,13 @@ std::string join(const Container &items, const std::string &sep)\n \tstd::ostringstream ss;\n \tbool first = true;\n \n-\tfor (auto it = std::begin(items); it != std::end(items); ++it) {\n+\tfor (const auto &item : items) {\n \t\tif (!first)\n \t\t\tss << sep;\n \t\telse\n \t\t\tfirst = false;\n \n-\t\tss << *it;\n+\t\tss << item;\n \t}\n \n \treturn ss.str();\ndiff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\nindex bfb094c94641..6541d478c83d 100644\n--- a/src/gstreamer/gstlibcamera-utils.cpp\n+++ b/src/gstreamer/gstlibcamera-utils.cpp\n@@ -749,10 +749,9 @@ int gst_libcamera_set_structure_field(GstStructure *structure, const ControlId *\n \tswitch (value.type()) {\n \tcase ControlTypeBool:\n \t\tif (is_array) {\n-\t\t\tSpan<const bool> data = value.get<Span<const bool>>();\n-\t\t\tfor (auto it = data.begin(); it != data.end(); ++it) {\n+\t\t\tfor (const auto &item : value.get<Span<const bool>>()) {\n \t\t\t\tg_value_init(&x, type);\n-\t\t\t\tg_value_set_boolean(&x, *it);\n+\t\t\t\tg_value_set_boolean(&x, item);\n \t\t\t\tgst_value_array_append_and_take_value(&v, &x);\n \t\t\t}\n \t\t} else {\n@@ -762,10 +761,9 @@ int gst_libcamera_set_structure_field(GstStructure *structure, const ControlId *\n \t\tbreak;\n \tcase ControlTypeByte:\n \t\tif (is_array) {\n-\t\t\tSpan<const uint8_t> data = value.get<Span<const uint8_t>>();\n-\t\t\tfor (auto it = data.begin(); it != data.end(); ++it) {\n+\t\t\tfor (const auto &item : value.get<Span<const uint8_t>>()) {\n \t\t\t\tg_value_init(&x, type);\n-\t\t\t\tg_value_set_uint(&x, *it);\n+\t\t\t\tg_value_set_uint(&x, item);\n \t\t\t\tgst_value_array_append_and_take_value(&v, &x);\n \t\t\t}\n \t\t} else {\n@@ -775,10 +773,9 @@ int gst_libcamera_set_structure_field(GstStructure *structure, const ControlId *\n \t\tbreak;\n \tcase ControlTypeUnsigned16:\n \t\tif (is_array) {\n-\t\t\tSpan<const uint16_t> data = value.get<Span<const uint16_t>>();\n-\t\t\tfor (auto it = data.begin(); it != data.end(); ++it) {\n+\t\t\tfor (const auto &item : value.get<Span<const uint16_t>>()) {\n \t\t\t\tg_value_init(&x, type);\n-\t\t\t\tg_value_set_uint(&x, *it);\n+\t\t\t\tg_value_set_uint(&x, item);\n \t\t\t\tgst_value_array_append_and_take_value(&v, &x);\n \t\t\t}\n \t\t} else {\n@@ -788,10 +785,9 @@ int gst_libcamera_set_structure_field(GstStructure *structure, const ControlId *\n \t\tbreak;\n \tcase ControlTypeUnsigned32:\n \t\tif (is_array) {\n-\t\t\tSpan<const uint32_t> data = value.get<Span<const uint32_t>>();\n-\t\t\tfor (auto it = data.begin(); it != data.end(); ++it) {\n+\t\t\tfor (const auto &item : value.get<Span<const uint32_t>>()) {\n \t\t\t\tg_value_init(&x, type);\n-\t\t\t\tg_value_set_uint(&x, *it);\n+\t\t\t\tg_value_set_uint(&x, item);\n \t\t\t\tgst_value_array_append_and_take_value(&v, &x);\n \t\t\t}\n \t\t} else {\n@@ -801,10 +797,9 @@ int gst_libcamera_set_structure_field(GstStructure *structure, const ControlId *\n \t\tbreak;\n \tcase ControlTypeInteger32:\n \t\tif (is_array) {\n-\t\t\tSpan<const int32_t> data = value.get<Span<const int32_t>>();\n-\t\t\tfor (auto it = data.begin(); it != data.end(); ++it) {\n+\t\t\tfor (const auto &item : value.get<Span<const int32_t>>()) {\n \t\t\t\tg_value_init(&x, type);\n-\t\t\t\tg_value_set_int(&x, *it);\n+\t\t\t\tg_value_set_int(&x, item);\n \t\t\t\tgst_value_array_append_and_take_value(&v, &x);\n \t\t\t}\n \t\t} else {\n@@ -827,10 +822,9 @@ int gst_libcamera_set_structure_field(GstStructure *structure, const ControlId *\n \t\tbreak;\n \tcase ControlTypeInteger64:\n \t\tif (is_array) {\n-\t\t\tSpan<const int64_t> data = value.get<Span<const int64_t>>();\n-\t\t\tfor (auto it = data.begin(); it != data.end(); ++it) {\n+\t\t\tfor (const auto &item : value.get<Span<const int64_t>>()) {\n \t\t\t\tg_value_init(&x, type);\n-\t\t\t\tg_value_set_int64(&x, *it);\n+\t\t\t\tg_value_set_int64(&x, item);\n \t\t\t\tgst_value_array_append_and_take_value(&v, &x);\n \t\t\t}\n \t\t} else {\n@@ -840,10 +834,9 @@ int gst_libcamera_set_structure_field(GstStructure *structure, const ControlId *\n \t\tbreak;\n \tcase ControlTypeFloat:\n \t\tif (is_array) {\n-\t\t\tSpan<const float> data = value.get<Span<const float>>();\n-\t\t\tfor (auto it = data.begin(); it != data.end(); ++it) {\n+\t\t\tfor (const auto &item : value.get<Span<const float>>()) {\n \t\t\t\tg_value_init(&x, type);\n-\t\t\t\tg_value_set_float(&x, *it);\n+\t\t\t\tg_value_set_float(&x, item);\n \t\t\t\tgst_value_array_append_and_take_value(&v, &x);\n \t\t\t}\n \t\t} else {\n@@ -862,27 +855,24 @@ int gst_libcamera_set_structure_field(GstStructure *structure, const ControlId *\n \t\tbreak;\n \tcase ControlTypeSize:\n \t\tif (is_array) {\n-\t\t\tSpan<const Size> data = value.get<Span<const Size>>();\n-\t\t\tfor (auto it = data.begin(); it != data.end(); ++it)\n-\t\t\t\tgst_libcamera_gvalue_set_size(&v, *it);\n+\t\t\tfor (const auto &item : value.get<Span<const Size>>())\n+\t\t\t\tgst_libcamera_gvalue_set_size(&v, item);\n \t\t} else {\n \t\t\tgst_libcamera_gvalue_set_size(&v, value.get<const Size>());\n \t\t}\n \t\tbreak;\n \tcase ControlTypePoint:\n \t\tif (is_array) {\n-\t\t\tSpan<const Point> data = value.get<Span<const Point>>();\n-\t\t\tfor (auto it = data.begin(); it != data.end(); ++it)\n-\t\t\t\tgst_libcamera_gvalue_set_point(&v, *it);\n+\t\t\tfor (const auto &item : value.get<Span<const Point>>())\n+\t\t\t\tgst_libcamera_gvalue_set_point(&v, item);\n \t\t} else {\n \t\t\tgst_libcamera_gvalue_set_point(&v, value.get<const Point>());\n \t\t}\n \t\tbreak;\n \tcase ControlTypeRectangle:\n \t\tif (is_array) {\n-\t\t\tSpan<const Rectangle> data = value.get<Span<const Rectangle>>();\n-\t\t\tfor (auto it = data.begin(); it != data.end(); ++it)\n-\t\t\t\tgst_libcamera_gvalue_set_rectangle(&v, *it);\n+\t\t\tfor (const auto &item : value.get<Span<const Rectangle>>())\n+\t\t\t\tgst_libcamera_gvalue_set_rectangle(&v, item);\n \t\t} else {\n \t\t\tgst_libcamera_gvalue_set_rectangle(&v, value.get<const Rectangle>());\n \t\t}\ndiff --git a/src/ipa/rpi/controller/rpi/agc.cpp b/src/ipa/rpi/controller/rpi/agc.cpp\nindex afda2e364f64..a8d91f43df29 100644\n--- a/src/ipa/rpi/controller/rpi/agc.cpp\n+++ b/src/ipa/rpi/controller/rpi/agc.cpp\n@@ -45,10 +45,10 @@ int Agc::read(const libcamera::YamlObject &params)\n \t}\n \n \tconst auto &channels = params[\"channels\"].asList();\n-\tfor (auto ch = channels.begin(); ch != channels.end(); ch++) {\n+\tfor (const auto &ch : channels) {\n \t\tLOG(RPiAgc, Debug) << \"Read AGC channel\";\n \t\tchannelData_.emplace_back();\n-\t\tint ret = channelData_.back().channel.read(*ch, getHardwareConfig());\n+\t\tint ret = channelData_.back().channel.read(ch, getHardwareConfig());\n \t\tif (ret)\n \t\t\treturn ret;\n \t}\n",
    "prefixes": [
        "v3",
        "2/4"
    ]
}