Patch Detail
Show a patch.
GET /api/patches/26190/?format=api
{ "id": 26190, "url": "https://patchwork.libcamera.org/api/patches/26190/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26190/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260218-kbingham-awb-cleanup-v3-3-3be1269ef949@ideasonboard.com>", "date": "2026-02-18T16:42:43", "name": "[v3,3/3] libcamera: software_isp: Fix LIBCAMERA_SOFTISP_MODE log print", "commit_ref": "da12b1854fbc0ec32d3162a0ab97654fcb679ae3", "pull_url": null, "state": "accepted", "archived": false, "hash": "3b9b703156bf16e2c4b0c70bf9fa722af4ca6d7a", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26190/mbox/", "series": [ { "id": 5799, "url": "https://patchwork.libcamera.org/api/series/5799/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5799", "date": "2026-02-18T16:42:40", "name": "ipa: awb: Fix and cleanup RKISP1 and Simple Awb", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5799/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26190/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26190/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 20819C0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 18 Feb 2026 16:47:31 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 778236222F;\n\tWed, 18 Feb 2026 17:47:28 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D7D9262222\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 18 Feb 2026 17:47:24 +0100 (CET)", "from ping.linuxembedded.co.uk\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 20913120E;\n\tWed, 18 Feb 2026 17:46:32 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"m9VbCWy8\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1771433192;\n\tbh=HyB1kZPgnFxfzcRZFBBV2QMSU4fcUweOSvAyR9wRJ6k=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=m9VbCWy8Ui0dJm0OFpY6oElN6il2VNZ9UeFUD0bf8ek+ObyCqutvqZlbb9Zo9hRPV\n\t8s9t8mDjsiQB1ht20nj4BTvHiWWdtGeZefRtFBu+HmSqJ16XGA0htVWb9hZ3B/VYFH\n\ts8/IPCqGhRH3b6H5xF+MrvxUJ1TvQYlGK80D3fnU=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Date": "Wed, 18 Feb 2026 16:42:43 +0000", "Subject": "[PATCH v3 3/3] libcamera: software_isp: Fix LIBCAMERA_SOFTISP_MODE\n\tlog print", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260218-kbingham-awb-cleanup-v3-3-3be1269ef949@ideasonboard.com>", "References": "<20260218-kbingham-awb-cleanup-v3-0-3be1269ef949@ideasonboard.com>", "In-Reply-To": "<20260218-kbingham-awb-cleanup-v3-0-3be1269ef949@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>, Jacopo Mondi\n\t<jacopo.mondi@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t<barnabas.pocze@ideasonboard.com>, Laurent Pinchart\n\t<laurent.pinchart@ideasonboard.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=ed25519-sha256; t=1771433243; l=1522;\n\ti=kieran.bingham@ideasonboard.com; s=20260207;\n\th=from:subject:message-id; \n\tbh=HyB1kZPgnFxfzcRZFBBV2QMSU4fcUweOSvAyR9wRJ6k=;\n\tb=9Nq67VH4wcZDAG+GAvjZdgcYkOwC+7vrzTHwYDHw08LF15vr/d9CayCnMxKuK9sq/vYlekE+R\n\tRGkxnGQ2+RCDzhrJUixYXUFzPpaVUbhXD+vcDcHmg082yWR8UkB9oit", "X-Developer-Key": "i=kieran.bingham@ideasonboard.com; a=ed25519;\n\tpk=FVXKN7YuwHc6UtbRUeTMAmranfsQomA+vnilfglWdaY=", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When an invalid parameter is specified to LIBCAMERA_SOFTISP_MODE, the\nerror log has a typo. Fix the typo and reflow the line while here.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n---\nv3:\n - Collect tags,\n - Clean up log message to Laurent's preference\n---\n src/libcamera/software_isp/software_isp.cpp | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex a83986b787b7..c2baaf0bf276 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -108,8 +108,10 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \tstd::optional<std::string> softISPMode = configuration.envOption(\"LIBCAMERA_SOFTISP_MODE\", { \"software_isp\", \"mode\" });\n \tif (softISPMode) {\n \t\tif (softISPMode != \"gpu\" && softISPMode != \"cpu\") {\n-\t\t\tLOG(SoftwareIsp, Error) << \"LIBCAMERA_SOFISP_MODE \" << softISPMode.value() << \" invalid \"\n-\t\t\t\t\t\t<< \"must be \\\"cpu\\\" or \\\"gpu\\\"\";\n+\t\t\tLOG(SoftwareIsp, Error)\n+\t\t\t\t<< \"Invalid LIBCAMERA_SOFTISP_MODE \\\"\"\n+\t\t\t\t<< softISPMode.value()\n+\t\t\t\t<< \"\\\", must be \\\"cpu\\\" or \\\"gpu\\\"\";\n \t\t\treturn;\n \t\t}\n \t}\n", "prefixes": [ "v3", "3/3" ] }