Patch Detail
Show a patch.
GET /api/patches/26159/?format=api
{ "id": 26159, "url": "https://patchwork.libcamera.org/api/patches/26159/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26159/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260215094418.18642-2-johannes.goede@oss.qualcomm.com>", "date": "2026-02-15T09:44:18", "name": "[v2,2/2] software_isp: benchmark: Print what is being benchmarked", "commit_ref": "7bcc2168bf5a7f7024f0535802ef5043d7dd709c", "pull_url": null, "state": "accepted", "archived": false, "hash": "295cbc1e1416a3b199c3f31253706c2af95e9775", "submitter": { "id": 242, "url": "https://patchwork.libcamera.org/api/people/242/?format=api", "name": "Hans de Goede", "email": "johannes.goede@oss.qualcomm.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26159/mbox/", "series": [ { "id": 5790, "url": "https://patchwork.libcamera.org/api/series/5790/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5790", "date": "2026-02-15T09:44:17", "name": "[v2,1/2] software_isp: benchmark: Add missing _ postfix to measure data member", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5790/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26159/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26159/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 48992BDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 15 Feb 2026 09:44:31 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EA172621E6;\n\tSun, 15 Feb 2026 10:44:30 +0100 (CET)", "from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n\t[205.220.168.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8BDE3621DC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 15 Feb 2026 10:44:28 +0100 (CET)", "from pps.filterd (m0279866.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n\t61F2rFTI3237632 for <libcamera-devel@lists.libcamera.org>;\n\tSun, 15 Feb 2026 09:44:26 GMT", "from mail-qk1-f200.google.com (mail-qk1-f200.google.com\n\t[209.85.222.200])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cajb8syeg-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 15 Feb 2026 09:44:26 +0000 (GMT)", "by mail-qk1-f200.google.com with SMTP id\n\taf79cd13be357-8c70d16d5a9so948816185a.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 15 Feb 2026 01:44:26 -0800 (PST)", "from shalem\n\t(2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl.\n\t[2001:1c00:c32:7800:5bfa:a036:83f0:f9ec])\n\tby smtp.gmail.com with ESMTPSA id\n\t4fb4d7f45d1cf-65bad3e390bsm1413658a12.17.2026.02.15.01.44.22\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 15 Feb 2026 01:44:23 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=qualcomm.com header.i=@qualcomm.com\n\theader.b=\"f93nTnTn\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n\theader.b=\"cwAIVRcW\"; dkim-atps=neutral", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:date:from:in-reply-to:message-id\n\t:mime-version:references:subject:to; s=qcppdkim1; bh=8rB32s2pJWU\n\t9N5Kc7jgkZ7/fW8xBa3EYGq+Nwba8F9A=; b=f93nTnTn6lvYnjWadUHN9VFuMng\n\tUWzQusS9s/rgPmyqYqH5ZFDM2lUvwMrQq+jaIHyw2Voqu5vdFA5pzqCZKK8VBu7u\n\tb8VG6tYKSBsENA9jgfm7BX1jAH4Vkmw7W7EMSj05oo41i5t5X2Zedm77hGDfC9HP\n\toDb+iHAf5U+7ct9lyzSh562BWydcnHcbt2FMw6as7D8S6WvVj9Rb0lRtNroWdv2w\n\tzlhbrjDbTPf+0/5IcYMbn77fEoiFWdT4K5jLOadRLYAlt+MepQ3Blgs0/y/rt2ev\n\tkNCVhSZqonUqvxov8K+96eIvZKzM8nZIoHQDo4boEXjCSJVNYXLP84SAMOw==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=oss.qualcomm.com; s=google; t=1771148665; x=1771753465;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=8rB32s2pJWU9N5Kc7jgkZ7/fW8xBa3EYGq+Nwba8F9A=;\n\tb=cwAIVRcWypwG9+qIus57NJ1NmMHXMI4dpIuB6KwwH2MAWc+6lWKXtS71E5iiC2SXZh\n\ttOHjNqrgzGI7SEAr3dTCU+kRU+zATYnFbuEmX8UQjFEVG5QeRLPJL6oHxKk1vRrwJv1O\n\tOWrVKTtIfdxQpVvuBzTsGhO3jYoRWUn8cZ3sFNwXUYgO18fy+cBkCP2MkPWZ6ClXl9ZC\n\tVQGlfHgPl07qhhsni9KZ33lga6ZcaB+lPGv0dlShiydWy8tQQjWzDh3PrKAfzumNKaEA\n\tlmoS0tSoDT5oaIUzAlmbYBqf/DkwcJMFPyRyYaosSpKI63EfUimuWWszbwjReEUnlf1C\n\tS11A==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1771148665; x=1771753465;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=8rB32s2pJWU9N5Kc7jgkZ7/fW8xBa3EYGq+Nwba8F9A=;\n\tb=RmhxVoujoBl+WxVdtHKL9yM8HARNbRmYxLB7DYVzB+Cu+Ik2eu11iMEQQsqGtzE87K\n\t9tfXTqUPpDOKUjgh5CJ7EU67BXuWZSutNeod0Vfz3siYmm4bnyTnwMgQxaDRzWWU+nLR\n\tPBGa1DwkftvLfHaPhdD6yE3fawAxls8HgyJn2NmWkze+FgJ9m7WQjh58E/JkWno9Koo4\n\tmjJv95yBv8PALR+oztpKSJqtvtgsdAPSv2mOe2+CZFu/f419+hQu0KCzFBVqsMFSFTb3\n\tacOv/MP+Oj8d+6aD7Qkaae674KKS6FVeRcRfB4Mjz8pVxtbXs/9pQIKdQfDkSzbeGrfG\n\tNEgw==", "X-Gm-Message-State": "AOJu0YxlRvLFMjm39jywkykMs18TpPjVa/uz8qDQ9DIuTt/lIfZaie6/\n\t+MCQd66ClS28BzF+tsqV0p1GIn86zH+qGF3PguNot4xtTet0R90KB4G6J0fnbQ33V/StKE57ebb\n\tf/rJJoGNIGPfCqp/fFVP9IRYgch4F/a7kwLU+ZLvBJyL4Cz028LYOpD3LN/Ah0EMqbshMYm8Fml\n\tKTHBCC7dc5", "X-Gm-Gg": "AZuq6aJapuHPqZ88aC/8rYSH3stg4n9VIy1Wm21TIbNGRwVwgdF2Vl4JVHAymEPJeAw\n\tX8LSsUgPwGmE1d7xMi0S5pTvJPToz09zqgsM09K1OJS4BxwJvHmS6awIKvhXMX2Hc3vu/jjqprG\n\tg5iTrSAJxi/x7E4iM7bf8pfJzoo2QmixvtPbFwhKT6P0zcP1ivtDe2Yzy/P/dPorNvXoeyPWohS\n\tFY/h37BxicgfiP9OOfoLGtr8b0XMi9otoQmVJK9efuTSAq6b5paSzB71vFpfkFjApEftAjNHOoP\n\t1JWz45BhV6iVAMzEE2a2S0gi5pv5C3Axor6dYmpPsnmgKbKa+YYll9njk7yE4/NIIpYkjrVOx0z\n\tfvG0PiIdHM381Jv/EwVJEmD0qjnx88SPIGVCRhBhVRUIJ8KzMtDG7uB7B7hzwxq6reM3BM4g7hx\n\tRyKvuWbV5njI3II0grMxblzigLtKSfyYsHc7S1", "X-Received": [ "by 2002:a05:620a:4101:b0:8b2:eea5:331b with SMTP id\n\taf79cd13be357-8cb4bf96e07mr540564085a.19.1771148665006; \n\tSun, 15 Feb 2026 01:44:25 -0800 (PST)", "by 2002:a05:620a:4101:b0:8b2:eea5:331b with SMTP id\n\taf79cd13be357-8cb4bf96e07mr540563185a.19.1771148664551; \n\tSun, 15 Feb 2026 01:44:24 -0800 (PST)" ], "From": "Hans de Goede <johannes.goede@oss.qualcomm.com>", "To": "libcamera-devel@lists.libcamera.org, Milan Zamazal <mzamazal@redhat.com>", "Cc": "Hans de Goede <johannes.goede@oss.qualcomm.com>", "Subject": "[PATCH v2 2/2] software_isp: benchmark: Print what is being\n\tbenchmarked", "Date": "Sun, 15 Feb 2026 10:44:18 +0100", "Message-ID": "<20260215094418.18642-2-johannes.goede@oss.qualcomm.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260215094418.18642-1-johannes.goede@oss.qualcomm.com>", "References": "<20260215094418.18642-1-johannes.goede@oss.qualcomm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMjE1MDA3NiBTYWx0ZWRfX3rrpRx71B9Uj\n\tF8oQRfLunN0B479cXPhdFDO3VLmN+LINKh/mgKTJEJAy6sjb3sFgM1I2u+ScTap8Mad148FjonK\n\tF7RQpePIT88chnALVcjobEfuWHCoVyqvkwtagMyd4Im5/T5wDXiykuW8gK9O/JJ/Eml7pr3N9or\n\tFldXHoifuDuk3F4xT5+tTS0gc0JwTWdCeCuc6VWVzIw75YYJyILCnoEK6TY3BN0r/nxKf53vshP\n\tZTdu4x6osAgREf7cmetSSwUD7RC24H6aaBoI0UlWafUeZWspTGAHJZCDjZBWADIytljw01dlhGH\n\tTxMfyCFhPSRspi6M6ID4/TT7dUgTtlt2JqEEheq32h5sXhlKtGa/786lJ0YYufLl9o6LCXsq0A3\n\t8qluZa13tLVb5d4vF9l5Z6MVqLgtKiBgMKTpF2vQsVQVpomPlo8vFMZVA2Hm23qPRnoWnmeXkKa\n\tjPf8uxWll3miofdWchg==", "X-Proofpoint-ORIG-GUID": "q9UoZxhNVjKztX7DYZFe4xUtMjRc3lLk", "X-Authority-Analysis": "v=2.4 cv=Pe/yRyhd c=1 sm=1 tr=0 ts=6991957a cx=c_pps\n\ta=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=HzLeVaNsDn8A:10\n\ta=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22\n\ta=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=l68oApq_WO2ZGngkTEkA:9\n\ta=PEH46H7Ffwr30OY-TuGO:22", "X-Proofpoint-GUID": "q9UoZxhNVjKztX7DYZFe4xUtMjRc3lLk", "X-Proofpoint-Virus-Version": "vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1121, Hydra:6.1.51,\n\tFMLib:17.12.100.49\n\tdefinitions=2026-02-15_03,2026-02-13_01,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tsuspectscore=0 adultscore=0 phishscore=0 lowpriorityscore=0\n\tspamscore=0\n\tbulkscore=0 malwarescore=0 clxscore=1015 priorityscore=1501\n\timpostorscore=0\n\tclassifier=typeunknown authscore=0 authtc= authcc= route=outbound\n\tadjust=0\n\treason=mlx scancount=1 engine=8.22.0-2601150000\n\tdefinitions=main-2602150076", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "With the GPU accelerated softISP 2 separate benchmark results are printed,\n1 for the generation of the output images on the GPU and a separate one\nfor generating the statistics on the CPU.\n\nAdd a new name argument to the Benchmark class descriptor and print this\nout when printing the benchmark result.\n\nSigned-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>\n---\nChanges in v2:\n- Add include <string> to benchmark.h\n- Use \": name_(name)\" in the Benchmark constructor to init name\n---\n include/libcamera/internal/software_isp/benchmark.h | 4 +++-\n src/libcamera/software_isp/benchmark.cpp | 5 +++--\n src/libcamera/software_isp/debayer.cpp | 3 ++-\n src/libcamera/software_isp/swstats_cpu.cpp | 2 +-\n 4 files changed, 9 insertions(+), 5 deletions(-)", "diff": "diff --git a/include/libcamera/internal/software_isp/benchmark.h b/include/libcamera/internal/software_isp/benchmark.h\nindex 46bdb86d..5526abc5 100644\n--- a/include/libcamera/internal/software_isp/benchmark.h\n+++ b/include/libcamera/internal/software_isp/benchmark.h\n@@ -11,6 +11,7 @@\n #pragma once\n \n #include <stdint.h>\n+#include <string>\n #include <time.h>\n #include <libcamera/base/log.h>\n #include \"libcamera/internal/global_configuration.h\"\n@@ -20,13 +21,14 @@ namespace libcamera {\n class Benchmark\n {\n public:\n-\tBenchmark(const GlobalConfiguration &configuration);\n+\tBenchmark(const GlobalConfiguration &configuration, const std::string &name);\n \t~Benchmark();\n \n \tvoid startFrame(void);\n \tvoid finishFrame(void);\n \n private:\n+\tstd::string name_;\n \ttimespec frameStartTime_;\n \tbool measure_;\n \t/* Skip 30 frames for things to stabilize then measure 30 frames */\ndiff --git a/src/libcamera/software_isp/benchmark.cpp b/src/libcamera/software_isp/benchmark.cpp\nindex 4ffb6773..36c49770 100644\n--- a/src/libcamera/software_isp/benchmark.cpp\n+++ b/src/libcamera/software_isp/benchmark.cpp\n@@ -26,7 +26,8 @@ LOG_DEFINE_CATEGORY(Benchmark)\n /**\n * \\brief Constructs a Benchmark object\n */\n-Benchmark::Benchmark(const GlobalConfiguration &configuration)\n+Benchmark::Benchmark(const GlobalConfiguration &configuration, const std::string &name)\n+\t: name_(name)\n {\n \tskipBeforeMeasure_ = configuration.option<unsigned int>(\n \t\t\t\t\t\t{ \"software_isp\", \"measure\", \"skip\" })\n@@ -81,7 +82,7 @@ void Benchmark::finishFrame(void)\n \t\tframeProcessTime_ += timeDiff(frameEndTime, frameStartTime_);\n \t\tif (encounteredFrames_ == skipBeforeMeasure_ + framesToMeasure_) {\n \t\t\tLOG(Benchmark, Info)\n-\t\t\t\t<< \"Processed \" << framesToMeasure_\n+\t\t\t\t<< name_ << \" processed \" << framesToMeasure_\n \t\t\t\t<< \" frames in \" << frameProcessTime_ / 1000 << \"us, \"\n \t\t\t\t<< frameProcessTime_ / (1000 * framesToMeasure_)\n \t\t\t\t<< \" us/frame\";\ndiff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\nindex dccdd86b..a6bceb58 100644\n--- a/src/libcamera/software_isp/debayer.cpp\n+++ b/src/libcamera/software_isp/debayer.cpp\n@@ -58,7 +58,8 @@ namespace libcamera {\n \n LOG_DEFINE_CATEGORY(Debayer)\n \n-Debayer::Debayer(const GlobalConfiguration &configuration) : bench_(configuration)\n+Debayer::Debayer(const GlobalConfiguration &configuration)\n+\t: bench_(configuration, \"Debayer\")\n {\n }\n \ndiff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\nindex 5c3011a7..1cedcfbc 100644\n--- a/src/libcamera/software_isp/swstats_cpu.cpp\n+++ b/src/libcamera/software_isp/swstats_cpu.cpp\n@@ -155,7 +155,7 @@ namespace libcamera {\n LOG_DEFINE_CATEGORY(SwStatsCpu)\n \n SwStatsCpu::SwStatsCpu(const GlobalConfiguration &configuration)\n-\t: sharedStats_(\"softIsp_stats\"), bench_(configuration)\n+\t: sharedStats_(\"softIsp_stats\"), bench_(configuration, \"CPU stats\")\n {\n \tif (!sharedStats_)\n \t\tLOG(SwStatsCpu, Error)\n", "prefixes": [ "v2", "2/2" ] }