Patch Detail
Show a patch.
GET /api/patches/26133/?format=api
{ "id": 26133, "url": "https://patchwork.libcamera.org/api/patches/26133/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26133/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260211170037.131630-1-johannes.goede@oss.qualcomm.com>", "date": "2026-02-11T17:00:36", "name": "[1/2] software_isp: benchmark: Add missing _ postfix to measure data member", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f4b6816ed87497d25ce00da4c846afea84ab8300", "submitter": { "id": 242, "url": "https://patchwork.libcamera.org/api/people/242/?format=api", "name": "Hans de Goede", "email": "johannes.goede@oss.qualcomm.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26133/mbox/", "series": [ { "id": 5785, "url": "https://patchwork.libcamera.org/api/series/5785/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5785", "date": "2026-02-11T17:00:36", "name": "[1/2] software_isp: benchmark: Add missing _ postfix to measure data member", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5785/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26133/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26133/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 06C80BD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 11 Feb 2026 17:00:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CF4F1621BD;\n\tWed, 11 Feb 2026 18:00:46 +0100 (CET)", "from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com\n\t[205.220.180.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 248AE620C9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 11 Feb 2026 18:00:45 +0100 (CET)", "from pps.filterd (m0279873.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n\t61B96kmb3259680 for <libcamera-devel@lists.libcamera.org>;\n\tWed, 11 Feb 2026 17:00:43 GMT", "from mail-qk1-f198.google.com (mail-qk1-f198.google.com\n\t[209.85.222.198])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c88wqm21k-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 11 Feb 2026 17:00:43 +0000 (GMT)", "by mail-qk1-f198.google.com with SMTP id\n\taf79cd13be357-8c70fadd9a3so2071661685a.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 11 Feb 2026 09:00:43 -0800 (PST)", "from shalem\n\t(2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl.\n\t[2001:1c00:c32:7800:5bfa:a036:83f0:f9ec])\n\tby smtp.gmail.com with ESMTPSA id\n\t4fb4d7f45d1cf-65a3cebf697sm867606a12.10.2026.02.11.09.00.38\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 11 Feb 2026 09:00:38 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=qualcomm.com header.i=@qualcomm.com\n\theader.b=\"iJeZOSUG\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n\theader.b=\"f2zF24DQ\"; dkim-atps=neutral", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:date:from:message-id:mime-version\n\t:subject:to; s=qcppdkim1; bh=4F/ABCUgGqqyRoOW2aPvMIYTQKJ5G9FDZgT\n\todHMLqjo=; b=iJeZOSUGZsAAGrSuBTpKoLgVJ43SRQttiIV99WybkN9JsonORMt\n\tLR1sConBGBTfhtYFyH9vJn6PbNA1nn0BRK43blnCaUgrP0YMc1x1F1gBAKShX7Fs\n\tx24kZ+ocf5IOnmpxtCB/91+P7nstFtMVY+KO1dHXeieTnvaNqnLsjl0EzRu2Tc6z\n\t/neAGQ/dvkbae8UNMB+NvXj717QHJr0AH8XEmC7/JvOkagYvksBbl9ReodTnBqQM\n\tW6ppfvI5vOWdS3oI6kAkWFtvSYWNlDLAm7t/hVi1H/7qPjxYbiH1LcqqldVfDFQu\n\ti+Plxsu6c9WvWWMHA7x/OYj8IMzQOQn/Bhw==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=oss.qualcomm.com; s=google; t=1770829243; x=1771434043;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=4F/ABCUgGqqyRoOW2aPvMIYTQKJ5G9FDZgTodHMLqjo=;\n\tb=f2zF24DQ7qSmv5Hb0sXXQsKgTGrVK2OlrSQE47kUwGSg2/cTZBNtJCaTeUlTP8/f2r\n\tbeshKr2u6T58Yk9neMiiUufMPAI9wxK/DhDNqOdZU7bu2qLaGs3ftyN2wbIrSDJRUMpB\n\tM9pO8+KwHa1ygZG+E/TpBBegUoKkOgt+kVh3RE2/vdcS4KpelGyesBWivWRgOpJeFaJY\n\tAbyBy7aKc211qiOhn1Ru+gL5yPSl9saEvF/p7Lm7tbvrGlu6ndyfU33zzROZkZHzg2YJ\n\taGrFlWNWaCHLgLcFYWmKkYmyq3DXnXzj2fqCdWyue0XDBGZhcGg8RLm143I7eRpH5vxQ\n\t3gVg==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1770829243; x=1771434043;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=4F/ABCUgGqqyRoOW2aPvMIYTQKJ5G9FDZgTodHMLqjo=;\n\tb=GTIg7xp/c+8e5axWqzmXrWYnR3OHMISXSpdcISJKW7lBqa7MEBV9Ifnyu87G7W1Kie\n\tUSgjZfQxxjheVXCfidH6wEtA8H3cU0Q0Z0ChlINg/gpZpyGQ/ROn2nBXonlQAk47N310\n\tRN7B8vVb1XdeZnnCwWFak30lIWPH1hSFSc1YBuSFm4APulqPSnyP4iXIX8clBcxiKNnn\n\tJk7Pofj7MsSZtXWAfuHDJabyqJ5tKiEewOIBw5Tmr+8SsLZtFi79Xha+qvq2U2JmuewD\n\tQfCblz9g9FIgHrwJXXfKFvb/w6kgC24LbO33ILlpynt6Dyw0bD4oXX3jHo3xeFevl/jf\n\tcofw==", "X-Gm-Message-State": "AOJu0Yz+zMT88ndqKiGT/tHowaH3TcPzCOCDEHHIqLCRq63Qm9fVkzzu\n\t/XqnkzBQs7wkVYO/8QeBl9WpT9HaUR7Gv0K9CM1eAh/DHxKqNmEdfuVgTyErcGtEvXKlTw/MlBY\n\ti3U31zvj3fTeSKmydITU2foomLz7y6xalOil/zSMzhkef5ceUfuxOVunnr0QnfvWsP5vuu029Qh\n\twx9h+aoqPX", "X-Gm-Gg": "AZuq6aJxrULy6pV9U+GOQvL6+OUi+pxG9t1Ierg3qrUsy/zHBg+QWnFuAlW9PFhbrSH\n\tMwpvIHONFH4buRLri7t9aWVR651tnUvae3KKN09fwQ1kDQl2ttKzuvTGqxTtgGMDVRnGyBm9pxk\n\tWOnP4FCZsKUBJYbnbqk0FDjV4+vgBeEo/kMahyBFGlJp4+XNat/S7JSyk9ZCY1CqQ+AKV/vLbVD\n\tqtvfZMHatbgl4BaSVY/mas2aB+RAHKTf/fN6socNIhavYrDR8Hq7jEstQr6bTpIlnlDdy2wuXCk\n\tq81mvCPhSaYyXQH73cUIcvXtVSeSaOmeiCpAFS/EKXB72LoFCb9zkPZtwqcHFeYZX8hV4LkUIim\n\tT7cu14d8IFcxaelH7kzlXU8C4jROyaHiL4xwHkJZ6mmTduYba/OqsYDx5qCZ/oTwXL9vfdnHBqN\n\tbosReB1CMDdRLyrLuKC85f+bsDM6R/swUrWrMy", "X-Received": [ "by 2002:a05:620a:1909:b0:8c9:fb69:e708 with SMTP id\n\taf79cd13be357-8cb27fb6220mr430118885a.25.1770829240281; \n\tWed, 11 Feb 2026 09:00:40 -0800 (PST)", "by 2002:a05:620a:1909:b0:8c9:fb69:e708 with SMTP id\n\taf79cd13be357-8cb27fb6220mr430102385a.25.1770829239284; \n\tWed, 11 Feb 2026 09:00:39 -0800 (PST)" ], "From": "Hans de Goede <johannes.goede@oss.qualcomm.com>", "To": "libcamera-devel@lists.libcamera.org, Milan Zamazal <mzamazal@redhat.com>", "Cc": "Hans de Goede <johannes.goede@oss.qualcomm.com>", "Subject": "[PATCH 1/2] software_isp: benchmark: Add missing _ postfix to\n\tmeasure data member", "Date": "Wed, 11 Feb 2026 18:00:36 +0100", "Message-ID": "<20260211170037.131630-1-johannes.goede@oss.qualcomm.com>", "X-Mailer": "git-send-email 2.52.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMjExMDEzMSBTYWx0ZWRfX2O7877Znnzvu\n\tfDGnAJ6HAsSp6ct+2Se1U2EVxGcMyWS4iG5ZL/5IV4a9y9jj8duZvA9grxtZXouRgisuFbQeC/T\n\tpDppO7Y2YzMFK9d4PBUYmwOqGXqoWIu/P8L/Gq8w83/gs93dwXTSgZzR/pjaCp1noQl0yUHja1P\n\ttXflNT95szTfrE88SQusxV/NWnYLPDWs6HpUisYKwWW+T4PZLmLXj9E0cUTk2v0VkEy8AOwNNQ6\n\tgMu+QSZi4+frLhc4E8vHd6N77XaHPbQ6+t+YC+zGUM2CDyZe8/LatTo8qQwtU+P8pP/cTf67XWk\n\tHr2k1xAdeXnHtgeJPC5a2r1Q+3nogTTyhBAmm8QRuWwR4UO/3YrjKRG82hRz7LUiM9MbnMiCxSA\n\tlIDLS0mRf4bMXkyCS6bSUYzavUx3UkIIRjmP8gLL+Ndg6V5VYUN6edqO/95Bcs7oMezazaW0RLd\n\tDGaEI+6w/Wl5IH5184Q==", "X-Proofpoint-GUID": "nHsF-mP1ua-DjTRBrcLBFpsPRr5uu7uA", "X-Authority-Analysis": "v=2.4 cv=W7Q1lBWk c=1 sm=1 tr=0 ts=698cb5bb cx=c_pps\n\ta=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=HzLeVaNsDn8A:10\n\ta=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22\n\ta=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=2M7dtBtliclCZGfxGjwA:9\n\ta=NFOGd7dJGGMPyQGDc5-O:22", "X-Proofpoint-ORIG-GUID": "nHsF-mP1ua-DjTRBrcLBFpsPRr5uu7uA", "X-Proofpoint-Virus-Version": "vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1121, Hydra:6.1.51,\n\tFMLib:17.12.100.49\n\tdefinitions=2026-02-11_02,2026-02-11_04,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tphishscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015\n\tsuspectscore=0 adultscore=0 malwarescore=0 impostorscore=0\n\tpriorityscore=1501\n\tclassifier=typeunknown authscore=0 authtc= authcc= route=outbound\n\tadjust=0\n\treason=mlx scancount=1 engine=8.22.0-2601150000\n\tdefinitions=main-2602110131", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "All class data members should have a _ postifx, add the missing _ postfix\nto the Benchmark::measure_ data member.\n\nSigned-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>\n---\n include/libcamera/internal/software_isp/benchmark.h | 2 +-\n src/libcamera/software_isp/benchmark.cpp | 10 +++++-----\n 2 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/include/libcamera/internal/software_isp/benchmark.h b/include/libcamera/internal/software_isp/benchmark.h\nindex 0680d6cd..46bdb86d 100644\n--- a/include/libcamera/internal/software_isp/benchmark.h\n+++ b/include/libcamera/internal/software_isp/benchmark.h\n@@ -28,7 +28,7 @@ public:\n \n private:\n \ttimespec frameStartTime_;\n-\tbool measure;\n+\tbool measure_;\n \t/* Skip 30 frames for things to stabilize then measure 30 frames */\n \tunsigned int encounteredFrames_ = 0;\n \tint64_t frameProcessTime_ = 0;\ndiff --git a/src/libcamera/software_isp/benchmark.cpp b/src/libcamera/software_isp/benchmark.cpp\nindex 1a00ae56..4ffb6773 100644\n--- a/src/libcamera/software_isp/benchmark.cpp\n+++ b/src/libcamera/software_isp/benchmark.cpp\n@@ -54,11 +54,11 @@ static inline int64_t timeDiff(timespec &after, timespec &before)\n */\n void Benchmark::startFrame(void)\n {\n-\tmeasure = framesToMeasure_ > 0 &&\n-\t\t encounteredFrames_ < skipBeforeMeasure_ + framesToMeasure_ &&\n-\t\t ++encounteredFrames_ > skipBeforeMeasure_;\n+\tmeasure_ = framesToMeasure_ > 0 &&\n+\t\t encounteredFrames_ < skipBeforeMeasure_ + framesToMeasure_ &&\n+\t\t ++encounteredFrames_ > skipBeforeMeasure_;\n \n-\tif (measure) {\n+\tif (measure_) {\n \t\tframeStartTime_ = {};\n \t\tclock_gettime(CLOCK_MONOTONIC_RAW, &frameStartTime_);\n \t}\n@@ -75,7 +75,7 @@ void Benchmark::startFrame(void)\n */\n void Benchmark::finishFrame(void)\n {\n-\tif (measure) {\n+\tif (measure_) {\n \t\ttimespec frameEndTime = {};\n \t\tclock_gettime(CLOCK_MONOTONIC_RAW, &frameEndTime);\n \t\tframeProcessTime_ += timeDiff(frameEndTime, frameStartTime_);\n", "prefixes": [ "1/2" ] }