Patch Detail
Show a patch.
GET /api/patches/26094/?format=api
{ "id": 26094, "url": "https://patchwork.libcamera.org/api/patches/26094/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26094/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260204-kbingham-fixups-v2-3-c341cced1fad@ideasonboard.com>", "date": "2026-02-04T22:42:58", "name": "[v2,3/3] libcamera: software_isp: Fix LIBCAMERA_SOFTISP_MODE log print", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "060ba6516e8b0b45f245e42ca250eb810b259c75", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26094/mbox/", "series": [ { "id": 5772, "url": "https://patchwork.libcamera.org/api/series/5772/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5772", "date": "2026-02-04T22:42:55", "name": "ipa: awb: Fix and cleanup RKISP1 and Simple Awb", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5772/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26094/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26094/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E6429C32EA\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 4 Feb 2026 22:43:06 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1380B62052;\n\tWed, 4 Feb 2026 23:43:05 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B48C361FBF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 4 Feb 2026 23:43:00 +0100 (CET)", "from [192.168.0.240] (ams.linuxembedded.co.uk [209.38.108.23])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 603781337;\n\tWed, 4 Feb 2026 23:42:18 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VmFptq0Y\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770244938;\n\tbh=gUjwGqFZam4HOUtVthtCwpm8yQSR4F1eQiUIUaiuX8E=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=VmFptq0YsBlXd+eaguJW9Mrr/k8LOyKiVeg9nsxR95wH+w1svHS10/0dMeYiJdfWg\n\tvXg//eUBR+OY8KbjgBjnemLgG5jjm6wvxSL+HYRY/+hrcgLAXQ/PTK5BvVNuLOiaSI\n\tD/iqC2xLRW1ZnZ85TMipySvkERqQ4q/hzLghBoN8=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Date": "Wed, 04 Feb 2026 22:42:58 +0000", "Subject": "[PATCH v2 3/3] libcamera: software_isp: Fix LIBCAMERA_SOFTISP_MODE\n\tlog print", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260204-kbingham-fixups-v2-3-c341cced1fad@ideasonboard.com>", "References": "<20260204-kbingham-fixups-v2-0-c341cced1fad@ideasonboard.com>", "In-Reply-To": "<20260204-kbingham-fixups-v2-0-c341cced1fad@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=ed25519-sha256; t=1770244979; l=1244;\n\ti=kieran.bingham@ideasonboard.com; s=20260204;\n\th=from:subject:message-id; \n\tbh=gUjwGqFZam4HOUtVthtCwpm8yQSR4F1eQiUIUaiuX8E=;\n\tb=Mp/Pld+1Qjvx1/6JZweQ5ibufFECleq7XSuSGcUCZVXF697G15gvdzUsFDCgNQKVB9mLzCBNV\n\tnEIwTbu2BtlB6ti04ECcMcgxWE2NxRgSCiEOMTZdUIJxn+TjrUW3UqP", "X-Developer-Key": "i=kieran.bingham@ideasonboard.com; a=ed25519;\n\tpk=IOxS2C6nWHNjLfkDR71Iesk904i6wJDfEERqV7hDBdY=", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When an invalid parameter is specified to LIBCAMERA_SOFTISP_MODE, the\nerror log has a typo. Fix the typo and reflow the line while here.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/software_isp/software_isp.cpp | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex a83986b787b75ac1cd9073b32f2b937e9efb6cf0..3eb9cf97dea66cb68f2277a8274003e28418d830 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -108,8 +108,10 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \tstd::optional<std::string> softISPMode = configuration.envOption(\"LIBCAMERA_SOFTISP_MODE\", { \"software_isp\", \"mode\" });\n \tif (softISPMode) {\n \t\tif (softISPMode != \"gpu\" && softISPMode != \"cpu\") {\n-\t\t\tLOG(SoftwareIsp, Error) << \"LIBCAMERA_SOFISP_MODE \" << softISPMode.value() << \" invalid \"\n-\t\t\t\t\t\t<< \"must be \\\"cpu\\\" or \\\"gpu\\\"\";\n+\t\t\tLOG(SoftwareIsp, Error)\n+\t\t\t\t<< \"LIBCAMERA_SOFTISP_MODE \"\n+\t\t\t\t<< softISPMode.value() << \" invalid \"\n+\t\t\t\t<< \"must be \\\"cpu\\\" or \\\"gpu\\\"\";\n \t\t\treturn;\n \t\t}\n \t}\n", "prefixes": [ "v2", "3/3" ] }