Patch Detail
Show a patch.
GET /api/patches/26093/?format=api
{ "id": 26093, "url": "https://patchwork.libcamera.org/api/patches/26093/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26093/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260204-kbingham-fixups-v2-2-c341cced1fad@ideasonboard.com>", "date": "2026-02-04T22:42:57", "name": "[v2,2/3] ipa: simple: Remove duplicate header inclusion", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f93b6c44897bb6b278b8a1243b317c9621df13e4", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26093/mbox/", "series": [ { "id": 5772, "url": "https://patchwork.libcamera.org/api/series/5772/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5772", "date": "2026-02-04T22:42:55", "name": "ipa: awb: Fix and cleanup RKISP1 and Simple Awb", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5772/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26093/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26093/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DDAEDC32E7\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 4 Feb 2026 22:43:05 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5CD2E62043;\n\tWed, 4 Feb 2026 23:43:04 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F03462041\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 4 Feb 2026 23:43:00 +0100 (CET)", "from [192.168.0.240] (ams.linuxembedded.co.uk [209.38.108.23])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0E354120E;\n\tWed, 4 Feb 2026 23:42:18 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"U3IG4wB5\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770244938;\n\tbh=4X0JVf1PaWuLk71UnsDWjpDVqLteWS+Rpxp35C3rSeA=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=U3IG4wB5HGzAkXozab/iu1zwA2vcwfTdkcucer+2KiDLUlC0Ozj9XbPOPyoXA5//R\n\tp5ZIvG4m59t8Bp3QjqIYhE8iZH9LZsRlyKH9FFd1AWAYK6RsyDdzRftEEGrl/UC4Ya\n\tVsr5qHaM1MZMy6+no5JCO8DH+4WfRz7lLIzhcL1k=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Date": "Wed, 04 Feb 2026 22:42:57 +0000", "Subject": "[PATCH v2 2/3] ipa: simple: Remove duplicate header inclusion", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260204-kbingham-fixups-v2-2-c341cced1fad@ideasonboard.com>", "References": "<20260204-kbingham-fixups-v2-0-c341cced1fad@ideasonboard.com>", "In-Reply-To": "<20260204-kbingham-fixups-v2-0-c341cced1fad@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>, =?utf-8?q?Barnab?=\n\t=?utf-8?b?w6FzIFDFkWN6ZQ==?= <barnabas.pocze@ideasonboard.com>,\n\tMilan Zamazal <mzamazal@redhat.com>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=ed25519-sha256; t=1770244979; l=845;\n\ti=kieran.bingham@ideasonboard.com; s=20260204;\n\th=from:subject:message-id; \n\tbh=4X0JVf1PaWuLk71UnsDWjpDVqLteWS+Rpxp35C3rSeA=;\n\tb=s0F8yzElO0ioVK7Ph+/AA8NXVWmM5KICd4NxHCKC23cRP8V0b/axNDamkNmrY1eglvjg0Ilg1\n\tt8FdM2Oh8CHCdMmJ66/bjaBnD3JkhKx+DCqWVCq8pRVWDD/DmxPduz2", "X-Developer-Key": "i=kieran.bingham@ideasonboard.com; a=ed25519;\n\tpk=IOxS2C6nWHNjLfkDR71Iesk904i6wJDfEERqV7hDBdY=", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The Awb component already references libcamera/control_ids.h. Remove\nthe incorrect duplicate inclusion of \"control_ids.h\".\n\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/simple/algorithms/awb.cpp | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\nindex 6fdaacaba3183bc2efa348c4182b90201006b826..6369193c686c0c69de88cb60756a00557dbdbbd9 100644\n--- a/src/ipa/simple/algorithms/awb.cpp\n+++ b/src/ipa/simple/algorithms/awb.cpp\n@@ -17,8 +17,6 @@\n #include \"libipa/colours.h\"\n #include \"simple/ipa_context.h\"\n \n-#include \"control_ids.h\"\n-\n namespace libcamera {\n \n LOG_DEFINE_CATEGORY(IPASoftAwb)\n", "prefixes": [ "v2", "2/3" ] }