Patch Detail
Show a patch.
GET /api/patches/26041/?format=api
{ "id": 26041, "url": "https://patchwork.libcamera.org/api/patches/26041/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26041/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260129164032.1380169-2-barnabas.pocze@ideasonboard.com>", "date": "2026-01-29T16:40:27", "name": "[v1,2/7] meson: Add `egl.cpp` to sources alongside `debayer_egl.cpp`", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "5f8d631f450150954040fbeba52e607974313999", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26041/mbox/", "series": [ { "id": 5757, "url": "https://patchwork.libcamera.org/api/series/5757/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5757", "date": "2026-01-29T16:40:27", "name": "[v1,1/7] meson: Drop unnecessary egl, gles feature defines", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5757/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26041/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26041/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EB4E3C3226\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 29 Jan 2026 16:40:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C010961FD5;\n\tThu, 29 Jan 2026 17:40:37 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BD50A615B2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 29 Jan 2026 17:40:35 +0100 (CET)", "from pb-laptop.local (185.221.142.123.nat.pool.zt.hu\n\t[185.221.142.123])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F14B41934\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 29 Jan 2026 17:39:57 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vGaa53IV\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769704798;\n\tbh=JPDh0aNwLwm4rXaWQnhlsuV7vh7J3mZY8tpyjxA4k14=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=vGaa53IV3l0bEhTNyuZqm7jVA5qCb+sI0DfUnGND1/XENC02DtLsGqCR8dH+caHD6\n\tkWlfRW87wIIpE7bPhfjuJeg4z6dVTPrXiQF0w3g4fxLk1mj50E3RlSdt0VcITGo1e5\n\tIP5zeFKzGqCXNkUqGYmARjH4PGUIj56cKqIbb6fI=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v1 2/7] meson: Add `egl.cpp` to sources alongside\n\t`debayer_egl.cpp`", "Date": "Thu, 29 Jan 2026 17:40:27 +0100", "Message-ID": "<20260129164032.1380169-2-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260129164032.1380169-1-barnabas.pocze@ideasonboard.com>", "References": "<20260129164032.1380169-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "There are no other users of `egl.cpp`, so simplify by adding\nit the sources array at the same time.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/meson.build | 3 ---\n src/libcamera/software_isp/meson.build | 1 +\n 2 files changed, 1 insertion(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex c6c109a30..28ce93de6 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -75,9 +75,6 @@ libegl = dependency('egl', required : false)\n libglesv2 = dependency('glesv2', required : false)\n \n if mesa_works\n- libcamera_internal_sources += files([\n- 'egl.cpp',\n- ])\n gles_headless_enabled = true\n else\n gles_headless_enabled = false\ndiff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build\nindex c61ac7d59..a55b76b58 100644\n--- a/src/libcamera/software_isp/meson.build\n+++ b/src/libcamera/software_isp/meson.build\n@@ -19,6 +19,7 @@ libcamera_internal_sources += files([\n if softisp_enabled and gles_headless_enabled\n config_h.set('HAVE_DEBAYER_EGL', 1)\n libcamera_internal_sources += files([\n+ '../egl.cpp',\n 'debayer_egl.cpp',\n ])\n endif\n", "prefixes": [ "v1", "2/7" ] }