Patch Detail
Show a patch.
GET /api/patches/26019/?format=api
{ "id": 26019, "url": "https://patchwork.libcamera.org/api/patches/26019/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26019/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260128-sklug-lsc-resampling-v2-dev-v6-8-af7d95f03d22@ideasonboard.com>", "date": "2026-01-28T16:00:25", "name": "[v6,08/15] ipa: rkisp1: lsc: Move local types into anonymous namespace", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7d6e72bccedf650d034bc0e5451f718db59296dc", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26019/mbox/", "series": [ { "id": 5751, "url": "https://patchwork.libcamera.org/api/series/5751/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5751", "date": "2026-01-28T16:00:17", "name": "Add resampling support for polynomial LSC data", "version": 6, "mbox": "https://patchwork.libcamera.org/series/5751/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26019/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26019/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8E3E3C3200\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 28 Jan 2026 16:00:49 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4D09861FDF;\n\tWed, 28 Jan 2026 17:00:49 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9992261FDB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 28 Jan 2026 17:00:47 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:1a60:e70f:ec38:13a9])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 8B5BC1FBC; \n\tWed, 28 Jan 2026 17:00:10 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IsKu/4Mv\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769616010;\n\tbh=KNKOEEbYPoPX975ACEBQGf9aQl/6x8eHXZAj1uY313s=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=IsKu/4Mv+j6/lNt+GFBTTmnykF4sQWjDiY4TXxOZTP/+Dr2l43rOdcydCPIS+jKPj\n\tw46s/hRkhwRit/GJU2Ee02uS807Mvhmgrbj9M4jC0CvCV872xH0OZNJGpnfxnQ6CYi\n\tlhRRIRAhHDfnNX2AaI9LJrHXOYaihk312oFvaK/A=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "Date": "Wed, 28 Jan 2026 17:00:25 +0100", "Subject": "[PATCH v6 08/15] ipa: rkisp1: lsc: Move local types into anonymous\n\tnamespace", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260128-sklug-lsc-resampling-v2-dev-v6-8-af7d95f03d22@ideasonboard.com>", "References": "<20260128-sklug-lsc-resampling-v2-dev-v6-0-af7d95f03d22@ideasonboard.com>", "In-Reply-To": "<20260128-sklug-lsc-resampling-v2-dev-v6-0-af7d95f03d22@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t<barnabas.pocze@ideasonboard.com>", "X-Mailer": "b4 0.14.2", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Move all local helpers into an anonymous namespace and drop a static\nmodifier that is no longer needed.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n\n---\n\nChanges in v3:\n- Collected tags\n\nChanges in v2:\n- Added this patch\n---\n src/ipa/rkisp1/algorithms/lsc.cpp | 12 ++++++++----\n 1 file changed, 8 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\nindex a5c15ea3b293c64f458dc9d4b4b06232db8673cc..99e1e05f1d8b8157c2bbb8ee2f94cedb152009ca 100644\n--- a/src/ipa/rkisp1/algorithms/lsc.cpp\n+++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n@@ -27,8 +27,6 @@ namespace libcamera {\n \n namespace ipa {\n \n-constexpr int kColourTemperatureChangeThreshhold = 10;\n-\n template<typename T>\n void interpolateVector(const std::vector<T> &a, const std::vector<T> &b,\n \t\t std::vector<T> &dest, double lambda)\n@@ -70,6 +68,10 @@ namespace ipa::rkisp1::algorithms {\n \n LOG_DEFINE_CATEGORY(RkISP1Lsc)\n \n+namespace {\n+\n+constexpr int kColourTemperatureChangeThreshhold = 10;\n+\n class LscPolynomialLoader\n {\n public:\n@@ -276,8 +278,8 @@ std::vector<uint16_t> LscTableLoader::parseTable(const YamlObject &tuningData,\n \treturn table;\n }\n \n-static std::vector<double> parseSizes(const YamlObject &tuningData,\n-\t\t\t\t const char *prop)\n+std::vector<double> parseSizes(const YamlObject &tuningData,\n+\t\t\t const char *prop)\n {\n \tstd::vector<double> sizes =\n \t\ttuningData[prop].getList<double>().value_or(std::vector<double>{});\n@@ -306,6 +308,8 @@ static std::vector<double> parseSizes(const YamlObject &tuningData,\n \treturn sizes;\n }\n \n+} /* namespace */\n+\n LensShadingCorrection::LensShadingCorrection()\n \t: lastAppliedCt_(0), lastAppliedQuantizedCt_(0)\n {\n", "prefixes": [ "v6", "08/15" ] }