Patch Detail
Show a patch.
GET /api/patches/25998/?format=api
{ "id": 25998, "url": "https://patchwork.libcamera.org/api/patches/25998/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25998/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260128114402.31570-6-mzamazal@redhat.com>", "date": "2026-01-28T11:43:52", "name": "[v5,05/15] libcamera: ipa: simple: Introduce a general correction matrix", "commit_ref": "5f3cdafe0feea1a4f222ae9595b8ccac9c10e1a8", "pull_url": null, "state": "accepted", "archived": false, "hash": "36e805edc78ebf0b3cd5044ece26393093e13588", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25998/mbox/", "series": [ { "id": 5748, "url": "https://patchwork.libcamera.org/api/series/5748/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5748", "date": "2026-01-28T11:43:47", "name": "Simple pipeline IPA cleanup", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5748/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25998/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25998/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C669BC3200\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 28 Jan 2026 11:44:30 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7B85561FD2;\n\tWed, 28 Jan 2026 12:44:30 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5E30461FCC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 28 Jan 2026 12:44:26 +0100 (CET)", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-159-ieMpqr8RP8WpA-lujRZO_A-1;\n\tWed, 28 Jan 2026 06:44:21 -0500", "from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id D2BF618002C4; Wed, 28 Jan 2026 11:44:20 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.34.236])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 1765A19560B2; Wed, 28 Jan 2026 11:44:18 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"OkPVBlz3\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1769600665;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=yHt8hEx7L7x6m8Giz/E0YsIRoOVuMDJUld2I1itRJUs=;\n\tb=OkPVBlz3jhqS4sQXE7tnTOp4J04RpAZ03+pYmaeASSwMa8eaIhZKotsruNwhWSMVXYUkAj\n\tCn4T955Srj6Zkg3Gab+URmz+gKdBahVE6eMUvlLLSoqj0ZrycTPImSuZTC0VFGqDNRUd4f\n\tvyhm5T95vOl18vmOiy4vLf4v0ARPiaw=", "X-MC-Unique": "ieMpqr8RP8WpA-lujRZO_A-1", "X-Mimecast-MFC-AGG-ID": "ieMpqr8RP8WpA-lujRZO_A_1769600660", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t<barnabas.pocze@ideasonboard.com>", "Subject": "[PATCH v5 05/15] libcamera: ipa: simple: Introduce a general\n\tcorrection matrix", "Date": "Wed, 28 Jan 2026 12:43:52 +0100", "Message-ID": "<20260128114402.31570-6-mzamazal@redhat.com>", "In-Reply-To": "<20260128114402.31570-1-mzamazal@redhat.com>", "References": "<20260128114402.31570-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.12", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "_3HIPnHCh1N5YE_2KtaUUMKnulFmGX78FwHsdRvHM4o_1769600660", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Let's introduce IPAActiveState::combinedMatrix that is separate from\nIPAActiveState::ccm and represents the overall correction matrix, not\nonly the sensor colour correction matrix.\n\nIPAActiveState::ccm still includes everything; this is changed in the\nfollowup patch.\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/ipa/simple/algorithms/ccm.cpp | 1 +\n src/ipa/simple/algorithms/lut.cpp | 2 +-\n src/ipa/simple/ipa_context.h | 1 +\n 3 files changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/simple/algorithms/ccm.cpp b/src/ipa/simple/algorithms/ccm.cpp\nindex e05e5bc28..a3e8cd6c4 100644\n--- a/src/ipa/simple/algorithms/ccm.cpp\n+++ b/src/ipa/simple/algorithms/ccm.cpp\n@@ -104,6 +104,7 @@ void Ccm::prepare(IPAContext &context, const uint32_t frame,\n \tif (saturation)\n \t\tapplySaturation(ccm, saturation.value());\n \n+\tcontext.activeState.combinedMatrix = ccm;\n \tcontext.activeState.ccm = ccm;\n \tframeContext.saturation = saturation;\n \tcontext.activeState.matrixChanged = true;\ndiff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp\nindex 5c4683fd8..141ea17fa 100644\n--- a/src/ipa/simple/algorithms/lut.cpp\n+++ b/src/ipa/simple/algorithms/lut.cpp\n@@ -131,7 +131,7 @@ void Lut::prepare(IPAContext &context,\n \t\tMatrix<float, 3, 3> gainMatrix = { { gains.r(), 0, 0,\n \t\t\t\t\t\t 0, gains.g(), 0,\n \t\t\t\t\t\t 0, 0, gains.b() } };\n-\t\tauto matrix = context.activeState.ccm * gainMatrix;\n+\t\tauto matrix = context.activeState.combinedMatrix * gainMatrix;\n \t\tauto &red = params->redCcm;\n \t\tauto &green = params->greenCcm;\n \t\tauto &blue = params->blueCcm;\ndiff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\nindex ea1852cd4..58dcad290 100644\n--- a/src/ipa/simple/ipa_context.h\n+++ b/src/ipa/simple/ipa_context.h\n@@ -63,6 +63,7 @@ struct IPAActiveState {\n \t} gamma;\n \n \tMatrix<float, 3, 3> ccm;\n+\tMatrix<float, 3, 3> combinedMatrix;\n \tbool matrixChanged = false;\n \n \tstruct {\n", "prefixes": [ "v5", "05/15" ] }