Patch Detail
Show a patch.
GET /api/patches/25989/?format=api
{ "id": 25989, "url": "https://patchwork.libcamera.org/api/patches/25989/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25989/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260128074956.760538-6-paul.elder@ideasonboard.com>", "date": "2026-01-28T07:49:53", "name": "[v5,5/8] libcamera: camera_manager: Add LayerManager", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8ea6201c0ff14b1dbd0b9d3ee5f7db0fdd0b373d", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25989/mbox/", "series": [ { "id": 5747, "url": "https://patchwork.libcamera.org/api/series/5747/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5747", "date": "2026-01-28T07:49:48", "name": "Add Layers support", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5747/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25989/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25989/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EEE9BC3200\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 28 Jan 2026 07:50:23 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 861B861FE2;\n\tWed, 28 Jan 2026 08:50:23 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4FF3B61FC4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 28 Jan 2026 08:50:18 +0100 (CET)", "from neptunite.hamster-moth.ts.net (unknown\n\t[IPv6:2404:7a81:160:2100:508d:7983:72a6:2eeb])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5398D14B0;\n\tWed, 28 Jan 2026 08:49:40 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"W5w4HHin\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769586581;\n\tbh=/y/zUD9/P7gYnkbi/xAQBW9u8ZTvVtydC0+nnXaRsnY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=W5w4HHinNTPW6CxQEcnc5jNMbZ0/UaZenNzI3lL0xd0OrX64Y7xGQN56jfJni5m4D\n\t16fxVzMHgSotJ4fmB55tXf5AoH8Q7h96oqcJuWTwfU8mS/H+2RjRuKjmQGkeTYICiV\n\tk4NgsjMMJe+jGw7xVPC0BYrwVTt96qUSa4VAmB84=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Paul Elder <paul.elder@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v5 5/8] libcamera: camera_manager: Add LayerManager", "Date": "Wed, 28 Jan 2026 16:49:53 +0900", "Message-ID": "<20260128074956.760538-6-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.47.2", "In-Reply-To": "<20260128074956.760538-1-paul.elder@ideasonboard.com>", "References": "<20260128074956.760538-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add to the CameraManager a LayerManager member. This allows us to have\none LayerManager that handles loading all the layer shared objects, and\nthen each Camera can access the layer via the LayerManager via through\nthe CameraManager.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n---\nChanges in v4:\n- Put LayerManager directly in CameraManager, as opposed to a unique\n pointer\n\nNo change in v3\n\nNew in v2\n---\n include/libcamera/internal/camera_manager.h | 3 +++\n src/libcamera/camera_manager.cpp | 1 +\n 2 files changed, 4 insertions(+)", "diff": "diff --git a/include/libcamera/internal/camera_manager.h b/include/libcamera/internal/camera_manager.h\nindex 755928ce60a5..cc3ede02507f 100644\n--- a/include/libcamera/internal/camera_manager.h\n+++ b/include/libcamera/internal/camera_manager.h\n@@ -19,6 +19,7 @@\n #include <libcamera/base/thread_annotations.h>\n \n #include \"libcamera/internal/global_configuration.h\"\n+#include \"libcamera/internal/layer_manager.h\"\n #include \"libcamera/internal/process.h\"\n \n namespace libcamera {\n@@ -45,6 +46,7 @@ public:\n \t}\n \n \tIPAManager *ipaManager() const { return ipaManager_.get(); }\n+\tconst LayerManager *layerManager() const { return &layerManager_; }\n \n protected:\n \tvoid run() override;\n@@ -71,6 +73,7 @@ private:\n \tstd::unique_ptr<DeviceEnumerator> enumerator_;\n \n \tstd::unique_ptr<IPAManager> ipaManager_;\n+\tLayerManager layerManager_;\n \n \tconst GlobalConfiguration configuration_;\n };\ndiff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex 23185467ba02..554cd935339a 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -16,6 +16,7 @@\n #include \"libcamera/internal/camera.h\"\n #include \"libcamera/internal/device_enumerator.h\"\n #include \"libcamera/internal/global_configuration.h\"\n+#include \"libcamera/internal/layer_manager.h\"\n #include \"libcamera/internal/ipa_manager.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n \n", "prefixes": [ "v5", "5/8" ] }