Patch Detail
Show a patch.
GET /api/patches/25962/?format=api
{ "id": 25962, "url": "https://patchwork.libcamera.org/api/patches/25962/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25962/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260126104256.119697-5-rick.w.ten.wolde@gmail.com>", "date": "2026-01-26T10:42:52", "name": "[4/7] libcamera: shaders: Add LSC support", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "8488cf04fe8d97ee090b49f291cbc7e00a7048c5", "submitter": { "id": 257, "url": "https://patchwork.libcamera.org/api/people/257/?format=api", "name": "Rick ten Wolde", "email": "rick.w.ten.wolde@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25962/mbox/", "series": [ { "id": 5739, "url": "https://patchwork.libcamera.org/api/series/5739/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5739", "date": "2026-01-26T10:42:48", "name": "LSC for SoftISP simple pipeline", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5739/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25962/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25962/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7F43CC3200\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 26 Jan 2026 10:48:16 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8A76261FD5;\n\tMon, 26 Jan 2026 11:48:13 +0100 (CET)", "from mail-ed1-x533.google.com (mail-ed1-x533.google.com\n\t[IPv6:2a00:1450:4864:20::533])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 51F0D61FC6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 26 Jan 2026 11:43:06 +0100 (CET)", "by mail-ed1-x533.google.com with SMTP id\n\t4fb4d7f45d1cf-65814266b08so8138674a12.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 26 Jan 2026 02:43:06 -0800 (PST)", "from castortop.wolde.loc (195-240-110-192.fixed.kpn.net.\n\t[195.240.110.192]) by smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-b885b7661f7sm599220366b.54.2026.01.26.02.43.04\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 26 Jan 2026 02:43:04 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"KzgEoY+9\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20230601; t=1769424185; x=1770028985;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=hUrNU95/FgP7yuTKuaSCsMb4lMgbTn8lfvIZcnyIu30=;\n\tb=KzgEoY+9ef7aNT0BwoVpPFFVA8Yfsxnu9PS4h9L/aOY/v/zkwBlYMjpZHgzRgUthss\n\t2NCmznejTJdncjDG4o1xIvYDesSzSCvB7/aDRrW00y6SNds+TrN6H5FK5CMrwokQXGui\n\tD4kYCKyKVAjzWwguKU41Cja/DlqVT3FjrbtfpWDJU2sXMnoqmO3rLBC1xXto4qX9qxp/\n\ttBmYrobzdds9nVJ4cgiqyOL/IB2DOBEaWlkf19Te9N6sP+51X0iZoKfn7zcyJaNyfRsZ\n\ttPRgodMhOwShaZLGhHMCrRlySmz64Nv73CMlWiNq2uq98YG8EM9j3fB5jFYLD9sXbwh3\n\t/kvw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1769424185; x=1770028985;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=hUrNU95/FgP7yuTKuaSCsMb4lMgbTn8lfvIZcnyIu30=;\n\tb=G0hhfswG9KZnC0IR12CBE8ee/gYRwjBTqzQ1qNJY+HXPmf0NswWLw17Mo7CjtEHx9b\n\tXO2D8d3q1rdAQmJ8F5118csAnP2tVhTEDEztZn0VojLNNx15crC9QU9kpfaAgyobOHWX\n\tbY0fa/e+fzgOJsfuS/t8Wwu5EAMaiY0QDav6zQhvQmur8xh1IjCQHiXJdwWxMIsKBQt5\n\tHbWTOMmRddcpmpvNaZqY+shyBrormlT28wSqISRCUlsPuDBh6wrGZ1Pa6N1UvQSKFgt0\n\tKSPMnU63udNJgGReQGBfkGhzzJaH6t/+r5TkXcFQzzBO2QZH7zJdOv1Kncgtp+sgreJo\n\tEtZA==", "X-Gm-Message-State": "AOJu0Yxqo7l4XP7zPEpnUoihMFrdFmia1mM1b3y5vW2wBkwoJaraH08n\n\tMA/OLJh6Pmei/RH+f6GbW7eqSp6C3mZ3SIDg4DsF3Lco6LrOYK3K+dOT4R9UdQ==", "X-Gm-Gg": "AZuq6aKI1qQD94khhbrBgI13LEW2PcgCTbHcGyq4Hl/e8nRTldfKWZIqrgO1xeuAIfA\n\tULGFzaIIwQFDdcHktXLpMP0Ld26UFMypdXKesYkRoZwmTw68XUyhHw9r/ZUiSF0aXqmzZ6ol6to\n\t0LZ3z7RZg+81fVD7q21+INn4XGtfXi/9TPAzrT8hN3tITqD3quz9PfCaF5LhJ7UwWcbl7Tod9W6\n\tYtl+WpTKEyN6aj0Yyk53ss9gkHTBYqPovX5hiEmysxQ8KIQkESB4W/eM5JH01ilUIS89NWfm4ML\n\tmmEkDleKTKiPyLVhevpM5mS5Xc4MZpGxhqp5OUv38e4rJbu0/cBrJfObaIDbbVZlnvwdgJk8ZAB\n\tgoZQ96NYz/fq3x0PURH0DB61U8m7Qhcl8psnDM3U03tnOv0S2ds+bKUz5pkDvcNoviNcwuC8gWu\n\tu8feQFgphsat9HA8KZT3mjk/2q7+tPqujpXNPdjwe45WlQdpF6+yaX1xBY7N4E3nwEfVI8zYtXI\n\tQ==", "X-Received": "by 2002:a17:907:3da5:b0:b75:7b39:88bc with SMTP id\n\ta640c23a62f3a-b8d2e833e71mr300233166b.58.1769424185235; \n\tMon, 26 Jan 2026 02:43:05 -0800 (PST)", "From": "Rick ten Wolde <rick.w.ten.wolde@gmail.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "xander.c.pronk@gmail.com, derekgielen@outlook.com,\n\t22012540@student.hhs.nl, \n\trick.w.ten.wolde@gmail.com, johannes.goede@oss.qualcomm.com,\n\tRick ten Wolde <rick_libcamera@wolde.info>", "Subject": "[PATCH 4/7] libcamera: shaders: Add LSC support", "Date": "Mon, 26 Jan 2026 11:42:52 +0100", "Message-ID": "<20260126104256.119697-5-rick.w.ten.wolde@gmail.com>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20260126104256.119697-1-rick.w.ten.wolde@gmail.com>", "References": "<20260126104256.119697-1-rick.w.ten.wolde@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Mon, 26 Jan 2026 11:48:05 +0100", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Xander Pronk <xander.c.pronk@gmail.com>\n\nApply LSC after black-level and before CCM operations.\n\nCo-authored-by: Rick ten Wolde <rick_libcamera@wolde.info>\nSigned-off-by: Rick ten Wolde <rick_libcamera@wolde.info>\nSigned-off-by: Xander Pronk <xander.c.pronk@gmail.com>\n---\n src/libcamera/shaders/bayer_1x_packed.frag | 10 ++++++++++\n src/libcamera/shaders/bayer_unpacked.frag | 10 ++++++++++\n 2 files changed, 20 insertions(+)", "diff": "diff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag\nindex 23747f78..7993ea1d 100644\n--- a/src/libcamera/shaders/bayer_1x_packed.frag\n+++ b/src/libcamera/shaders/bayer_1x_packed.frag\n@@ -70,6 +70,10 @@ uniform vec3 blacklevel;\n uniform float gamma;\n uniform float contrastExp;\n \n+uniform sampler2D lsc_tex_red;\n+uniform sampler2D lsc_tex_blue;\n+uniform sampler2D lsc_tex_green;\n+\n float apply_contrast(float value)\n {\n \t// Apply simple S-curve\n@@ -227,6 +231,12 @@ void main(void)\n \n \trgb = rgb - blacklevel;\n \n+\t#if defined(DO_LSC)\n+\trgb.r = rgb.r + rgb.r * 3.0 * texture2D(lsc_tex_red, textureOut).x;\n+\trgb.g = rgb.g + rgb.g * 3.0 * texture2D(lsc_tex_green, textureOut).x;\n+\trgb.b = rgb.b + rgb.b * 3.0 * texture2D(lsc_tex_blue, textureOut).x;\n+\t#endif\n+\n \t/*\n \t * CCM is a 3x3 in the format\n \t *\ndiff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag\nindex 1b85196a..f0b9a6cc 100644\n--- a/src/libcamera/shaders/bayer_unpacked.frag\n+++ b/src/libcamera/shaders/bayer_unpacked.frag\n@@ -29,6 +29,10 @@ uniform vec3 blacklevel;\n uniform float gamma;\n uniform float contrastExp;\n \n+uniform sampler2D lsc_tex_red;\n+uniform sampler2D lsc_tex_blue;\n+uniform sampler2D lsc_tex_green;\n+\n float apply_contrast(float value)\n {\n // Apply simple S-curve\n@@ -130,6 +134,12 @@ void main(void) {\n \n rgb = rgb - blacklevel;\n \n+ #if defined(DO_LSC)\n+ rgb.r = rgb.r + rgb.r * 3.0 * texture2D(lsc_tex_red, center.xy).x;\n+ rgb.g = rgb.g + rgb.g * 3.0 * texture2D(lsc_tex_green, center.xy).x;\n+ rgb.b = rgb.b + rgb.b * 3.0 * texture2D(lsc_tex_blue, center.xy).x;\n+ #endif\n+\n /*\n * CCM is a 3x3 in the format\n *\n", "prefixes": [ "4/7" ] }