Patch Detail
Show a patch.
GET /api/patches/25951/?format=api
{ "id": 25951, "url": "https://patchwork.libcamera.org/api/patches/25951/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25951/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260122234709.2061370-6-rui.wang@ideasonboard.com>", "date": "2026-01-22T23:47:07", "name": "[v11,5/7] ipa: rkisp1: algorithms: dpf: Add detailed config logging", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "28b214117c71e1f2b854eab4f5a1a142c699b2de", "submitter": { "id": 241, "url": "https://patchwork.libcamera.org/api/people/241/?format=api", "name": "Rui Wang", "email": "rui.wang@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25951/mbox/", "series": [ { "id": 5736, "url": "https://patchwork.libcamera.org/api/series/5736/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5736", "date": "2026-01-22T23:47:02", "name": "refactor DPF parsing and initialization", "version": 11, "mbox": "https://patchwork.libcamera.org/series/5736/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25951/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25951/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9C82FBDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 22 Jan 2026 23:47:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3D95F61FE2;\n\tFri, 23 Jan 2026 00:47:35 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CEA5C61FD9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 23 Jan 2026 00:47:30 +0100 (CET)", "from rui-Precision-7560.local (unknown [209.216.103.65])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 80C0E14C7;\n\tFri, 23 Jan 2026 00:46:57 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"C2sYS4kZ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769125618;\n\tbh=FEeLIEjCboP9TTPCKxwjr7JI0zpumT0bFWRn3yenx3M=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=C2sYS4kZlbM+lHrrd/jsizKxRfjugbSqmNMdM+f8cXa8/nVwosqNfUWzpwPXVMHmi\n\tFvYfQnOsySK7tuSOvqTj6eTr6tC256qaZLN1W88CRA08GEAuNlNHSWYRzh7ghs+T9c\n\tU9E1z8nUFWTwpUP+1NuyezCMufwNN2HM7aleoXWs=", "From": "Rui Wang <rui.wang@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Rui Wang <rui.wang@ideasonboard.com>,\n\tJacopo Mondi <jacopo.mondi@ideasonboard.com>", "Subject": "[PATCH v11 5/7] ipa: rkisp1: algorithms: dpf: Add detailed config\n\tlogging", "Date": "Thu, 22 Jan 2026 18:47:07 -0500", "Message-ID": "<20260122234709.2061370-6-rui.wang@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260122234709.2061370-1-rui.wang@ideasonboard.com>", "References": "<20260122234709.2061370-1-rui.wang@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add logConfig() helper function to log DPF configuration\nupdates when they occur. This provides visibility into the active\nDPF parameters including:\n\n- Control mode and denoise enable state\n- Filter sizes (9x9 vs 13x9 for rb)\n- NLL scale mode (linear vs logarithmic)\n- Gain mode\n- Strength values (r, g, b)\n- Spatial filter coefficients (g and rb arrays)\n- Noise level lookup table coefficients\n\nThe logging is triggered in prepareEnabledMode() whenever the\nconfiguration is updated, helping with debugging and tuning.\n\nSigned-off-by: Rui Wang <rui.wang@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n\n---\nchangelog since v5:\n - remove curly bracket in single state if-else\n\n Reviewed-by tags from v5 are carried over (no function changes).\n\nchangelog since v6: No change\nchangelog since v8:\n - add logConfi argument : rkisp1_cif_isp_dpf_config rkisp1_cif_isp_dpf_strength_config\n---\n src/ipa/rkisp1/algorithms/dpf.cpp | 53 +++++++++++++++++++++++++++++--\n src/ipa/rkisp1/algorithms/dpf.h | 6 +++-\n 2 files changed, 55 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\nindex 977998b3..d19173fe 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.cpp\n+++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n@@ -282,6 +282,49 @@ bool Dpf::loadConfig(int32_t mode)\n \treturn true;\n }\n \n+void Dpf::logConfig(const IPAFrameContext &frameContext,\n+\t\t const struct rkisp1_cif_isp_dpf_config &config,\n+\t\t const struct rkisp1_cif_isp_dpf_strength_config &strengthConfig) const\n+{\n+\tstd::ostringstream ss;\n+\n+\tss << \"DPF config update: \";\n+\tss << \" control mode=\" << activeMode_->modeValue;\n+\tss << \", denoise=\" << (frameContext.dpf.denoise ? \"enabled\" : \"disabled\");\n+\n+\tss << \", rb_fltsize=\"\n+\t << (config.rb_flt.fltsize == RKISP1_CIF_ISP_DPF_RB_FILTERSIZE_13x9 ? \"13x9\" : \"9x9\");\n+\tss << \", nll_scale=\"\n+\t << (config.nll.scale_mode == RKISP1_CIF_ISP_NLL_SCALE_LOGARITHMIC ? \"log\" : \"linear\");\n+\tss << \", gain_mode=\" << config.gain.mode;\n+\tss << \", strength=\" << int(strengthConfig.r) << ',' << int(strengthConfig.g) << ',' << int(strengthConfig.b);\n+\n+\tss << \", g=[\";\n+\tfor (size_t i = 0; i < RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS; ++i) {\n+\t\tif (i)\n+\t\t\tss << ',';\n+\t\tss << int(config.g_flt.spatial_coeff[i]);\n+\t}\n+\tss << \"]\";\n+\n+\tss << \", rb=[\";\n+\tfor (size_t i = 0; i < RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS; ++i) {\n+\t\tif (i)\n+\t\t\tss << ',';\n+\t\tss << int(config.rb_flt.spatial_coeff[i]);\n+\t}\n+\tss << \"]\";\n+\n+\tss << \", nll=[\";\n+\tfor (size_t i = 0; i < RKISP1_CIF_ISP_DPF_MAX_NLF_COEFFS; ++i) {\n+\t\tif (i)\n+\t\t\tss << ',';\n+\t\tss << int(config.nll.coeff[i]);\n+\t}\n+\tss << \"]\";\n+\tLOG(RkISP1Dpf, Debug) << ss.str();\n+}\n+\n /**\n * \\copydoc libcamera::ipa::Algorithm::queueRequest\n */\n@@ -318,7 +361,7 @@ void Dpf::queueRequest(IPAContext &context,\n \t\t\tbreak;\n \t\t}\n \t\tif (update)\n-\t\t\tLOG(RkISP1Dpf, Debug) << \"Set denoise to \" << modeName(*denoise);\n+\t\t\tLOG(RkISP1Dpf, Debug) << \"Set denoise to \" << *denoise;\n \t}\n \n \tframeContext.dpf.denoise = dpf.denoise;\n@@ -339,7 +382,7 @@ void Dpf::prepare(IPAContext &context, const uint32_t frame,\n \t\treturn;\n \t}\n \n-\tprepareEnabledMode(context, params);\n+\tprepareEnabledMode(context, frameContext, params);\n }\n \n void Dpf::prepareDisabledMode(RkISP1Params *params)\n@@ -350,7 +393,8 @@ void Dpf::prepareDisabledMode(RkISP1Params *params)\n \tdpfStrength.setEnabled(false);\n }\n \n-void Dpf::prepareEnabledMode(IPAContext &context, RkISP1Params *params)\n+void Dpf::prepareEnabledMode(IPAContext &context, IPAFrameContext &frameContext,\n+\t\t\t RkISP1Params *params)\n {\n \tif (activeMode_ == noiseReductionModes_.end())\n \t\treturn;\n@@ -386,6 +430,9 @@ void Dpf::prepareEnabledMode(IPAContext &context, RkISP1Params *params)\n \tauto strengthConfig = params->block<BlockType::DpfStrength>();\n \tstrengthConfig.setEnabled(true);\n \t*strengthConfig = modeConfig.strength;\n+\n+\tif (frameContext.dpf.update)\n+\t\tlogConfig(frameContext, *config, *strengthConfig);\n }\n \n REGISTER_IPA_ALGORITHM(Dpf, \"Dpf\")\ndiff --git a/src/ipa/rkisp1/algorithms/dpf.h b/src/ipa/rkisp1/algorithms/dpf.h\nindex 208d8fe9..66d3f302 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.h\n+++ b/src/ipa/rkisp1/algorithms/dpf.h\n@@ -43,9 +43,13 @@ private:\n \t\t\t rkisp1_cif_isp_dpf_strength_config &strengthConfig);\n \n \tbool loadConfig(int32_t mode);\n+\tvoid logConfig(const IPAFrameContext &frameContext,\n+\t\t const struct rkisp1_cif_isp_dpf_config &config,\n+\t\t const struct rkisp1_cif_isp_dpf_strength_config &strengthConfig) const;\n \n \tvoid prepareDisabledMode(RkISP1Params *params);\n-\tvoid prepareEnabledMode(IPAContext &context, RkISP1Params *params);\n+\tvoid prepareEnabledMode(IPAContext &context, IPAFrameContext &frameContext,\n+\t\t\t\tRkISP1Params *params);\n \n \tstd::vector<ModeConfig> noiseReductionModes_;\n \tstd::vector<ModeConfig>::const_iterator activeMode_;\n", "prefixes": [ "v11", "5/7" ] }