Patch Detail
Show a patch.
GET /api/patches/2595/?format=api
{ "id": 2595, "url": "https://patchwork.libcamera.org/api/patches/2595/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2595/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200112010212.2609025-14-niklas.soderlund@ragnatech.se>", "date": "2020-01-12T01:01:53", "name": "[libcamera-devel,v4,13/32] libcamera: v4l2_videodevice: Align which type variable is used in queueBuffer()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "84e468fc782d740957b029b7e3604c5b4df20edb", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2595/mbox/", "series": [ { "id": 617, "url": "https://patchwork.libcamera.org/api/series/617/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=617", "date": "2020-01-12T01:01:40", "name": "libcamera: Rework buffer API", "version": 4, "mbox": "https://patchwork.libcamera.org/series/617/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2595/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2595/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 20C65606D6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 12 Jan 2020 02:03:09 +0100 (CET)", "from bismarck.berto.se (p54ac5d7b.dip0.t-ipconnect.de\n\t[84.172.93.123]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 4a020e0e-34d7-11ea-b6d8-005056917f90;\n\tSun, 12 Jan 2020 02:03:05 +0100 (CET)" ], "X-Halon-ID": "4a020e0e-34d7-11ea-b6d8-005056917f90", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 12 Jan 2020 02:01:53 +0100", "Message-Id": "<20200112010212.2609025-14-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200112010212.2609025-1-niklas.soderlund@ragnatech.se>", "References": "<20200112010212.2609025-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 13/32] libcamera: v4l2_videodevice:\n\tAlign which type variable is used in queueBuffer()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sun, 12 Jan 2020 01:03:09 -0000" }, "content": "Reading V4L2VideoDevice::queueBuffer() is confusing since buf.type is\nfirst set to bufferType_ but then both variables are used in V4L2 macros\nto operate based on which type of buffer is being processed. Align on\nonly using buf.type since it has the most existing users.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/v4l2_videodevice.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex 1dc9e19350f825a9..81d999e354a16bd0 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -1004,7 +1004,7 @@ int V4L2VideoDevice::queueBuffer(Buffer *buffer)\n \t\tbuf.m.planes = v4l2Planes;\n \t}\n \n-\tif (V4L2_TYPE_IS_OUTPUT(bufferType_)) {\n+\tif (V4L2_TYPE_IS_OUTPUT(buf.type)) {\n \t\tbuf.bytesused = buffer->bytesused_;\n \t\tbuf.sequence = buffer->sequence_;\n \t\tbuf.timestamp.tv_sec = buffer->timestamp_ / 1000000000;\n", "prefixes": [ "libcamera-devel", "v4", "13/32" ] }