Patch Detail
Show a patch.
GET /api/patches/25941/?format=api
{ "id": 25941, "url": "https://patchwork.libcamera.org/api/patches/25941/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25941/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260122161935.208562-16-mzamazal@redhat.com>", "date": "2026-01-22T16:19:35", "name": "[v4,15/15] libcamera: ipa: simple: Disable Ccm algorithm by default again", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c2afed69a8da08b4f1aefece81466febd0e03720", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25941/mbox/", "series": [ { "id": 5733, "url": "https://patchwork.libcamera.org/api/series/5733/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5733", "date": "2026-01-22T16:19:20", "name": "Simple pipeline IPA cleanup", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5733/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25941/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25941/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4CCA7BDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 22 Jan 2026 16:20:49 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DD49A61FE7;\n\tThu, 22 Jan 2026 17:20:48 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E360F61FD1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 22 Jan 2026 17:20:47 +0100 (CET)", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-692-Rb9mYsOpOh2lt808rg7dwQ-1;\n\tThu, 22 Jan 2026 11:20:44 -0500", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 73EA71944DFF; Thu, 22 Jan 2026 16:20:43 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.224.97])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 94D941800577; Thu, 22 Jan 2026 16:20:41 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"H9Om2u+B\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1769098846;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=r0wQ6PJ2+koJySdZLiip9pAuwO/KpuEJkukxjpF88Ts=;\n\tb=H9Om2u+BIYeZwz/j8B2My/LymU8eeaWoMUtTy0fLTfuz6uXFBSRf3wHdlLqccgqu5w6QsY\n\t6iMQMgXPnqEQ0SBt3MFAQ68H3J1MnyPUang2+DIBaY5KG7p8W7VXsDryGN1AFmKaGiFfUq\n\t5WuteIFEdmR2lOn4pG3V198BTXibTz4=", "X-MC-Unique": "Rb9mYsOpOh2lt808rg7dwQ-1", "X-Mimecast-MFC-AGG-ID": "Rb9mYsOpOh2lt808rg7dwQ_1769098843", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t<barnabas.pocze@ideasonboard.com>", "Subject": "[PATCH v4 15/15] libcamera: ipa: simple: Disable Ccm algorithm by\n\tdefault again", "Date": "Thu, 22 Jan 2026 17:19:35 +0100", "Message-ID": "<20260122161935.208562-16-mzamazal@redhat.com>", "In-Reply-To": "<20260122161935.208562-1-mzamazal@redhat.com>", "References": "<20260122161935.208562-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "vcVKgYh85ahzxS3qQNCMprLeM9_m1brfZC5fDRcj6LQ_1769098843", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The default CCM in uncalibrated.yaml is just an identity transformation\nand has been enabled by default only to always provide a correction\nmatrix to GPU ISP. It slows down CPU ISP when CCM is not used.\n\nNow, when a default correction matrix is always provided to GPU ISP, we\ncan disable the Ccm algorithm in uncalibrated.yaml again. The check for\nccmEnabled in GPU ISP is no longer needed and it must be removed in\norder not to fail when Ccm algorithm is not enabled. ccmEnabled flag is\nstill needed in CPU ISP where the processing differs based on whether\nCCM is present or not.\n\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/ipa/simple/data/uncalibrated.yaml | 12 ++++++------\n src/libcamera/software_isp/debayer_egl.cpp | 5 +----\n 2 files changed, 7 insertions(+), 10 deletions(-)", "diff": "diff --git a/src/ipa/simple/data/uncalibrated.yaml b/src/ipa/simple/data/uncalibrated.yaml\nindex c6feda36d..fc90ca526 100644\n--- a/src/ipa/simple/data/uncalibrated.yaml\n+++ b/src/ipa/simple/data/uncalibrated.yaml\n@@ -8,12 +8,12 @@ algorithms:\n # Color correction matrices can be defined here. The CCM algorithm\n # has a significant performance impact, and should only be enabled\n # if tuned.\n- - Ccm:\n- ccms:\n- - ct: 6500\n- ccm: [ 1, 0, 0,\n- 0, 1, 0,\n- 0, 0, 1]\n+ # - Ccm:\n+ # ccms:\n+ # - ct: 6500\n+ # ccm: [ 1, 0, 0,\n+ # 0, 1, 0,\n+ # 0, 0, 1]\n - Adjust:\n - Agc:\n ...\ndiff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\nindex af04d60ca..3ed9b93df 100644\n--- a/src/libcamera/software_isp/debayer_egl.cpp\n+++ b/src/libcamera/software_isp/debayer_egl.cpp\n@@ -288,7 +288,7 @@ unsigned int DebayerEGL::frameSize()\n \n int DebayerEGL::configure(const StreamConfiguration &inputCfg,\n \t\t\t const std::vector<std::reference_wrapper<StreamConfiguration>> &outputCfgs,\n-\t\t\t bool ccmEnabled)\n+\t\t\t [[maybe_unused]] bool ccmEnabled)\n {\n \tif (getInputConfig(inputCfg.pixelFormat, inputConfig_) != 0)\n \t\treturn -EINVAL;\n@@ -296,9 +296,6 @@ int DebayerEGL::configure(const StreamConfiguration &inputCfg,\n \tif (stats_->configure(inputCfg) != 0)\n \t\treturn -EINVAL;\n \n-\tif (!ccmEnabled)\n-\t\treturn -EINVAL;\n-\n \tconst Size &stats_pattern_size = stats_->patternSize();\n \tif (inputConfig_.patternSize.width != stats_pattern_size.width ||\n \t inputConfig_.patternSize.height != stats_pattern_size.height) {\n", "prefixes": [ "v4", "15/15" ] }