Patch Detail
Show a patch.
GET /api/patches/25938/?format=api
{ "id": 25938, "url": "https://patchwork.libcamera.org/api/patches/25938/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25938/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260122161935.208562-13-mzamazal@redhat.com>", "date": "2026-01-22T16:19:32", "name": "[v4,12/15] libcamera: ipa: simple: Use symbolic constants for adjust defaults", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "5d7f67af2b8230ab5dde623bca05088b90769383", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25938/mbox/", "series": [ { "id": 5733, "url": "https://patchwork.libcamera.org/api/series/5733/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5733", "date": "2026-01-22T16:19:20", "name": "Simple pipeline IPA cleanup", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5733/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25938/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25938/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 51D5DBDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 22 Jan 2026 16:20:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E4A8A61FE2;\n\tThu, 22 Jan 2026 17:20:43 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 948C961FE4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 22 Jan 2026 17:20:40 +0100 (CET)", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-534-d8NSjxbhOZ-VF9qi2XuBqQ-1;\n\tThu, 22 Jan 2026 11:20:36 -0500", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 46CA81955D84; Thu, 22 Jan 2026 16:20:35 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.224.97])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 7EB1F1801AC9; Thu, 22 Jan 2026 16:20:33 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"dPB0kleF\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1769098839;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=sDLvUusc5OkFfSeMpHOZCQS+ZyxZNundjfzXfadkPRA=;\n\tb=dPB0kleFj+6CGzcLRLjWzKQHcIzvEc2/bpiJnvEUXvp5cWH42qR86nQ2BZ0T7ldwn+HeCa\n\tI8HAhew3KXoozR8lcbuOuTrg4YKOJ42FnhLlQtO9AIzDO9gWHZcTNN3U145kAEXLQhydpe\n\tXu3BVDDXyYuXztTRIz4hWT25LBfp0Yk=", "X-MC-Unique": "d8NSjxbhOZ-VF9qi2XuBqQ-1", "X-Mimecast-MFC-AGG-ID": "d8NSjxbhOZ-VF9qi2XuBqQ_1769098835", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t<barnabas.pocze@ideasonboard.com>", "Subject": "[PATCH v4 12/15] libcamera: ipa: simple: Use symbolic constants for\n\tadjust defaults", "Date": "Thu, 22 Jan 2026 17:19:32 +0100", "Message-ID": "<20260122161935.208562-13-mzamazal@redhat.com>", "In-Reply-To": "<20260122161935.208562-1-mzamazal@redhat.com>", "References": "<20260122161935.208562-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "EAqtZ_EJPxZTaHNS3sc0hV22wckpRS-XKzjNr2BZ7YQ_1769098835", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The adjust algorithm already uses a symbolic constant for gamma. Let's\nintroduce similar constants for contrast and saturation to prevent\ncopying the numeric defaults to multiple places.\n\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/ipa/simple/algorithms/adjust.cpp | 16 +++++++++++-----\n 1 file changed, 11 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/ipa/simple/algorithms/adjust.cpp b/src/ipa/simple/algorithms/adjust.cpp\nindex a8b7c5ab6..23f6f6ad7 100644\n--- a/src/ipa/simple/algorithms/adjust.cpp\n+++ b/src/ipa/simple/algorithms/adjust.cpp\n@@ -1,7 +1,7 @@\n /* SPDX-License-Identifier: LGPL-2.1-or-later */\n /*\n * Copyright (C) 2024, Ideas On Board\n- * Copyright (C) 2024-2025, Red Hat Inc.\n+ * Copyright (C) 2024-2026, Red Hat Inc.\n *\n * Common image adjustments\n */\n@@ -19,14 +19,20 @@ namespace libcamera {\n \n namespace ipa::soft::algorithms {\n \n+constexpr float kDefaultContrast = 1.0f;\n+constexpr float kDefaultSaturation = 1.0f;\n+\n LOG_DEFINE_CATEGORY(IPASoftAdjust)\n \n int Adjust::init(IPAContext &context, [[maybe_unused]] const YamlObject &tuningData)\n {\n-\tcontext.ctrlMap[&controls::Gamma] = ControlInfo(0.1f, 10.0f, kDefaultGamma);\n-\tcontext.ctrlMap[&controls::Contrast] = ControlInfo(0.0f, 2.0f, 1.0f);\n+\tcontext.ctrlMap[&controls::Gamma] =\n+\t\tControlInfo(0.1f, 10.0f, kDefaultGamma);\n+\tcontext.ctrlMap[&controls::Contrast] =\n+\t\tControlInfo(0.0f, 2.0f, kDefaultContrast);\n \tif (context.ccmEnabled)\n-\t\tcontext.ctrlMap[&controls::Saturation] = ControlInfo(0.0f, 2.0f, 1.0f);\n+\t\tcontext.ctrlMap[&controls::Saturation] =\n+\t\t\tControlInfo(0.0f, 2.0f, kDefaultSaturation);\n \treturn 0;\n }\n \n@@ -122,7 +128,7 @@ void Adjust::process([[maybe_unused]] IPAContext &context,\n \t\tmetadata.set(controls::Contrast, contrast.value());\n \n \tconst auto &saturation = frameContext.saturation;\n-\tmetadata.set(controls::Saturation, saturation.value_or(1.0));\n+\tmetadata.set(controls::Saturation, saturation.value_or(kDefaultSaturation));\n }\n \n REGISTER_IPA_ALGORITHM(Adjust, \"Adjust\")\n", "prefixes": [ "v4", "12/15" ] }