Patch Detail
Show a patch.
GET /api/patches/25937/?format=api
{ "id": 25937, "url": "https://patchwork.libcamera.org/api/patches/25937/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25937/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260122161935.208562-11-mzamazal@redhat.com>", "date": "2026-01-22T16:19:30", "name": "[v4,10/15] libcamera: ipa: simple: Apply gain matrix in awb", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "3ae27ce8243fe7a94bd2b555956e78fb4f0b91db", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25937/mbox/", "series": [ { "id": 5733, "url": "https://patchwork.libcamera.org/api/series/5733/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5733", "date": "2026-01-22T16:19:20", "name": "Simple pipeline IPA cleanup", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5733/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25937/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25937/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 88B4FC327D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 22 Jan 2026 16:20:42 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1EC7761FD4;\n\tThu, 22 Jan 2026 17:20:42 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CAE3161FD4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 22 Jan 2026 17:20:39 +0100 (CET)", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-94-7cutVTFNNaG9enp1l6KcTw-1;\n\tThu, 22 Jan 2026 11:20:32 -0500", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 93B5A1955D8E; Thu, 22 Jan 2026 16:20:30 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.224.97])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 03D6A1800240; Thu, 22 Jan 2026 16:20:28 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"OkA/Domx\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1769098838;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=TjD7mM/VrSDQn03xL75WPVgkICDm+csPILtj7ABoVuI=;\n\tb=OkA/Domx6d+1aNsiB6gTxxgS7GpV5nPaGMf6gIfl2WxsT2AOzvE4AIjZEah18XumOzwHc7\n\tQkf3sESCamxMJx7HwBydHu0QpkOvfPxAZ/TZVMLBzDuikd30fcLh+OgUgMufCOjawF0Ptf\n\tF5noGOfS1nDmORCKrPMs1IcQ7zRd7CM=", "X-MC-Unique": "7cutVTFNNaG9enp1l6KcTw-1", "X-Mimecast-MFC-AGG-ID": "7cutVTFNNaG9enp1l6KcTw_1769098830", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t<barnabas.pocze@ideasonboard.com>", "Subject": "[PATCH v4 10/15] libcamera: ipa: simple: Apply gain matrix in awb", "Date": "Thu, 22 Jan 2026 17:19:30 +0100", "Message-ID": "<20260122161935.208562-11-mzamazal@redhat.com>", "In-Reply-To": "<20260122161935.208562-1-mzamazal@redhat.com>", "References": "<20260122161935.208562-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "ZmJIyXxhNCQkVg_5T-muG6FW-qsT8LDJEllXweVM8YM_1769098830", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now, when we have a combined matrix, we can apply AWB gains to it\ndirectly in awb.cpp.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/ipa/simple/algorithms/awb.cpp | 7 ++++++-\n src/ipa/simple/algorithms/lut.cpp | 5 +----\n 2 files changed, 7 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\nindex a391359fb..4d2f1df15 100644\n--- a/src/ipa/simple/algorithms/awb.cpp\n+++ b/src/ipa/simple/algorithms/awb.cpp\n@@ -1,6 +1,6 @@\n /* SPDX-License-Identifier: LGPL-2.1-or-later */\n /*\n- * Copyright (C) 2024, Red Hat Inc.\n+ * Copyright (C) 2024-2025 Red Hat Inc.\n *\n * Auto white balance\n */\n@@ -40,6 +40,11 @@ void Awb::prepare(IPAContext &context,\n \t\t [[maybe_unused]] DebayerParams *params)\n {\n \tauto &gains = context.activeState.awb.gains;\n+\tMatrix<float, 3, 3> gainMatrix = { { gains.r(), 0, 0,\n+\t\t\t\t\t 0, gains.g(), 0,\n+\t\t\t\t\t 0, 0, gains.b() } };\n+\tcontext.activeState.combinedMatrix =\n+\t\tcontext.activeState.combinedMatrix * gainMatrix;\n \t/* Just report, the gains are applied in LUT algorithm. */\n \tframeContext.gains.red = gains.r();\n \tframeContext.gains.blue = gains.b();\ndiff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp\nindex 9740f8c8d..d8e92c613 100644\n--- a/src/ipa/simple/algorithms/lut.cpp\n+++ b/src/ipa/simple/algorithms/lut.cpp\n@@ -107,10 +107,7 @@ void Lut::prepare(IPAContext &context,\n \t\t\tparams->blue[i] = gammaTable[static_cast<unsigned int>(lutGains.b())];\n \t\t}\n \t} else if (context.activeState.matrixChanged || gammaUpdateNeeded) {\n-\t\tMatrix<float, 3, 3> gainMatrix = { { gains.r(), 0, 0,\n-\t\t\t\t\t\t 0, gains.g(), 0,\n-\t\t\t\t\t\t 0, 0, gains.b() } };\n-\t\tauto matrix = context.activeState.combinedMatrix * gainMatrix;\n+\t\tauto &matrix = context.activeState.combinedMatrix;\n \t\tauto &red = params->redCcm;\n \t\tauto &green = params->greenCcm;\n \t\tauto &blue = params->blueCcm;\n", "prefixes": [ "v4", "10/15" ] }