Patch Detail
Show a patch.
GET /api/patches/25910/?format=api
{ "id": 25910, "url": "https://patchwork.libcamera.org/api/patches/25910/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25910/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260121173737.376113-4-kieran.bingham@ideasonboard.com>", "date": "2026-01-21T17:37:22", "name": "[v6,03/16] ipa: libipa: fixedpoint: Fix unsigned usage", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "26ae561df9cd796f19ce8c79e7b53b7250a34539", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25910/mbox/", "series": [ { "id": 5730, "url": "https://patchwork.libcamera.org/api/series/5730/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5730", "date": "2026-01-21T17:37:19", "name": "libipa: Introduce a Quantized type", "version": 6, "mbox": "https://patchwork.libcamera.org/series/5730/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25910/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25910/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 82FAFBDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 21 Jan 2026 17:37:51 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DC37261FD0;\n\tWed, 21 Jan 2026 18:37:48 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AAE2D61FC4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 21 Jan 2026 18:37:42 +0100 (CET)", "from Monstersaurus.hippo-penny.ts.net\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AECC610C4;\n\tWed, 21 Jan 2026 18:37:10 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QDLPkhCI\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769017030;\n\tbh=Rb4rB3JXfjnsm6Ov63IoJOE4sl8Y0VNYeFld9ChYZM4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=QDLPkhCIywIO+KC3GaV9vkVO9s93A6e2P4Oodf+j05KsqZiIoB4J7klKaus+kTlZR\n\tWdsESDp+cZ11ypDNUSv4yJwgLThOnU1uREik4SvDBujdVhG1ygQNKgFwBY5ST7+Rjp\n\tlHrhrBK6Zx89dK9PQCbwbH9VTj7McrztZQ2xCTFs=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\tIsaac Scott <isaac.scott@ideasonboard.com>", "Subject": "[PATCH v6 03/16] ipa: libipa: fixedpoint: Fix unsigned usage", "Date": "Wed, 21 Jan 2026 17:37:22 +0000", "Message-ID": "<20260121173737.376113-4-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260121173737.376113-1-kieran.bingham@ideasonboard.com>", "References": "<20260121173737.376113-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The fixedToFloatingPoint does not support unsigned Q types, and\nincorrectly sign-extends all values which have the top most bit set in\nthe quantized values.\n\nFix this by ensuring that only signed types perform sign extension, and\nsimplify the calculation for unsigned types.\n\nConvert the storage of the test cases to signed types to correctly\nrepresent their intended purpose, to prevent test failures.\n\nReviewed-by: Isaac Scott <isaac.scott@ideasonboard.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n---\n\nv6:\n\n - Use T{1} << F instead of 1 << F\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/libipa/fixedpoint.h | 3 +++\n test/ipa/libipa/fixedpoint.cpp | 6 +++---\n 2 files changed, 6 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/ipa/libipa/fixedpoint.h b/src/ipa/libipa/fixedpoint.h\nindex 709cf50f0fcd..48a9757f9554 100644\n--- a/src/ipa/libipa/fixedpoint.h\n+++ b/src/ipa/libipa/fixedpoint.h\n@@ -49,6 +49,9 @@ constexpr R fixedToFloatingPoint(T number)\n \tstatic_assert(sizeof(int) >= sizeof(T));\n \tstatic_assert(I + F <= sizeof(T) * 8);\n \n+\tif constexpr (std::is_unsigned_v<T>)\n+\t\treturn static_cast<R>(number) / static_cast<R>(T{1} << F);\n+\n \t/*\n \t * Recreate the upper bits in case of a negative number by shifting the sign\n \t * bit from the fixed point to the first bit of the unsigned and then right shifting\ndiff --git a/test/ipa/libipa/fixedpoint.cpp b/test/ipa/libipa/fixedpoint.cpp\nindex 99eb662ddf4e..4b017e86a74f 100644\n--- a/test/ipa/libipa/fixedpoint.cpp\n+++ b/test/ipa/libipa/fixedpoint.cpp\n@@ -68,7 +68,7 @@ protected:\n \t\t * The second 7.992 test is to test that unused bits don't\n \t\t * affect the result.\n \t\t */\n-\t\tstd::map<double, uint16_t> testCases = {\n+\t\tstd::map<double, int16_t> testCases = {\n \t\t\t{ 7.992, 0x3ff },\n \t\t\t{ 0.2, 0x01a },\n \t\t\t{ -0.2, 0x7e6 },\n@@ -81,14 +81,14 @@ protected:\n \n \t\tint ret;\n \t\tfor (const auto &testCase : testCases) {\n-\t\t\tret = testSingleFixedPoint<4, 7, uint16_t>(testCase.first,\n+\t\t\tret = testSingleFixedPoint<4, 7, int16_t>(testCase.first,\n \t\t\t\t\t\t\t\t testCase.second);\n \t\t\tif (ret != TestPass)\n \t\t\t\treturn ret;\n \t\t}\n \n \t\t/* Special case with a superfluous one in the unused bits */\n-\t\tret = testFixedToFloat<4, 7, uint16_t, double>(0xbff, 7.992);\n+\t\tret = testFixedToFloat<4, 7, int16_t, double>(0xbff, 7.992);\n \t\tif (ret != TestPass)\n \t\t\treturn ret;\n \n", "prefixes": [ "v6", "03/16" ] }