Patch Detail
Show a patch.
GET /api/patches/25901/?format=api
{ "id": 25901, "url": "https://patchwork.libcamera.org/api/patches/25901/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25901/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260121090705.274081-3-uajain@igalia.com>", "date": "2026-01-21T09:07:04", "name": "[2/3] pipeline: virtual: Implement colorspace() getter for frame generators", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b9498d42eaabc9525b7bf8288800b648fc2b211b", "submitter": { "id": 232, "url": "https://patchwork.libcamera.org/api/people/232/?format=api", "name": "Umang Jain", "email": "uajain@igalia.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25901/mbox/", "series": [ { "id": 5727, "url": "https://patchwork.libcamera.org/api/series/5727/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5727", "date": "2026-01-21T09:07:02", "name": "virtual: colorspace validation fix", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5727/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25901/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25901/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BF8AFC327D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 21 Jan 2026 09:06:30 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9B65D61FC6;\n\tWed, 21 Jan 2026 10:06:27 +0100 (CET)", "from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 40AC0615B2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 21 Jan 2026 10:06:24 +0100 (CET)", "from [49.36.125.126] (helo=uajain)\n\tby fanzine2.igalia.com with esmtpsa \n\t(Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1viUAR-007xDQ-9u; Wed, 21 Jan 2026 10:06:23 +0100" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"nkLVG18G\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=AZizNohLGekzI24KUjaMEqFoDsP5O0Oy1eEvqR5Cwis=;\n\tb=nkLVG18GUj9MycFU7fCpPwQpr2\n\tO46vuiSEWW41DmsIdANI8/ip/K1C51rDLQ3SLhDDmMkpMLUisieEZobxh2yj3pVKzddjij9Lg7NWo\n\te3LENCCGGJ1dFiqTCLLT99VihrvCWQ65pn7WZRbAFhq0j0lEfO4iv+1GMeqKjbWn0ff97+SVicr3J\n\ttHPX+qnETCSq0H2m8neQ6dm5xop1ijHR8EpfmipkSLgauM63dzr8j7mnCCZNR4fVv3/gMsAvMaqFI\n\tfzdZZK/FD+76L0vOofg8HjjXidKpu+VY8EsV3ZfFy+EGDWCxnEDDPUrg7yJfYHomjlN2PXsQ/XGkc\n\tZ8j1poDQ==;", "From": "Umang Jain <uajain@igalia.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Umang Jain <uajain@igalia.com>", "Subject": "[PATCH 2/3] pipeline: virtual: Implement colorspace() getter for\n\tframe generators", "Date": "Wed, 21 Jan 2026 14:37:04 +0530", "Message-ID": "<20260121090705.274081-3-uajain@igalia.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260121090705.274081-1-uajain@igalia.com>", "References": "<20260121090705.274081-1-uajain@igalia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Each frame generator can decide what colorspace is deemed fit for their\ngenerated frames. Provide a virtual getter colorspace() and implement it\nthe TestPatternGenerator and ImageFrameGenerator classes.\n\nSigned-off-by: Umang Jain <uajain@igalia.com>\n---\n .../pipeline/virtual/frame_generator.h | 3 +++\n .../pipeline/virtual/image_frame_generator.cpp | 9 +++++++++\n .../pipeline/virtual/image_frame_generator.h | 2 ++\n .../virtual/test_pattern_generator.cpp | 18 ++++++++++++++++++\n .../pipeline/virtual/test_pattern_generator.h | 4 ++++\n 5 files changed, 36 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/virtual/frame_generator.h b/src/libcamera/pipeline/virtual/frame_generator.h\nindex a0658c45..acbf2cc1 100644\n--- a/src/libcamera/pipeline/virtual/frame_generator.h\n+++ b/src/libcamera/pipeline/virtual/frame_generator.h\n@@ -7,6 +7,7 @@\n \n #pragma once\n \n+#include <libcamera/color_space.h>\n #include <libcamera/framebuffer.h>\n #include <libcamera/geometry.h>\n \n@@ -19,6 +20,8 @@ public:\n \n \tvirtual void configure(const Size &size) = 0;\n \n+\tvirtual const ColorSpace colorspace() = 0;\n+\n \tvirtual int generateFrame(const Size &size,\n \t\t\t\t const FrameBuffer *buffer) = 0;\n \ndiff --git a/src/libcamera/pipeline/virtual/image_frame_generator.cpp b/src/libcamera/pipeline/virtual/image_frame_generator.cpp\nindex d1545b5d..bab3cfdc 100644\n--- a/src/libcamera/pipeline/virtual/image_frame_generator.cpp\n+++ b/src/libcamera/pipeline/virtual/image_frame_generator.cpp\n@@ -149,6 +149,15 @@ int ImageFrameGenerator::generateFrame(const Size &size, const FrameBuffer *buff\n \treturn 0;\n }\n \n+const ColorSpace ImageFrameGenerator::colorspace()\n+{\n+\t/*\n+\t * libyuv ensures sYCC colorspace of frames during MJPGToNV12()\n+\t * conversion.\n+\t */\n+\treturn ColorSpace::Sycc;\n+}\n+\n /*\n * \\var ImageFrameGenerator::imageFrameDatas_\n * \\brief List of pointers to the not scaled image buffers\ndiff --git a/src/libcamera/pipeline/virtual/image_frame_generator.h b/src/libcamera/pipeline/virtual/image_frame_generator.h\nindex 851ddbc0..24c362e6 100644\n--- a/src/libcamera/pipeline/virtual/image_frame_generator.h\n+++ b/src/libcamera/pipeline/virtual/image_frame_generator.h\n@@ -13,6 +13,7 @@\n #include <sys/types.h>\n #include <vector>\n \n+#include <libcamera/color_space.h>\n #include <libcamera/framebuffer.h>\n #include <libcamera/geometry.h>\n \n@@ -41,6 +42,7 @@ private:\n \n \tvoid configure(const Size &size) override;\n \tint generateFrame(const Size &size, const FrameBuffer *buffer) override;\n+\tconst ColorSpace colorspace() override;\n \n \tstd::vector<ImageFrameData> imageFrameDatas_;\n \tstd::vector<ImageFrameData> scaledFrameDatas_;\ndiff --git a/src/libcamera/pipeline/virtual/test_pattern_generator.cpp b/src/libcamera/pipeline/virtual/test_pattern_generator.cpp\nindex 745be83b..04efe6cc 100644\n--- a/src/libcamera/pipeline/virtual/test_pattern_generator.cpp\n+++ b/src/libcamera/pipeline/virtual/test_pattern_generator.cpp\n@@ -62,6 +62,24 @@ int TestPatternGenerator::generateFrame(const Size &size,\n \treturn ret;\n }\n \n+/*\n+ * libyuv internally converts ARGB<>YUV following the BT.601 colorspace.\n+ * The corresponding YCbCr encoding is ColorSpace::YcbcrEncoding::Rec601\n+ * with limited range.\n+ *\n+ * Since the test patterns generation occurs in RGB, transfer function is set\n+ * to ColorSpace::TransferFunction::Srgb. Color primaries is assumed\n+ * ColorSpace::Primaries::Rec709 for the RGB test patterns.\n+ */\n+const ColorSpace TestPatternGenerator::colorspace()\n+{\n+\tColorSpace colorspace{ ColorSpace::Primaries::Rec709,\n+\t\t\t ColorSpace::TransferFunction::Srgb,\n+\t\t\t ColorSpace::YcbcrEncoding::Rec601,\n+\t\t\t ColorSpace::Range::Limited };\n+\treturn colorspace;\n+}\n+\n void ColorBarsGenerator::configure(const Size &size)\n {\n \tconstexpr uint8_t kColorBar[8][3] = {\ndiff --git a/src/libcamera/pipeline/virtual/test_pattern_generator.h b/src/libcamera/pipeline/virtual/test_pattern_generator.h\nindex 2a51bd31..fb2de65f 100644\n--- a/src/libcamera/pipeline/virtual/test_pattern_generator.h\n+++ b/src/libcamera/pipeline/virtual/test_pattern_generator.h\n@@ -9,6 +9,7 @@\n \n #include <memory>\n \n+#include <libcamera/color_space.h>\n #include <libcamera/framebuffer.h>\n #include <libcamera/geometry.h>\n \n@@ -29,6 +30,9 @@ public:\n protected:\n \t/* Buffer of test pattern template */\n \tstd::unique_ptr<uint8_t[]> template_;\n+\n+private:\n+\tconst ColorSpace colorspace() override;\n };\n \n class ColorBarsGenerator : public TestPatternGenerator\n", "prefixes": [ "2/3" ] }