Patch Detail
Show a patch.
GET /api/patches/25900/?format=api
{ "id": 25900, "url": "https://patchwork.libcamera.org/api/patches/25900/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25900/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260121090705.274081-2-uajain@igalia.com>", "date": "2026-01-21T09:07:03", "name": "[1/3] pipeline: virtual: image_frame_generator: Explicitly include libcamera headers", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "59bfb2bcd69ea84cdb52bc942e2857ccc959dea3", "submitter": { "id": 232, "url": "https://patchwork.libcamera.org/api/people/232/?format=api", "name": "Umang Jain", "email": "uajain@igalia.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25900/mbox/", "series": [ { "id": 5727, "url": "https://patchwork.libcamera.org/api/series/5727/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5727", "date": "2026-01-21T09:07:02", "name": "virtual: colorspace validation fix", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5727/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25900/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25900/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 61804BDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 21 Jan 2026 09:06:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D526061FCB;\n\tWed, 21 Jan 2026 10:06:26 +0100 (CET)", "from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AA8C261FBF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 21 Jan 2026 10:06:22 +0100 (CET)", "from [49.36.125.126] (helo=uajain)\n\tby fanzine2.igalia.com with esmtpsa \n\t(Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1viUAP-007xDQ-JL; Wed, 21 Jan 2026 10:06:22 +0100" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"XFXb3iJH\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=Yncsx+sYeywIY/Nc9NHpNEGOVrm0gKrJgWc9wPDsXmQ=;\n\tb=XFXb3iJHCruWLkCYZ/QXy68FWh\n\ty1mopKyyipVwKZN7AhLF4eFfKBIQJq60c3voosKNrjO8VlsA9aoKv0ijsV8BnY3+dP8YJEJbFo5kR\n\tswYzF47miP44SLxhQUfHg6EQEuq+XGHKtDkAhx3oqK7sxm1TyVeJUiLAauOUpnErAQrZAyIQYaCu8\n\tdHo9H/+OHDc6McSYQDvPltjRpU1pin1b41HvWKbVm8/8dqTfG7PCMEAlt9K1pT7mEA9cbS0MXnidB\n\t76/c2xKwh8y1hYZTiJVcp0naCGrR977KAhjky3SSAemFaxGWF6cdWpuHvw0yQdBjq/veOnrQQxoTc\n\tCIeehX9Q==;", "From": "Umang Jain <uajain@igalia.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Umang Jain <uajain@igalia.com>", "Subject": "[PATCH 1/3] pipeline: virtual: image_frame_generator: Explicitly\n\tinclude libcamera headers", "Date": "Wed, 21 Jan 2026 14:37:03 +0530", "Message-ID": "<20260121090705.274081-2-uajain@igalia.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260121090705.274081-1-uajain@igalia.com>", "References": "<20260121090705.274081-1-uajain@igalia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Directly include libcamera headers instead of including them indirectly\nvia frame_generator.h.\n\nSigned-off-by: Umang Jain <uajain@igalia.com>\n---\n src/libcamera/pipeline/virtual/image_frame_generator.h | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/virtual/image_frame_generator.h b/src/libcamera/pipeline/virtual/image_frame_generator.h\nindex 42a077ba..851ddbc0 100644\n--- a/src/libcamera/pipeline/virtual/image_frame_generator.h\n+++ b/src/libcamera/pipeline/virtual/image_frame_generator.h\n@@ -13,6 +13,9 @@\n #include <sys/types.h>\n #include <vector>\n \n+#include <libcamera/framebuffer.h>\n+#include <libcamera/geometry.h>\n+\n #include \"frame_generator.h\"\n \n namespace libcamera {\n", "prefixes": [ "1/3" ] }