Patch Detail
Show a patch.
GET /api/patches/25886/?format=api
{ "id": 25886, "url": "https://patchwork.libcamera.org/api/patches/25886/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25886/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260120-sklug-lsc-resampling-v2-dev-v5-14-ef5cec7b299f@ideasonboard.com>", "date": "2026-01-20T12:26:19", "name": "[v5,14/15] libcamera: control_ids: Introduce LensShadingCorrectionEnable", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ec209d413f7fb04a6d142b6daf67ce41ca0e00f0", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25886/mbox/", "series": [ { "id": 5722, "url": "https://patchwork.libcamera.org/api/series/5722/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5722", "date": "2026-01-20T12:26:05", "name": "Add resampling support for polynomial LSC data", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5722/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25886/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25886/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 39630BDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Jan 2026 12:26:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E5DF661FDA;\n\tTue, 20 Jan 2026 13:26:53 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2068761FD8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Jan 2026 13:26:52 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:b09a:fcc3:e9a4:a9a8])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id CC1E12169; \n\tTue, 20 Jan 2026 13:26:20 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BBVAyNwp\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768911981;\n\tbh=/8uZXMnK91LgMoPn0RFpCq1WsPCslKEFgkjxgIcafUQ=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=BBVAyNwpqns5NWK2bpm5Nh08b+7fHEH7nri32qtk0S9wsedAfSFwhGHnN+W/iWBRS\n\toRwiIH54z9JjiRRPd51NZGMaGpe7hFmeX7kDPgyx3PzaeJYGmheD42M/A+S+0paCkY\n\tGsqeA+wJh3ZClA0nC05Bs5T0LEJCbw9Ukr+lCKLQ=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "Date": "Tue, 20 Jan 2026 13:26:19 +0100", "Subject": "[PATCH v5 14/15] libcamera: control_ids: Introduce\n\tLensShadingCorrectionEnable", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260120-sklug-lsc-resampling-v2-dev-v5-14-ef5cec7b299f@ideasonboard.com>", "References": "<20260120-sklug-lsc-resampling-v2-dev-v5-0-ef5cec7b299f@ideasonboard.com>", "In-Reply-To": "<20260120-sklug-lsc-resampling-v2-dev-v5-0-ef5cec7b299f@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>, \n\tJacopo Mondi <jacopo@jmondi.org>", "X-Mailer": "b4 0.14.2", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Introduce a LensShadingCorrectionEnable control to enable and disable\nLSC. This is useful to assess the working and quality of the lens\nshading correction at runtime as well as being able to disable the\ncorrection in case it shall be done manually in post processing.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n\n---\n\nChanges in v5:\n- Readd this patch to have a separate patch for the control id\n- Dropped android specific changes\n\nChanges in v2:\n- Renamed LensShadingEnable to LensShadingCorrectionEnable\n- Fixed android code to properly handle the boolean value\n- Added \"only if tuned\" info sentence to the control description\n---\n src/libcamera/control_ids_core.yaml | 9 +++++++++\n 1 file changed, 9 insertions(+)", "diff": "diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\nindex 8e99bd84825f6060dbc323be3f4b0cd6283e0942..ced98e4625bfba9165be4f93d1fd2756881a2d1b 100644\n--- a/src/libcamera/control_ids_core.yaml\n+++ b/src/libcamera/control_ids_core.yaml\n@@ -1356,4 +1356,13 @@ controls:\n Enable or disable lens dewarping. This control is only available if lens\n dewarp parameters are configured in the tuning file.\n \n+ - LensShadingCorrectionEnable:\n+ type: bool\n+ direction: inout\n+ description: |\n+ Enable or disable the lens shading algorithm.\n+\n+ This control is only available when there are valid lens shading\n+ correction parameters available in the tuning file.\n+\n ...\n", "prefixes": [ "v5", "14/15" ] }