Patch Detail
Show a patch.
GET /api/patches/25876/?format=api
{ "id": 25876, "url": "https://patchwork.libcamera.org/api/patches/25876/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25876/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260120-sklug-lsc-resampling-v2-dev-v5-4-ef5cec7b299f@ideasonboard.com>", "date": "2026-01-20T12:26:09", "name": "[v5,04/15] ipa: rkisp1: lsc: Rename res to positions", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0ee819e8a55a8bb121448dbae8acfd6541c8d2ad", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25876/mbox/", "series": [ { "id": 5722, "url": "https://patchwork.libcamera.org/api/series/5722/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5722", "date": "2026-01-20T12:26:05", "name": "Add resampling support for polynomial LSC data", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5722/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25876/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25876/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D065ABDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Jan 2026 12:26:22 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9EEFD61FBF;\n\tTue, 20 Jan 2026 13:26:22 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F023361A35\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Jan 2026 13:26:21 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:b09a:fcc3:e9a4:a9a8])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id A136C21B1; \n\tTue, 20 Jan 2026 13:25:50 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HuN8yRBZ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768911950;\n\tbh=OidrM49Hyx9J+ESnrJB6SegC1GcDkuwWcSVuhdfK2Uc=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=HuN8yRBZCkCg8at7P3GkehvVnOjdAQL8UAeqDaW2ysvL/i3NB8GCXZNeA+T3TWEPG\n\t99XRIXEo6dk759I9HogmRXOOYBf+tWICOYY1qhS7r8dqu/4teLzEHbfimBIf+IXU0Q\n\t748Zk48uW7lbMTQHGQkUFP49L2pmuHPRSVJ+LcNk=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "Date": "Tue, 20 Jan 2026 13:26:09 +0100", "Subject": "[PATCH v5 04/15] ipa: rkisp1: lsc: Rename res to positions", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260120-sklug-lsc-resampling-v2-dev-v5-4-ef5cec7b299f@ideasonboard.com>", "References": "<20260120-sklug-lsc-resampling-v2-dev-v5-0-ef5cec7b299f@ideasonboard.com>", "In-Reply-To": "<20260120-sklug-lsc-resampling-v2-dev-v5-0-ef5cec7b299f@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P?=\n\t=?utf-8?b?xZFjemU=?= <barnabas.pocze@ideasonboard.com>,\n\tRui Wang <rui.wang@ideasonboard.com>", "X-Mailer": "b4 0.14.2", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Rename the res variable to positions which better describes the intent.\nThis was commented in review after being merged.\n\nWhile at it, improve the documentation a bit.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Rui Wang <rui.wang@ideasonboard.com>\n\n---\n\nChanges in v2:\n- Collected tags\n---\n src/ipa/rkisp1/algorithms/lsc.cpp | 18 ++++++++++--------\n 1 file changed, 10 insertions(+), 8 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\nindex c581e6441853d18618284b51bfa25c25e1fc8083..bb58386ae646ad6089322ba63d2a9e89664884d2 100644\n--- a/src/ipa/rkisp1/algorithms/lsc.cpp\n+++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n@@ -132,9 +132,11 @@ public:\n \n private:\n \t/*\n-\t * The lsc grid has custom spacing defined on half the range (see\n-\t * parseSizes() for details). For easier handling this function converts\n-\t * the spaces vector to positions and mirrors them. E.g.:\n+\t * The rkisp1 LSC grid spacing is defined by the cell sizes on the first\n+\t * half of the grid. This is then mirrored in hardware to the other\n+\t * half. See parseSizes() for further details. For easier handling, this\n+\t * function converts the cell sizes of half the grid to a list of\n+\t * position of the whole grid (on one axis). Example:\n \t *\n \t * input: | 0.2 | 0.3 |\n \t * output: 0.0 0.2 0.5 0.8 1.0\n@@ -142,17 +144,17 @@ private:\n \tstd::vector<double> sizesListToPositions(const std::vector<double> &sizes)\n \t{\n \t\tconst int half = sizes.size();\n-\t\tstd::vector<double> res(half * 2 + 1);\n+\t\tstd::vector<double> positions(half * 2 + 1);\n \t\tdouble x = 0.0;\n \n-\t\tres[half] = 0.5;\n+\t\tpositions[half] = 0.5;\n \t\tfor (int i = 1; i <= half; i++) {\n \t\t\tx += sizes[half - i];\n-\t\t\tres[half - i] = 0.5 - x;\n-\t\t\tres[half + i] = 0.5 + x;\n+\t\t\tpositions[half - i] = 0.5 - x;\n+\t\t\tpositions[half + i] = 0.5 + x;\n \t\t}\n \n-\t\treturn res;\n+\t\treturn positions;\n \t}\n \n \tstd::vector<uint16_t> samplePolynomial(const LscPolynomial &poly)\n", "prefixes": [ "v5", "04/15" ] }