Patch Detail
Show a patch.
GET /api/patches/25850/?format=api
{ "id": 25850, "url": "https://patchwork.libcamera.org/api/patches/25850/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25850/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260119113104.3560802-6-barnabas.pocze@ideasonboard.com>", "date": "2026-01-19T11:31:03", "name": "[v2,5/5] libcamera: base: log: Inline `LOG()` into `ASSERT()`", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e056b3848c165a110038825bb7618c1e72d21569", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25850/mbox/", "series": [ { "id": 5716, "url": "https://patchwork.libcamera.org/api/series/5716/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5716", "date": "2026-01-19T11:30:58", "name": "libcamera: base: log: Do not instantiate disabled `LogMessage`s", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5716/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25850/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25850/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C2F09C327D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 19 Jan 2026 11:31:16 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7903B61FCA;\n\tMon, 19 Jan 2026 12:31:16 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 903E261FC0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 19 Jan 2026 12:31:08 +0100 (CET)", "from pb-laptop.local (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 50A80C79\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 19 Jan 2026 12:30:38 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GKHIiId4\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768822238;\n\tbh=PA3i2QUDvbgwK1eYqs0+mNuHHaAHoiKgE3WuGpC/PmE=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=GKHIiId4CiGYg5Tvw63+5aJOy1dI33leVFcwVWHd0MB3xpwU0Lf274HwRl2GMWDXB\n\tyskox5S92qq4ZCBzaoJdHnMgpLLTTwbnUd5pDnXPBoC5I49iCWrSKqbRXAGRvJTb0D\n\tUBg7ir6Jj4KfyfqdOi1399jYt5q7OiuwsGu9/K3M=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v2 5/5] libcamera: base: log: Inline `LOG()` into `ASSERT()`", "Date": "Mon, 19 Jan 2026 12:31:03 +0100", "Message-ID": "<20260119113104.3560802-6-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260119113104.3560802-1-barnabas.pocze@ideasonboard.com>", "References": "<20260119113104.3560802-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Avoid the conditional logic in the expansion of `LOG()` inside `ASSERT()` by\ndirectly calling `_log(...)` with the appropriate parameters.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n include/libcamera/base/log.h | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/include/libcamera/base/log.h b/include/libcamera/base/log.h\nindex dbd14951c..8419300a5 100644\n--- a/include/libcamera/base/log.h\n+++ b/include/libcamera/base/log.h\n@@ -130,9 +130,11 @@ LogMessage _log(const LogCategory &category, LogSeverity severity,\n \n #ifndef NDEBUG\n #define ASSERT(condition) static_cast<void>(({ \\\n-\tif (!(condition)) \\\n-\t\tLOG(Fatal) << \"assertion \\\"\" #condition \"\\\" failed in \" \\\n-\t\t\t << __func__ << \"()\"; \\\n+\tif (!(condition)) { \\\n+\t\t_log(LogCategory::defaultCategory(), LogFatal).stream() \\\n+\t\t\t<< \"assertion \\\"\" #condition \"\\\" failed in \" \\\n+\t\t\t<< __func__ << \"()\"; \\\n+\t} \\\n }))\n #else\n #define ASSERT(condition) static_cast<void>(false && (condition))\n", "prefixes": [ "v2", "5/5" ] }