Patch Detail
Show a patch.
GET /api/patches/25849/?format=api
{ "id": 25849, "url": "https://patchwork.libcamera.org/api/patches/25849/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25849/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260119113104.3560802-5-barnabas.pocze@ideasonboard.com>", "date": "2026-01-19T11:31:02", "name": "[v2,4/5] libcamera: base: log: Remove `LogInvalid` check", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "68e3afacca9e37da5d9f59d6b13278f237b93d09", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25849/mbox/", "series": [ { "id": 5716, "url": "https://patchwork.libcamera.org/api/series/5716/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5716", "date": "2026-01-19T11:30:58", "name": "libcamera: base: log: Do not instantiate disabled `LogMessage`s", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5716/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25849/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25849/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0CD1CC32E7\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 19 Jan 2026 11:31:16 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6A16B61FC5;\n\tMon, 19 Jan 2026 12:31:13 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 62EE561FBF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 19 Jan 2026 12:31:08 +0100 (CET)", "from pb-laptop.local (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 24FE4C7B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 19 Jan 2026 12:30:38 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"arMcvaY5\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768822238;\n\tbh=SciAsgSRkrmF8HdcmTNvyPv/RmUR13NN79Xl5+b+6xQ=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=arMcvaY5cHk6Ux/2G9rQSi2PTH9WpMWVu5RwbBMF5JtoBxr+L/Eli2F+A8f/TYBh6\n\tCtkBxfgD8SkL8Rn4lMMC+51waBicgOD08+5DUdwgd5DN4pyNXu01TKN/WD1j/SKJfD\n\tF2jCvKdTVQU6j8nSGeFjRDETJM9cy5LZJHVeOMBo=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v2 4/5] libcamera: base: log: Remove `LogInvalid` check", "Date": "Mon, 19 Jan 2026 12:31:02 +0100", "Message-ID": "<20260119113104.3560802-5-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260119113104.3560802-1-barnabas.pocze@ideasonboard.com>", "References": "<20260119113104.3560802-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "A `LogMessage` instance cannot be moved or copied, so a severity of\n`LogInvalid` is only possible if the message was constructed with that\nlog level explicitly. However, being a completely internal type, this\ndoes not occur. So remove the check. And even if it does, it's probably\nstill better to print the message than to drop it silently.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/base/log.cpp | 4 ----\n 1 file changed, 4 deletions(-)", "diff": "diff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp\nindex da45b0d65..7d308afae 100644\n--- a/src/libcamera/base/log.cpp\n+++ b/src/libcamera/base/log.cpp\n@@ -857,10 +857,6 @@ LogMessage::LogMessage(const char *fileName, unsigned int line,\n \n LogMessage::~LogMessage()\n {\n-\t/* Don't print anything if we have been moved to another LogMessage. */\n-\tif (severity_ == LogInvalid)\n-\t\treturn;\n-\n \tLogger *logger = Logger::instance();\n \tif (!logger)\n \t\treturn;\n", "prefixes": [ "v2", "4/5" ] }