Patch Detail
Show a patch.
GET /api/patches/25814/?format=api
{ "id": 25814, "url": "https://patchwork.libcamera.org/api/patches/25814/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25814/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260115111630.1892890-2-barnabas.pocze@ideasonboard.com>", "date": "2026-01-15T11:16:29", "name": "[v1,2/3] ipa: rpi: Fix printing of `utils::Duration`", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8bd630ca58b3e29ebae1d16db0beda707723dc6b", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25814/mbox/", "series": [ { "id": 5709, "url": "https://patchwork.libcamera.org/api/series/5709/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5709", "date": "2026-01-15T11:16:28", "name": "[v1,1/3] libcamera: base: utils: Simplify `operator<<` for `Duration`", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5709/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25814/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25814/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 78C33BDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 15 Jan 2026 11:16:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 60F1B61FC6;\n\tThu, 15 Jan 2026 12:16:36 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 23ABA61FA3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Jan 2026 12:16:33 +0100 (CET)", "from pb-laptop.local (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AA13A766\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Jan 2026 12:16:05 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"A1H+zMzH\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768475765;\n\tbh=YWISlLfLzrI0iP3LF4n9GCMmntpC4NRHoH7kPM9FUGI=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=A1H+zMzHdZE2IRRQ/gWPgNDDXp4In1gafATvE0sZUAJj4NUXq+vzvf1MaB+4yWvAC\n\t1EZq8Wmkq0W9KwbQsUIL8+lYSDErolnpk0OiFCvCqSbrPJRsOAfEwtf9foNsjlKN5C\n\tN31ilOtC92w9Xt0qddOekuPoawMgfxKhHIo+etGw=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v1 2/3] ipa: rpi: Fix printing of `utils::Duration`", "Date": "Thu, 15 Jan 2026 12:16:29 +0100", "Message-ID": "<20260115111630.1892890-2-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260115111630.1892890-1-barnabas.pocze@ideasonboard.com>", "References": "<20260115111630.1892890-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "`utils::Duration` derives from `std::chrono::duration<...>`, but multiplying\nit yields an `std::chrono::duration<...>`, not `Duration`. chrono duration\ntypes only have `operator<<` in C++20 or later, so this usage should not\ncompile. It only did so because the `operator<<` for `Duration` was in\nthe `libcamera` namespace and `Duration` has an implicit constructor from\nany chrono duration type.\n\nThis will cease to work when that operator is moved into the `utils` namespace\nfor ADL purposes. So fix it by making the cast to `Duration` explicit.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/ipa/rpi/common/ipa_base.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\nindex 14aba4500..f95a0f838 100644\n--- a/src/ipa/rpi/common/ipa_base.cpp\n+++ b/src/ipa/rpi/common/ipa_base.cpp\n@@ -602,7 +602,7 @@ void IpaBase::setMode(const IPACameraSensorInfo &sensorInfo)\n \t\t\tmode_.minLineLength = adjustedLineLength;\n \t\t} else {\n \t\t\tLOG(IPARPI, Error)\n-\t\t\t\t<< \"Sensor minimum line length of \" << pixelTime * mode_.width\n+\t\t\t\t<< \"Sensor minimum line length of \" << Duration(pixelTime * mode_.width)\n \t\t\t\t<< \" (\" << 1us / pixelTime << \" MPix/s)\"\n \t\t\t\t<< \" is below the minimum allowable ISP limit of \"\n \t\t\t\t<< adjustedLineLength\n", "prefixes": [ "v1", "2/3" ] }