Patch Detail
Show a patch.
GET /api/patches/2581/?format=api
{ "id": 2581, "url": "https://patchwork.libcamera.org/api/patches/2581/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2581/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200112005442.2607343-1-niklas.soderlund@ragnatech.se>", "date": "2020-01-12T00:54:42", "name": "[libcamera-devel,v2] libcamera: ipa_interface: Document the ownership of dmabufs passed to map_buffers()", "commit_ref": "4b9bd6c3ad94c617ac00a71d2e1ef33648afc99f", "pull_url": null, "state": "accepted", "archived": false, "hash": "1079af961fac5ac0c84446e3a711e7acce3cf7e2", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2581/mbox/", "series": [ { "id": 616, "url": "https://patchwork.libcamera.org/api/series/616/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=616", "date": "2020-01-12T00:54:42", "name": "[libcamera-devel,v2] libcamera: ipa_interface: Document the ownership of dmabufs passed to map_buffers()", "version": 2, "mbox": "https://patchwork.libcamera.org/series/616/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2581/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2581/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F03856045B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 12 Jan 2020 01:54:49 +0100 (CET)", "from bismarck.berto.se (p54ac5d7b.dip0.t-ipconnect.de\n\t[84.172.93.123]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 1f227392-34d6-11ea-a00b-005056917a89;\n\tSun, 12 Jan 2020 01:54:48 +0100 (CET)" ], "X-Halon-ID": "1f227392-34d6-11ea-a00b-005056917a89", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 12 Jan 2020 01:54:42 +0100", "Message-Id": "<20200112005442.2607343-1-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.24.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2] libcamera: ipa_interface: Document the\n\townership of dmabufs passed to map_buffers()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sun, 12 Jan 2020 00:54:50 -0000" }, "content": "The ownership of the dmabuf file handles passed to map_buffers() is not\nclear. Explicitly document that they are borrowed from the callee and\nonly guaranteed to be valid for the duration of the map_buffers() call.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/ipa_interface.cpp | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/src/libcamera/ipa_interface.cpp b/src/libcamera/ipa_interface.cpp\nindex ee3e3622f39ae85f..5ca8000a253f5435 100644\n--- a/src/libcamera/ipa_interface.cpp\n+++ b/src/libcamera/ipa_interface.cpp\n@@ -258,6 +258,11 @@\n * \\param[in] buffers The buffers to map\n * \\param[in] num_buffers The number of entries in the \\a buffers array\n *\n+ * The dmabuf file descriptors provided in \\a buffers are borrowed from the\n+ * caller and are only guaranteed to be valid during the map_buffers() call.\n+ * Should the callee need to store a copy of the file descriptors, it shall\n+ * duplicate them first with ::dup().\n+ *\n * \\sa libcamera::IPAInterface::mapBuffers()\n */\n \n", "prefixes": [ "libcamera-devel", "v2" ] }