Patch Detail
Show a patch.
GET /api/patches/25767/?format=api
{ "id": 25767, "url": "https://patchwork.libcamera.org/api/patches/25767/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25767/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260114113016.25162-3-mzamazal@redhat.com>", "date": "2026-01-14T11:30:04", "name": "[v3,02/14] libcamera: ipa: simple: Unwrap IPAFrameContext::ccm", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "7ac9c86f8826622fd9d9726c3b5a09cd420c8bbd", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25767/mbox/", "series": [ { "id": 5706, "url": "https://patchwork.libcamera.org/api/series/5706/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5706", "date": "2026-01-14T11:30:02", "name": "Simple pipeline IPA cleanup", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5706/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25767/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25767/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 41C85C3226\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 14 Jan 2026 11:30:48 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E962961FC0;\n\tWed, 14 Jan 2026 12:30:47 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 941BF61FB9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 14 Jan 2026 12:30:45 +0100 (CET)", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-564-HaiHmLmONdaFUQD5sIwKPg-1;\n\tWed, 14 Jan 2026 06:30:41 -0500", "from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.93])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 07439180044D; Wed, 14 Jan 2026 11:30:40 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.217])\n\tby mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 1614218004D8; Wed, 14 Jan 2026 11:30:37 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"iFdWxJal\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1768390244;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=ecGQpeqL+0q1o7SA6sjZ4G4MfTbDuFJ/73Hvra+WDYc=;\n\tb=iFdWxJalo/Mcf8q+cCfY8lC+zwKvZ9S3V3RNnoYx8mmPvXvza17SrS3lcqxjrcXIpBV5ua\n\tSCPWfu+qRP/cWavEgWRVBtShhPnQI+Uk66tIn5kolt7e6X2QDLidmO9/xGDumz0h1ORgX6\n\totRnKt2WzKNGY6aSqzS/iLxKjMMJmFA=", "X-MC-Unique": "HaiHmLmONdaFUQD5sIwKPg-1", "X-Mimecast-MFC-AGG-ID": "HaiHmLmONdaFUQD5sIwKPg_1768390240", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t<barnabas.pocze@ideasonboard.com>", "Subject": "[PATCH v3 02/14] libcamera: ipa: simple: Unwrap IPAFrameContext::ccm", "Date": "Wed, 14 Jan 2026 12:30:04 +0100", "Message-ID": "<20260114113016.25162-3-mzamazal@redhat.com>", "In-Reply-To": "<20260114113016.25162-1-mzamazal@redhat.com>", "References": "<20260114113016.25162-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.93", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "HTt8XBhPImg0-a7jwsIz493zKa8tN48QW-TzQaWLnIM_1768390240", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The struct has only one member and there is no immediate need to add\nmore. Let's use the member directly, to make things a bit simpler.\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/ipa/simple/algorithms/ccm.cpp | 6 +++---\n src/ipa/simple/ipa_context.h | 4 +---\n 2 files changed, 4 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/ipa/simple/algorithms/ccm.cpp b/src/ipa/simple/algorithms/ccm.cpp\nindex 0a98406c1..d7d3dda76 100644\n--- a/src/ipa/simple/algorithms/ccm.cpp\n+++ b/src/ipa/simple/algorithms/ccm.cpp\n@@ -94,7 +94,7 @@ void Ccm::prepare(IPAContext &context, const uint32_t frame,\n \tif (frame > 0 &&\n \t utils::abs_diff(ct, lastCt_) < kTemperatureThreshold &&\n \t saturation == lastSaturation_) {\n-\t\tframeContext.ccm.ccm = context.activeState.ccm.ccm;\n+\t\tframeContext.ccm = context.activeState.ccm.ccm;\n \t\tcontext.activeState.ccm.changed = false;\n \t\treturn;\n \t}\n@@ -106,9 +106,9 @@ void Ccm::prepare(IPAContext &context, const uint32_t frame,\n \t\tapplySaturation(ccm, saturation.value());\n \n \tcontext.activeState.ccm.ccm = ccm;\n-\tframeContext.ccm.ccm = ccm;\n \tframeContext.saturation = saturation;\n \tcontext.activeState.ccm.changed = true;\n+\tframeContext.ccm = ccm;\n }\n \n void Ccm::process([[maybe_unused]] IPAContext &context,\n@@ -117,7 +117,7 @@ void Ccm::process([[maybe_unused]] IPAContext &context,\n \t\t [[maybe_unused]] const SwIspStats *stats,\n \t\t ControlList &metadata)\n {\n-\tmetadata.set(controls::ColourCorrectionMatrix, frameContext.ccm.ccm.data());\n+\tmetadata.set(controls::ColourCorrectionMatrix, frameContext.ccm.data());\n \n \tconst auto &saturation = frameContext.saturation;\n \tmetadata.set(controls::Saturation, saturation.value_or(1.0));\ndiff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\nindex 26db92e93..74e77c841 100644\n--- a/src/ipa/simple/ipa_context.h\n+++ b/src/ipa/simple/ipa_context.h\n@@ -75,9 +75,7 @@ struct IPAActiveState {\n };\n \n struct IPAFrameContext : public FrameContext {\n-\tstruct {\n-\t\tMatrix<float, 3, 3> ccm;\n-\t} ccm;\n+\tMatrix<float, 3, 3> ccm;\n \n \tstruct {\n \t\tint32_t exposure;\n", "prefixes": [ "v3", "02/14" ] }