Patch Detail
Show a patch.
GET /api/patches/25759/?format=api
{ "id": 25759, "url": "https://patchwork.libcamera.org/api/patches/25759/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25759/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260113174642.1185403-3-rui.wang@ideasonboard.com>", "date": "2026-01-13T17:46:38", "name": "[v7,2/6] ipa: rkisp1: algorithms: dpf: Implement mode switching", "commit_ref": null, "pull_url": null, "state": "deferred", "archived": false, "hash": "e199d8ec375727e8e1507c7d33c8e29ef3105d86", "submitter": { "id": 241, "url": "https://patchwork.libcamera.org/api/people/241/?format=api", "name": "Rui Wang", "email": "rui.wang@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25759/mbox/", "series": [ { "id": 5704, "url": "https://patchwork.libcamera.org/api/series/5704/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5704", "date": "2026-01-13T17:46:36", "name": "refactor DPF parsing and initialization", "version": 7, "mbox": "https://patchwork.libcamera.org/series/5704/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25759/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25759/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5DE0EBE08B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 13 Jan 2026 17:47:48 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 151D761FB7;\n\tTue, 13 Jan 2026 18:47:48 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BEE9261FA3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Jan 2026 18:47:46 +0100 (CET)", "from rui-Precision-7560.local (unknown [209.216.103.65])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 426B2316;\n\tTue, 13 Jan 2026 18:47:20 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"a5bDWbCV\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768326440;\n\tbh=A12X4Fch+8Xgm3KBzCs7stO84Has9InLl5G4Goa8Pcg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=a5bDWbCV5yrgyHSHQpfRfvQhDeNVBbjbeJxJJxfp+tLhx0jrgxEVML9ZD3QdSjyqt\n\tTb1F6EPGSkkkYgnCn93bG7xsNHE3TpPXo/D1+KyFocWHv7ufbxIkcHO2TR+53MM3of\n\tGMhKGoamRzMrhg0f0zGvmrgEUa7oa6b7Xifeeawg=", "From": "Rui Wang <rui.wang@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Rui Wang <rui.wang@ideasonboard.com>,\n\tJacopo Mondi <jacopo.mondi@ideasonboard.com>", "Subject": "[PATCH v7 2/6] ipa: rkisp1: algorithms: dpf: Implement mode\n\tswitching", "Date": "Tue, 13 Jan 2026 12:46:38 -0500", "Message-ID": "<20260113174642.1185403-3-rui.wang@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260113174642.1185403-1-rui.wang@ideasonboard.com>", "References": "<20260113174642.1185403-1-rui.wang@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add support for switching between different noise reduction modes.\n\nIntroduce `noiseReductionModes_` to store mode-specific configs.\n\nLoadReductionConfig() select specific config from configs.\n\nSigned-off-by: Rui Wang <rui.wang@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n\n---\nchangelog since v5:\n - Update log verbos from Info to Debug in loadReductionConfig\n - Update log mode value to string to in loadReductionConfig\n - improving the return value changed like :\n if (ret != 0) -> if (ret)\n\n Reviewed-by tags from v5 are carried over (no function changes).\nchangelog since v6:\n - add { controls::draft::NoiseReductionModeOff, \"off\" }, to fix\n out_of_range issue\n---\n src/ipa/rkisp1/algorithms/dpf.cpp | 87 +++++++++++++++++++++++++++++--\n src/ipa/rkisp1/algorithms/dpf.h | 11 ++++\n 2 files changed, 93 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\nindex dd3effa1..3cab1f6b 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.cpp\n+++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n@@ -8,6 +8,7 @@\n #include \"dpf.h\"\n \n #include <algorithm>\n+#include <map>\n #include <string>\n #include <vector>\n \n@@ -36,8 +37,21 @@ namespace ipa::rkisp1::algorithms {\n \n LOG_DEFINE_CATEGORY(RkISP1Dpf)\n \n+namespace {\n+\n+const std::map<int32_t, std::string> kModesMap = {\n+\t{ controls::draft::NoiseReductionModeMinimal, \"minimal\" },\n+\t{ controls::draft::NoiseReductionModeFast, \"fast\" },\n+\t{ controls::draft::NoiseReductionModeHighQuality, \"highquality\" },\n+\t{ controls::draft::NoiseReductionModeZSL, \"zsl\" },\n+\t{ controls::draft::NoiseReductionModeOff, \"off\" },\n+};\n+\n+} /* namespace */\n+\n Dpf::Dpf()\n-\t: config_({}), strengthConfig_({})\n+\t: config_({}), strengthConfig_({}), noiseReductionModes_({}),\n+\t runningMode_(controls::draft::NoiseReductionModeOff)\n {\n }\n \n@@ -62,6 +76,44 @@ int Dpf::parseConfig(const YamlObject &tuningData)\n \tif (ret)\n \t\treturn ret;\n \n+\t/* Parse modes. */\n+\treturn parseModes(tuningData);\n+}\n+\n+int Dpf::parseModes(const YamlObject &tuningData)\n+{\n+\t/* Parse noise reduction modes. */\n+\tif (!tuningData.contains(\"modes\"))\n+\t\treturn -EINVAL;\n+\n+\tnoiseReductionModes_.clear();\n+\tfor (const auto &entry : tuningData[\"modes\"].asList()) {\n+\t\tstd::optional<std::string> typeOpt =\n+\t\t\tentry[\"type\"].get<std::string>();\n+\t\tif (!typeOpt) {\n+\t\t\tLOG(RkISP1Dpf, Error) << \"Modes entry missing type\";\n+\t\t\treturn -EINVAL;\n+\t\t}\n+\n+\t\tModeConfig mode;\n+\t\tauto it = std::find_if(kModesMap.begin(), kModesMap.end(),\n+\t\t\t\t [&typeOpt](const auto &pair) {\n+\t\t\t\t\t return pair.second == *typeOpt;\n+\t\t\t\t });\n+\n+\t\tif (it == kModesMap.end()) {\n+\t\t\tLOG(RkISP1Dpf, Error) << \"Unknown mode type: \" << *typeOpt;\n+\t\t\treturn -EINVAL;\n+\t\t}\n+\n+\t\tmode.modeValue = it->first;\n+\t\tauto ret = parseSingleConfig(entry, mode.dpf, mode.strength);\n+\t\tif (ret)\n+\t\t\treturn ret;\n+\n+\t\tnoiseReductionModes_.push_back(mode);\n+\t}\n+\n \treturn 0;\n }\n \n@@ -193,6 +245,28 @@ int Dpf::parseSingleConfig(const YamlObject &tuningData,\n \treturn 0;\n }\n \n+bool Dpf::loadReductionConfig(int32_t mode)\n+{\n+\tauto it = std::find_if(noiseReductionModes_.begin(), noiseReductionModes_.end(),\n+\t\t\t [mode](const ModeConfig &m) {\n+\t\t\t\t return m.modeValue == mode;\n+\t\t\t });\n+\tif (it == noiseReductionModes_.end()) {\n+\t\tLOG(RkISP1Dpf, Warning)\n+\t\t\t<< \"No DPF config for reduction mode: \" << kModesMap.at(mode);\n+\t\treturn false;\n+\t}\n+\n+\tconfig_ = it->dpf;\n+\tstrengthConfig_ = it->strength;\n+\n+\tLOG(RkISP1Dpf, Debug)\n+\t\t<< \"DPF mode=Reduction (config loaded)\"\n+\t\t<< \" mode=\" << kModesMap.at(mode);\n+\n+\treturn true;\n+}\n+\n /**\n * \\copydoc libcamera::ipa::Algorithm::queueRequest\n */\n@@ -206,8 +280,6 @@ void Dpf::queueRequest(IPAContext &context,\n \n \tconst auto &denoise = controls.get(controls::draft::NoiseReductionMode);\n \tif (denoise) {\n-\t\tLOG(RkISP1Dpf, Debug) << \"Set denoise to \" << *denoise;\n-\n \t\tswitch (*denoise) {\n \t\tcase controls::draft::NoiseReductionModeOff:\n \t\t\tif (dpf.denoise) {\n@@ -218,9 +290,10 @@ void Dpf::queueRequest(IPAContext &context,\n \t\tcase controls::draft::NoiseReductionModeMinimal:\n \t\tcase controls::draft::NoiseReductionModeHighQuality:\n \t\tcase controls::draft::NoiseReductionModeFast:\n-\t\t\tif (!dpf.denoise) {\n-\t\t\t\tdpf.denoise = true;\n+\t\tcase controls::draft::NoiseReductionModeZSL:\n+\t\t\tif (loadReductionConfig(*denoise)) {\n \t\t\t\tupdate = true;\n+\t\t\t\tdpf.denoise = true;\n \t\t\t}\n \t\t\tbreak;\n \t\tdefault:\n@@ -229,6 +302,10 @@ void Dpf::queueRequest(IPAContext &context,\n \t\t\t\t<< *denoise;\n \t\t\tbreak;\n \t\t}\n+\t\tif (update) {\n+\t\t\trunningMode_ = *denoise;\n+\t\t\tLOG(RkISP1Dpf, Debug) << \"Set denoise to \" << kModesMap.at(runningMode_);\n+\t\t}\n \t}\n \n \tframeContext.dpf.denoise = dpf.denoise;\ndiff --git a/src/ipa/rkisp1/algorithms/dpf.h b/src/ipa/rkisp1/algorithms/dpf.h\nindex 39186c55..2a2c7052 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.h\n+++ b/src/ipa/rkisp1/algorithms/dpf.h\n@@ -30,13 +30,24 @@ public:\n \t\t RkISP1Params *params) override;\n \n private:\n+\tstruct ModeConfig {\n+\t\tint32_t modeValue;\n+\t\trkisp1_cif_isp_dpf_config dpf;\n+\t\trkisp1_cif_isp_dpf_strength_config strength;\n+\t};\n+\n \tint parseConfig(const YamlObject &tuningData);\n+\tint parseModes(const YamlObject &tuningData);\n \tint parseSingleConfig(const YamlObject &tuningData,\n \t\t\t rkisp1_cif_isp_dpf_config &config,\n \t\t\t rkisp1_cif_isp_dpf_strength_config &strengthConfig);\n \n+\tbool loadReductionConfig(int32_t mode);\n+\n \tstruct rkisp1_cif_isp_dpf_config config_;\n \tstruct rkisp1_cif_isp_dpf_strength_config strengthConfig_;\n+\tstd::vector<ModeConfig> noiseReductionModes_;\n+\tint32_t runningMode_;\n };\n \n } /* namespace ipa::rkisp1::algorithms */\n", "prefixes": [ "v7", "2/6" ] }