Patch Detail
Show a patch.
GET /api/patches/25745/?format=api
{ "id": 25745, "url": "https://patchwork.libcamera.org/api/patches/25745/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25745/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260113000808.15395-26-laurent.pinchart@ideasonboard.com>", "date": "2026-01-13T00:07:57", "name": "[25/36] libcamera: value_node: Add constructor with value", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d02ef3bc980e4076b3ab82d1fa3ea5e20d356627", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25745/mbox/", "series": [ { "id": 5703, "url": "https://patchwork.libcamera.org/api/series/5703/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5703", "date": "2026-01-13T00:07:32", "name": "libcamera: Global configuration file improvements", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5703/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25745/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25745/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 94DE6C323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 13 Jan 2026 00:09:13 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5286261FD9;\n\tTue, 13 Jan 2026 01:09:13 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 07ACD62006\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Jan 2026 01:09:11 +0100 (CET)", "from pendragon.ideasonboard.com (81-175-209-152.bb.dnainternet.fi\n\t[81.175.209.152])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 51FC866B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Jan 2026 01:08:45 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"C7FFapPo\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768262925;\n\tbh=cIzixro/MPWtfKkZikxXAehRwwzE4X4fcRkdRO8pZFQ=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=C7FFapPoY3WsVgC1N7a/5P6TzwFixFJ3qogetpl14PE7rXmfDURooY9vKwZfuqOXD\n\tzSBB9PRPb0auqXUVh8HOf6tMsu0zlfjri4s1aKJXzy12FEza8QUF9AIezQsGGzDZXb\n\tUPN/FrO4q128UNbMfMMMCvG58yEWQ0pQroZd88K0=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH 25/36] libcamera: value_node: Add constructor with value", "Date": "Tue, 13 Jan 2026 02:07:57 +0200", "Message-ID": "<20260113000808.15395-26-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.51.2", "In-Reply-To": "<20260113000808.15395-1-laurent.pinchart@ideasonboard.com>", "References": "<20260113000808.15395-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The new constructor takes a value, allowing creation of a leaf ValueNode\nwith a value in a single operation instead of having to call set() on an\nempty node.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/internal/value_node.h | 7 +++++++\n src/libcamera/value_node.cpp | 7 +++++++\n 2 files changed, 14 insertions(+)", "diff": "diff --git a/include/libcamera/internal/value_node.h b/include/libcamera/internal/value_node.h\nindex a336c1d08e1c..eb509d855810 100644\n--- a/include/libcamera/internal/value_node.h\n+++ b/include/libcamera/internal/value_node.h\n@@ -143,6 +143,13 @@ public:\n #endif /* __DOXYGEN__ */\n \n \tValueNode();\n+\n+\ttemplate<typename T>\n+\tValueNode(T &&value)\n+\t{\n+\t\tset(std::forward<T>(value));\n+\t}\n+\n \t~ValueNode();\n \n \tbool isValue() const\ndiff --git a/src/libcamera/value_node.cpp b/src/libcamera/value_node.cpp\nindex 7374e7bdde8c..b8f0c6d5cbc4 100644\n--- a/src/libcamera/value_node.cpp\n+++ b/src/libcamera/value_node.cpp\n@@ -44,6 +44,13 @@ ValueNode::ValueNode()\n {\n }\n \n+/**\n+ * \\fn template<typename T> ValueNode::ValueNode(T &&value)\n+ * \\brief Construct a ValueNode instance with a value\n+ * \\tparam T Type of the value\n+ * \\param[in] value The value\n+ */\n+\n ValueNode::~ValueNode() = default;\n \n /**\n", "prefixes": [ "25/36" ] }