Patch Detail
Show a patch.
GET /api/patches/25728/?format=api
{ "id": 25728, "url": "https://patchwork.libcamera.org/api/patches/25728/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25728/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260113000808.15395-9-laurent.pinchart@ideasonboard.com>", "date": "2026-01-13T00:07:40", "name": "[08/36] libcamera: yaml_parser: Use std::make_unique<>", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "5fdb345427c65c483d8dbc41666e4455b47a83e6", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25728/mbox/", "series": [ { "id": 5703, "url": "https://patchwork.libcamera.org/api/series/5703/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5703", "date": "2026-01-13T00:07:32", "name": "libcamera: Global configuration file improvements", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5703/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25728/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25728/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C3A2BC323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 13 Jan 2026 00:08:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 88B8961FC0;\n\tTue, 13 Jan 2026 01:08:44 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E362C61FD1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Jan 2026 01:08:41 +0100 (CET)", "from pendragon.ideasonboard.com (81-175-209-152.bb.dnainternet.fi\n\t[81.175.209.152])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 45633E01\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Jan 2026 01:08:16 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jXFvQqbM\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768262896;\n\tbh=XrvDDRv/7jQlnsUcCK0ZaJ1JLjqiX8XSetkAn/MSpfw=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=jXFvQqbMrks28Di+LZYrLnMp6K2Yov2RAbsewetBy5ZNG6BijleBgWFkBfoROpaAF\n\tLhtWT42rPC93iPtDJJqwCx2r2Rl3eiyeO2FhG5RAEdQ3IQ33+2MSssiVE7EzNOr98I\n\taTShsM/9eJ9EAQ0/c2CWoWzMvTDTt+CaqZ4iMWjI=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH 08/36] libcamera: yaml_parser: Use std::make_unique<>", "Date": "Tue, 13 Jan 2026 02:07:40 +0200", "Message-ID": "<20260113000808.15395-9-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.51.2", "In-Reply-To": "<20260113000808.15395-1-laurent.pinchart@ideasonboard.com>", "References": "<20260113000808.15395-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The YamlParser::parse() function constructs a std::unique_ptr<> instance\nwith a manual call to operator new. Replace it with std::make_unique<>.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/yaml_parser.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/yaml_parser.cpp b/src/libcamera/yaml_parser.cpp\nindex a5e424615c26..72580e901ddd 100644\n--- a/src/libcamera/yaml_parser.cpp\n+++ b/src/libcamera/yaml_parser.cpp\n@@ -769,7 +769,7 @@ std::unique_ptr<YamlObject> YamlParser::parse(File &file)\n \tif (context.init(file))\n \t\treturn nullptr;\n \n-\tstd::unique_ptr<YamlObject> root(new YamlObject());\n+\tstd::unique_ptr<YamlObject> root = std::make_unique<YamlObject>();\n \n \tif (context.parseContent(*root)) {\n \t\tLOG(YamlParser, Error)\n", "prefixes": [ "08/36" ] }