Patch Detail
Show a patch.
GET /api/patches/25725/?format=api
{ "id": 25725, "url": "https://patchwork.libcamera.org/api/patches/25725/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25725/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260113000808.15395-6-laurent.pinchart@ideasonboard.com>", "date": "2026-01-13T00:07:37", "name": "[05/36] test: ipa: ipa_interface: Use IPAManager::createIPA()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "24e374bd9356481f075d57dbd8f0ce04a002bedc", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25725/mbox/", "series": [ { "id": 5703, "url": "https://patchwork.libcamera.org/api/series/5703/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5703", "date": "2026-01-13T00:07:32", "name": "libcamera: Global configuration file improvements", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5703/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25725/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25725/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D7F66BDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 13 Jan 2026 00:08:40 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 98A8161FC8;\n\tTue, 13 Jan 2026 01:08:40 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 737AE61FBC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Jan 2026 01:08:37 +0100 (CET)", "from pendragon.ideasonboard.com (81-175-209-152.bb.dnainternet.fi\n\t[81.175.209.152])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id CB3BABCA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Jan 2026 01:08:11 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tU2gSDhA\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768262891;\n\tbh=XSnOQ+wvfNYabmcowHyySKCq4yHGxSaKkoTmkcm2RG4=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=tU2gSDhAgdNRVbx0MWPMlDlgDzfoRJLOl8ODQsTlXm/nJuRsHbAH2+wErVBWm3YQE\n\tYc5U7NJmE7ocx37hn6UncDz4tbOxd3tMSc+dWL6bAIADULXjd7k+DCv88Rtg3Yiokr\n\tfVMLSmYZDQ0RKSHWHpgOBJJmPC1pYTsDshibSZmc=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH 05/36] test: ipa: ipa_interface: Use IPAManager::createIPA()", "Date": "Tue, 13 Jan 2026 02:07:37 +0200", "Message-ID": "<20260113000808.15395-6-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.51.2", "In-Reply-To": "<20260113000808.15395-1-laurent.pinchart@ideasonboard.com>", "References": "<20260113000808.15395-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The goal of ipa_interface is to unit test the IPA interface. It\ncurrently creates the IPA proxy through the higher level PipelineHandler\nclass. Use the IPAManager::createIPA() function instead to keep the\nfocus on the components that were meant to be tested.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/ipa/ipa_interface_test.cpp | 12 +++++++++++-\n 1 file changed, 11 insertions(+), 1 deletion(-)\n\n--\nRegards,\n\nLaurent Pinchart", "diff": "diff --git a/test/ipa/ipa_interface_test.cpp b/test/ipa/ipa_interface_test.cpp\nindex ccff6ac106c8..41ef81721bfa 100644\n--- a/test/ipa/ipa_interface_test.cpp\n+++ b/test/ipa/ipa_interface_test.cpp\n@@ -22,6 +22,8 @@\n\n #include \"libcamera/internal/camera_manager.h\"\n #include \"libcamera/internal/device_enumerator.h\"\n+#include \"libcamera/internal/global_configuration.h\"\n+#include \"libcamera/internal/ipa_manager.h\"\n #include \"libcamera/internal/ipa_module.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n\n@@ -43,6 +45,8 @@ public:\n \t{\n \t\tdelete notifier_;\n \t\tipa_.reset();\n+\t\tipaManager_.reset();\n+\t\tconfig_.reset();\n \t\tcameraManager_.reset();\n \t}\n\n@@ -90,6 +94,10 @@ protected:\n \t\tnotifier_ = new EventNotifier(fd_, EventNotifier::Read, this);\n \t\tnotifier_->activated.connect(this, &IPAInterfaceTest::readTrace);\n\n+\t\t/* Create the IPA manager. */\n+\t\tconfig_ = std::make_unique<GlobalConfiguration>();\n+\t\tipaManager_ = std::make_unique<IPAManager>(*config_);\n+\n \t\treturn TestPass;\n \t}\n\n@@ -98,7 +106,7 @@ protected:\n \t\tEventDispatcher *dispatcher = thread()->eventDispatcher();\n \t\tTimer timer;\n\n-\t\tipa_ = pipe_->createIPA<ipa::vimc::IPAProxyVimc>(0, 0);\n+\t\tipa_ = ipaManager_->createIPA<ipa::vimc::IPAProxyVimc>(pipe_.get(), 0, 0);\n \t\tif (!ipa_) {\n \t\t\tcerr << \"Failed to create VIMC IPA interface\" << endl;\n \t\t\treturn TestFail;\n@@ -173,6 +181,8 @@ private:\n \tstd::shared_ptr<PipelineHandler> pipe_;\n \tstd::unique_ptr<ipa::vimc::IPAProxyVimc> ipa_;\n \tstd::unique_ptr<CameraManager> cameraManager_;\n+\tstd::unique_ptr<GlobalConfiguration> config_;\n+\tstd::unique_ptr<IPAManager> ipaManager_;\n \tenum ipa::vimc::IPAOperationCode trace_;\n \tEventNotifier *notifier_;\n \tint fd_;\n", "prefixes": [ "05/36" ] }