Patch Detail
Show a patch.
GET /api/patches/25716/?format=api
{ "id": 25716, "url": "https://patchwork.libcamera.org/api/patches/25716/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25716/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260112103740.18360-2-robert.mader@collabora.com>", "date": "2026-01-12T10:37:37", "name": "[v2,1/4] egl: Remove unused functions", "commit_ref": "7c1527cd449e32769187d9d85f28daef8c4de45f", "pull_url": null, "state": "accepted", "archived": false, "hash": "baf30219069c0b626ef5bcec8d53d9bb4cae5942", "submitter": { "id": 140, "url": "https://patchwork.libcamera.org/api/people/140/?format=api", "name": "Robert Mader", "email": "robert.mader@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25716/mbox/", "series": [ { "id": 5702, "url": "https://patchwork.libcamera.org/api/series/5702/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5702", "date": "2026-01-12T10:37:36", "name": "GPUISP cleanups", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5702/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25716/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25716/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8997BBE08B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 12 Jan 2026 10:38:15 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3E39961F9F;\n\tMon, 12 Jan 2026 11:38:15 +0100 (CET)", "from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n\t[136.143.188.112])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4605661FB9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 12 Jan 2026 11:38:13 +0100 (CET)", "by mx.zohomail.com with SMTPS id 1768214288630581.9036033215984;\n\tMon, 12 Jan 2026 02:38:08 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"bnDdxcYE\"; \n\tdkim-atps=neutral", "ARC-Seal": "i=1; a=rsa-sha256; t=1768214289; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=YmOUmBlGGquCYLpFlggSFVzI3tJxfLcmse7Mwr3DwU9/tp9WfF1MBmggID/RnfxMb+7tvWre82jHTFgI+90SNN8krTh4g2EdIEFrs2L8ldsjJ9vWeKRE99ToN6N4YLyqiJK+O68PHZud3wqjZlmbfnKtqWeP1XglW/7d10UIETU=", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1768214289;\n\th=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=BwS+eZTULx2YfKTG/rTEgrLDyh8KbB652xIKkKPgweE=; \n\tb=VMMsP/ZoGO3JlFaafG9bJprJQRvYs2iTrXdDLWxFPzoMp7aEFljsybDe7n29uIZnocQXHris0bpGGdg1mNH5izCkmWVAByWYzCl1/PiGIjStJl9u2XrM4cUMX+Almsn7VFlYMd50664sgZmMbtH4EMNDBDm3HcQ+i30iTr/3dN8=", "ARC-Authentication-Results": "i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=<robert.mader@collabora.com>", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1768214289;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=BwS+eZTULx2YfKTG/rTEgrLDyh8KbB652xIKkKPgweE=;\n\tb=bnDdxcYEag1r0S3ka9UVWtpcKRVsJkB5FS6ktm43EXEks/ZHeiFskFq4Nrq94JsK\n\tSJ+VmSKcDdrRlFx2aN3McW2j0ba/kHNir7qhEs+lNTpuVACKFiZEGYqSrRBhWPIlY4W\n\tsd0LF6aKyURkov4thQ3D3eKwjqOWERDlWZ3HaoV4=", "From": "Robert Mader <robert.mader@collabora.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Robert Mader <robert.mader@collabora.com>, Hans de Goede\n\t<johannes.goede@oss.qualcomm.com>, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t<barnabas.pocze@ideasonboard.com>", "Subject": "[PATCH v2 1/4] egl: Remove unused functions", "Date": "Mon, 12 Jan 2026 11:37:37 +0100", "Message-ID": "<20260112103740.18360-2-robert.mader@collabora.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260112103740.18360-1-robert.mader@collabora.com>", "References": "<20260112103740.18360-1-robert.mader@collabora.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "They are left-overs from older iterations of the GPU-ISP.\n\nSigned-off-by: Robert Mader <robert.mader@collabora.com>\nReviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n include/libcamera/internal/egl.h | 10 ----------\n src/libcamera/egl.cpp | 10 ----------\n src/libcamera/software_isp/debayer_egl.cpp | 2 --\n 3 files changed, 22 deletions(-)", "diff": "diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\nindex a92921123..7b810773c 100644\n--- a/include/libcamera/internal/egl.h\n+++ b/include/libcamera/internal/egl.h\n@@ -64,15 +64,6 @@ public:\n \t\tglGenFramebuffers(1, &fbo_);\n \t}\n \n-\t/**\n-\t * \\brief Construct an eGLImage with automatic stride calculation\n-\t */\n-\teGLImage(uint32_t width, uint32_t height, uint32_t bpp, GLenum texture_unit, uint32_t texture_unit_uniform_id)\n-\t\t: eGLImage(width, height, bpp, utils::alignUp(width * bpp / 8, 256),\n-\t\t\t texture_unit, texture_unit_uniform_id)\n-\t{\n-\t}\n-\n \t/**\n \t * \\brief Destroy the eGLImage\n \t *\n@@ -108,7 +99,6 @@ public:\n \t~eGL();\n \n \tint initEGLContext(GBM *gbmContext);\n-\tvoid cleanUp();\n \n \tint createInputDMABufTexture2D(eGLImage &eglImage, int fd);\n \tint createOutputDMABufTexture2D(eGLImage &eglImage, int fd);\ndiff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\nindex 0544056bd..fcaf7c58f 100644\n--- a/src/libcamera/egl.cpp\n+++ b/src/libcamera/egl.cpp\n@@ -349,16 +349,6 @@ fail:\n \treturn -ENODEV;\n }\n \n-/**\n- * \\brief Clean up EGL resources\n- *\n- * Destroys the EGL sync object. Must be called from the same thread\n- * that created the EGL context.\n- */\n-void eGL::cleanUp()\n-{\n-}\n-\n /**\n * \\brief Make the EGL context current for the calling thread\n *\ndiff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\nindex 8e0890323..1c13b72a5 100644\n--- a/src/libcamera/software_isp/debayer_egl.cpp\n+++ b/src/libcamera/software_isp/debayer_egl.cpp\n@@ -615,8 +615,6 @@ void DebayerEGL::stop()\n \n \tif (programId_)\n \t\tglDeleteProgram(programId_);\n-\n-\tegl_.cleanUp();\n }\n \n SizeRange DebayerEGL::sizes(PixelFormat inputFormat, const Size &inputSize)\n", "prefixes": [ "v2", "1/4" ] }