Patch Detail
Show a patch.
GET /api/patches/25699/?format=api
{ "id": 25699, "url": "https://patchwork.libcamera.org/api/patches/25699/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25699/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260108-sklug-lsc-resampling-v2-dev-v2-9-e682ec4b9893@ideasonboard.com>", "date": "2026-01-08T16:05:52", "name": "[v2,09/15] ipa: rkisp1: lsc: Handle quantization locally", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "9901a35873ef4d88fddf9ff131cecf1e979f50ec", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25699/mbox/", "series": [ { "id": 5697, "url": "https://patchwork.libcamera.org/api/series/5697/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5697", "date": "2026-01-08T16:05:43", "name": "Add resampling support for polynomial LSC data", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5697/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25699/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25699/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B8D28BE08B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 8 Jan 2026 16:06:53 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 82AD661FC7;\n\tThu, 8 Jan 2026 17:06:53 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 63F8061FBF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 8 Jan 2026 17:06:52 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:90af:8957:b721:10d4])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id EACB51AEE; \n\tThu, 8 Jan 2026 17:06:29 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"K3UFe7u6\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1767888390;\n\tbh=Wa1kb4jis2WTXYoMAut+ajSXm5wP3og7A8V9teDjUgg=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=K3UFe7u6CRZlqSxOQRjGpoZABGD6eMghsqFI+VeUAMIuBVNkjsL8Q4fmGQFSRjZRl\n\tTqZXFtSlIGpYUXLHw1kNgEIfKdi6ROJFuLr+i3CsXSFDKQmvh0veARzoRzYrZBp2JM\n\tqYwELoJU7XAEz83kFAycxdMpVRMcyWMXl2ubiM/w=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "Date": "Thu, 08 Jan 2026 17:05:52 +0100", "Subject": "[PATCH v2 09/15] ipa: rkisp1: lsc: Handle quantization locally", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260108-sklug-lsc-resampling-v2-dev-v2-9-e682ec4b9893@ideasonboard.com>", "References": "<20260108-sklug-lsc-resampling-v2-dev-v2-0-e682ec4b9893@ideasonboard.com>", "In-Reply-To": "<20260108-sklug-lsc-resampling-v2-dev-v2-0-e682ec4b9893@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "X-Mailer": "b4 0.14.2", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The quantization functionality in the Interpolator hinders in writing\nnice code. Don't use it and implement the functionality directly in the\nalgorithm. This patch doesn't introduce any functional changes.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n\n---\n\nChanges in v2:\n- Added this patch\n---\n src/ipa/rkisp1/algorithms/lsc.cpp | 19 +++++++++++++------\n 1 file changed, 13 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\nindex c42f74557c7364935254d75ee1fb923d176e0dbd..d5e44021906bda22f16a2c0f2a344e4c40d46774 100644\n--- a/src/ipa/rkisp1/algorithms/lsc.cpp\n+++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n@@ -308,12 +308,16 @@ std::vector<double> parseSizes(const YamlObject &tuningData,\n \treturn sizes;\n }\n \n+static unsigned int quantize(unsigned int value, unsigned int step)\n+{\n+\treturn std::lround(value / static_cast<double>(step)) * step;\n+}\n+\n } /* namespace */\n \n LensShadingCorrection::LensShadingCorrection()\n \t: lastAppliedCt_(0), lastAppliedQuantizedCt_(0)\n {\n-\tsets_.setQuantization(kColourTemperatureChangeThreshhold);\n }\n \n /**\n@@ -426,17 +430,20 @@ void LensShadingCorrection::prepare([[maybe_unused]] IPAContext &context,\n \t\t\t\t RkISP1Params *params)\n {\n \tuint32_t ct = frameContext.awb.temperatureK;\n-\tif (std::abs(static_cast<int>(ct) - static_cast<int>(lastAppliedCt_)) <\n-\t kColourTemperatureChangeThreshhold)\n+\tunsigned int quantizedCt = quantize(ct, kColourTemperatureChangeThreshhold);\n+\tint ctDiff = static_cast<int>(ct) - static_cast<int>(lastAppliedCt_);\n+\n+\tif (quantizedCt == lastAppliedQuantizedCt_)\n \t\treturn;\n-\tunsigned int quantizedCt;\n-\tconst Components &set = sets_.getInterpolated(ct, &quantizedCt);\n-\tif (lastAppliedQuantizedCt_ == quantizedCt)\n+\n+\tif (std::abs(ctDiff) < kColourTemperatureChangeThreshhold)\n \t\treturn;\n \n \tauto config = params->block<BlockType::Lsc>();\n \tconfig.setEnabled(true);\n \tsetParameters(*config);\n+\n+\tconst Components &set = sets_.getInterpolated(quantizedCt);\n \tcopyTable(*config, set);\n \n \tlastAppliedCt_ = ct;\n", "prefixes": [ "v2", "09/15" ] }