Patch Detail
Show a patch.
GET /api/patches/25691/?format=api
{ "id": 25691, "url": "https://patchwork.libcamera.org/api/patches/25691/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25691/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260108-sklug-lsc-resampling-v2-dev-v2-1-e682ec4b9893@ideasonboard.com>", "date": "2026-01-08T16:05:44", "name": "[v2,01/15] ipa: rkisp1: lsc: Drop unused member variable", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "39d85ad1e3b9c1d40cca1731917279650380e2c9", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25691/mbox/", "series": [ { "id": 5697, "url": "https://patchwork.libcamera.org/api/series/5697/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5697", "date": "2026-01-08T16:05:43", "name": "Add resampling support for polynomial LSC data", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5697/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25691/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25691/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EBB65BE08B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 8 Jan 2026 16:06:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A141C61FC4;\n\tThu, 8 Jan 2026 17:06:29 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3EB28615B2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 8 Jan 2026 17:06:28 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:90af:8957:b721:10d4])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id C456E63B;\n\tThu, 8 Jan 2026 17:06:05 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pF/wRPCO\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1767888365;\n\tbh=OcEp1RGR9Yo43utM4YX0sN8zvzSy2va566Bm6G86NKo=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=pF/wRPCOHi3adzWL68FRfeVjCBCQ/5L0t2N45mA+ISozlYFxIFFDjD/tYSJsWE+v3\n\tPX/F/skfHhJLd5aJQQI9RZGiR0nGsytIjnGAlRXI5Mbvtr/m3thSXwjhVHy/7lgXWL\n\taJ4/yIFgicOPrKdmaaR0ZcaNQH4mczsIfzhUIGdI=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "Date": "Thu, 08 Jan 2026 17:05:44 +0100", "Subject": "[PATCH v2 01/15] ipa: rkisp1: lsc: Drop unused member variable", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260108-sklug-lsc-resampling-v2-dev-v2-1-e682ec4b9893@ideasonboard.com>", "References": "<20260108-sklug-lsc-resampling-v2-dev-v2-0-e682ec4b9893@ideasonboard.com>", "In-Reply-To": "<20260108-sklug-lsc-resampling-v2-dev-v2-0-e682ec4b9893@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P?=\n\t=?utf-8?b?xZFjemU=?= <barnabas.pocze@ideasonboard.com>,\n\tRui Wang <rui.wang@ideasonboard.com>", "X-Mailer": "b4 0.14.2", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The Components::ct member is not used anywhere. Drop it.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Rui Wang <rui.wang@ideasonboard.com>\n\n---\n\nChanges in v2:\n- Collected tags\n---\n src/ipa/rkisp1/algorithms/lsc.cpp | 2 --\n src/ipa/rkisp1/algorithms/lsc.h | 1 -\n 2 files changed, 3 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\nindex e7301bfec86393c4aad4e645800513d8c262e6f9..ab0ada4eed46bc3fdbce17377164a7fbfb321957 100644\n--- a/src/ipa/rkisp1/algorithms/lsc.cpp\n+++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n@@ -113,7 +113,6 @@ public:\n \t\t\t\treturn -EINVAL;\n \t\t\t}\n \n-\t\t\tset.ct = ct;\n \t\t\tpr->setReferenceImageSize(sensorSize_);\n \t\t\tpgr->setReferenceImageSize(sensorSize_);\n \t\t\tpgb->setReferenceImageSize(sensorSize_);\n@@ -221,7 +220,6 @@ public:\n \n \t\t\tLensShadingCorrection::Components &set = lscData[ct];\n \n-\t\t\tset.ct = ct;\n \t\t\tset.r = parseTable(yamlSet, \"r\");\n \t\t\tset.gr = parseTable(yamlSet, \"gr\");\n \t\t\tset.gb = parseTable(yamlSet, \"gb\");\ndiff --git a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h\nindex 5a0824e36dd5b45660514ce295fc2f42fdc4fa30..0e3745d5589c2ea94f63efbbb0eb51670cbc2793 100644\n--- a/src/ipa/rkisp1/algorithms/lsc.h\n+++ b/src/ipa/rkisp1/algorithms/lsc.h\n@@ -30,7 +30,6 @@ public:\n \t\t RkISP1Params *params) override;\n \n \tstruct Components {\n-\t\tuint32_t ct;\n \t\tstd::vector<uint16_t> r;\n \t\tstd::vector<uint16_t> gr;\n \t\tstd::vector<uint16_t> gb;\n", "prefixes": [ "v2", "01/15" ] }