Patch Detail
Show a patch.
GET /api/patches/25683/?format=api
{ "id": 25683, "url": "https://patchwork.libcamera.org/api/patches/25683/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25683/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260107193607.2168539-2-barnabas.pocze@ideasonboard.com>", "date": "2026-01-07T19:36:03", "name": "[RFC,v1,1/5] gstreamer: Add `-Wno-volatile` for GCC", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0e43282bf3b15c2296bfb1f2c5dc36c596c60960", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25683/mbox/", "series": [ { "id": 5694, "url": "https://patchwork.libcamera.org/api/series/5694/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5694", "date": "2026-01-07T19:36:02", "name": "C++20 migration", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5694/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25683/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25683/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E46EABDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 7 Jan 2026 19:36:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8043E61FBB;\n\tWed, 7 Jan 2026 20:36:16 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7BE1861FA0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 7 Jan 2026 20:36:13 +0100 (CET)", "from pb-laptop.local (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 906C21127;\n\tWed, 7 Jan 2026 20:35:51 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cOpMNq7/\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1767814551;\n\tbh=jf6DTaOQ1YuPzEP8CZJ2Aem6gnNitU8qUPalqNaCarY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=cOpMNq7/lAmUT8u3DLiNyFUDgD8/j9CO89QOPAwiuXc9SMoyp/p3Pm3pf9c1rtrOu\n\tACl8bwiet8IrwTRevMQ7fky/G6YMSBr4XG6eDsWRNFTVJyu+6j0bzPpmYzke4bGoc0\n\tU55o0ajXNmCCDnWenXwrHYedz+MY8LdgYA57rtYo=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Naushir Patuck <naush@raspberrypi.com>", "Subject": "[RFC PATCH v1 1/5] gstreamer: Add `-Wno-volatile` for GCC", "Date": "Wed, 7 Jan 2026 20:36:03 +0100", "Message-ID": "<20260107193607.2168539-2-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260107193607.2168539-1-barnabas.pocze@ideasonboard.com>", "References": "<20260107193607.2168539-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Older versions of glib may use `volatile` qualified variables, triggering\nthe warning in C++20. So suppress it.\n\nLink: https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1719\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/gstreamer/meson.build | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/src/gstreamer/meson.build b/src/gstreamer/meson.build\nindex fd83e073d..602f978e8 100644\n--- a/src/gstreamer/meson.build\n+++ b/src/gstreamer/meson.build\n@@ -50,6 +50,13 @@ if cc.get_id() == 'clang' and glib_dep.version().version_compare('<2.63.0')\n libcamera_gst_cpp_args += ['-Wno-unused-function']\n endif\n \n+# In C++20 many operations involving the `volatile` qualifier became deprecated.\n+# glib however made use of `volatile` in certain macros that would trigger\n+# this warning. See https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1719.\n+if cc.get_id() == 'gcc' and glib_dep.version().version_compare('<2.67.1')\n+ libcamera_gst_cpp_args += ['-Wno-volatile']\n+endif\n+\n libcamera_gst = shared_library('gstlibcamera',\n libcamera_gst_sources,\n cpp_args : libcamera_gst_cpp_args,\n", "prefixes": [ "RFC", "v1", "1/5" ] }