Patch Detail
Show a patch.
GET /api/patches/25679/?format=api
{ "id": 25679, "url": "https://patchwork.libcamera.org/api/patches/25679/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25679/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260107103830.1415267-1-paul.elder@ideasonboard.com>", "date": "2026-01-07T10:38:30", "name": "libcamera: control_serializer: Remove unnecessary allocation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d31b9f9fcd53d54e615da730f9d43c632e514ba6", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25679/mbox/", "series": [ { "id": 5691, "url": "https://patchwork.libcamera.org/api/series/5691/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5691", "date": "2026-01-07T10:38:30", "name": "libcamera: control_serializer: Remove unnecessary allocation", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5691/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25679/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25679/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 39E9EBDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 7 Jan 2026 10:38:46 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6124461FC1;\n\tWed, 7 Jan 2026 11:38:45 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0083D61F61\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 7 Jan 2026 11:38:43 +0100 (CET)", "from neptunite.hamster-moth.ts.net (unknown\n\t[IPv6:2404:7a81:160:2100:35ba:7791:4fab:f7ec])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4E65A593;\n\tWed, 7 Jan 2026 11:38:21 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dl7pjlfI\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1767782302;\n\tbh=QqUhxtvzYF4A72etfsIzm95fW3nWHqIFkGgeg1X1Qbk=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=dl7pjlfIAW7rgBam3WsX39pUVIPJSKW3fIIRn8D4/MxznQW15SH8d+63qpyYcnTPO\n\t48MY6enZagrntTVtYBZ6SoK4JCARwy8cKQ4sS+u/0ga/EfFXf5wEuIQdlnM0mpZRWQ\n\tzN407pgKHRZ9aC4JU80cmUhe3QDXDY849yv+/q3U=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Paul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH] libcamera: control_serializer: Remove unnecessary allocation", "Date": "Wed, 7 Jan 2026 19:38:30 +0900", "Message-ID": "<20260107103830.1415267-1-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.47.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In between versions of the patch \"libcamera: control_serializer: Add\narray info to serialized ControlValue\", ipa_control_value_entry was\nchanged to be members of ipa_control_info_entry as opposed to being\nserialized at the same level. The binarySize/entriesSize computation was\nnot updated, however, leaving some extra memory allocated for the\nserialized form of ControlInfoMap.\n\nFix this by removing the extra size for 3 * ipa_control_value_entry..\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/libcamera/control_serializer.cpp | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/libcamera/control_serializer.cpp b/src/libcamera/control_serializer.cpp\nindex 843e2772f848..8812e6e23d5a 100644\n--- a/src/libcamera/control_serializer.cpp\n+++ b/src/libcamera/control_serializer.cpp\n@@ -164,8 +164,7 @@ size_t ControlSerializer::binarySize(const ControlInfo &info)\n size_t ControlSerializer::binarySize(const ControlInfoMap &infoMap)\n {\n \tsize_t size = sizeof(struct ipa_controls_header)\n-\t\t + infoMap.size() * (sizeof(struct ipa_control_info_entry) +\n-\t\t\t\t\t3 * sizeof(struct ipa_control_value_entry));\n+\t\t + infoMap.size() * (sizeof(struct ipa_control_info_entry));\n \n \tfor (const auto &ctrl : infoMap)\n \t\tsize += binarySize(ctrl.second);\n@@ -234,8 +233,7 @@ int ControlSerializer::serialize(const ControlInfoMap &infoMap,\n \n \t/* Compute entries and data required sizes. */\n \tsize_t entriesSize = infoMap.size()\n-\t\t\t * (sizeof(struct ipa_control_info_entry) +\n-\t\t\t 3 * sizeof(struct ipa_control_value_entry));\n+\t\t\t * (sizeof(struct ipa_control_info_entry));\n \tsize_t valuesSize = 0;\n \tfor (const auto &ctrl : infoMap)\n \t\tvaluesSize += binarySize(ctrl.second);\n", "prefixes": [] }