Patch Detail
Show a patch.
GET /api/patches/25666/?format=api
{ "id": 25666, "url": "https://patchwork.libcamera.org/api/patches/25666/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25666/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260106170059.56193-14-bryan.odonoghue@linaro.org>", "date": "2026-01-06T17:00:48", "name": "[v11,13/24] libcamera: software_isp: Add member variables to track selected input/output pixelFormat", "commit_ref": "7e72e84f3d6a6fbef93f39f136a631a4de3868ab", "pull_url": null, "state": "accepted", "archived": false, "hash": "9106c70efb4f03583672baa81867a12f133e20d4", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25666/mbox/", "series": [ { "id": 5689, "url": "https://patchwork.libcamera.org/api/series/5689/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5689", "date": "2026-01-06T17:00:35", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 10, "mbox": "https://patchwork.libcamera.org/series/5689/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25666/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25666/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 130ACC3213\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 6 Jan 2026 17:01:23 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C4B0061FFC;\n\tTue, 6 Jan 2026 18:01:22 +0100 (CET)", "from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com\n\t[IPv6:2a00:1450:4864:20::42b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C969762011\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 6 Jan 2026 18:01:19 +0100 (CET)", "by mail-wr1-x42b.google.com with SMTP id\n\tffacd0b85a97d-42b3d7c1321so696871f8f.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 06 Jan 2026 09:01:19 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-432bd0dadcfsm5515322f8f.3.2026.01.06.09.01.17\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 06 Jan 2026 09:01:18 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"pekLfVdO\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1767718879; x=1768323679;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=qdq7BA4RV8ukinhniZlFu8ZUJ0DD8hbXSQeatSegKMQ=;\n\tb=pekLfVdOQuzhYRcpG5UUrscC3kzY2aOuymw7Pc3VG6u7/lQay8xo371puSyyY/2arG\n\tSiQqBJSL+KfhiIvbAC4Z3csoshNHledRs19Qi3qdNC2SawC3w1gypRuN1tQRGZljo00W\n\tZ8ejvp/tZ3jqHzDykS7GW3QSP1lLdjAsbwK/BP3YF84sAX1OP3MjgTjfmm00s/dsHNwE\n\tbqJyDGPo68t39VEHYXiV4eFeY3jh0zln5Db+WaIH6uDBnZBn6iIdT/s5Ard3I5bhxAPc\n\tQlLk+ppZe9zX//EVU52PLDEXypH2olIzUSG7MyR+jt/5xcIVrMRS1gqrDPl/X9khOFp8\n\tEmEg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1767718879; x=1768323679;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=qdq7BA4RV8ukinhniZlFu8ZUJ0DD8hbXSQeatSegKMQ=;\n\tb=rbQ4j+0oRh86LklxwZYU0NZe/KeKnmVsohKHJa0r9kz7JvH1rcpSmMhh7V9Cs9+xPr\n\t/R6s2k/uzvupvnpYZvaQFyovt2gyHzl35n6d4hTHRG1MZEiEt7nZt6GCZdPf85m5un9O\n\tP7fqz65xk6KIfOiHG0nvhdU3i6br0lQCobdXAvxmXT/bsPRBvzhPmzA62XWmzGDxwI4R\n\thsaqki8dLsm+U1IV6qeGUY0p4BZZMpJiligHY110uDY/TqQo0c8i8lXJYqywn+/OPA0h\n\tGFyZ9ieg19z734DmkqCZ9RB5od8hNfPU/2enEcZmq2ifJMP35YCz8jQKGJuGu4ixn7VC\n\tPA7w==", "X-Gm-Message-State": "AOJu0Ywm3jo9mrPozi4KPK5PVZugL2XriDMixyg1+4yA1ec76mzpJ0rV\n\t1Qcy6biOzose8ialXrFdHz51RurX2eQDf0goBDWEnGH2futf0wVUr0AkB0IZaDvQCvtoYrJUEKu\n\tu+/l3gw0=", "X-Gm-Gg": "AY/fxX6ypdCZKW0TVpAsOM5zNM0LPC2IZSjhCR7Zqzuqj1u8Vg0sEVcUCajPqPUiWOt\n\tDJPltf2Ks48bzqMuGLa66WWM766BdvDbkyRbGlamSYjzG9/9dieKsCHFMpHW1CSoqOr11GAyoyM\n\t4gtB1H98hjd6J5g+B06W1eRTYWRahR4M0hNgb8cbvwg0BF6WaZoXna3N/2LS4xDhmGNMeizAxCE\n\tOZ6ffj7E1Rq9K7c0ugIEdROsaZigi9WZaP10qgIDof+mBluq0C7MEy5isA7L1+S7uP+2r6ASbyo\n\t8xqvE0TwPEMTzBXhsnQabzSM0F6MHsZ+vVHQU9/iMU4nf7gMQ/GdSUfYLVIiibAy8ioFEcWm4DE\n\tVNKjkgzksN+mcVLZ2Ahnv4Pl/0NZ76O1Nx4T2NQpsJROr8LVyo2ffa/0pjMAl//Ie/vaExSAvTk\n\tUdz8O1dL1IQUp1b3s2RjwpKUBZ3NqGeWLwn6MrwP4i1rONtiw8y4IGDCe+1svOHxoxMYg=", "X-Google-Smtp-Source": "AGHT+IGsb7x3KJ1KzZdw69Mk5GTsI+BcFvtIjMYRFmhEq+SC4R5I0KZ8J2T5MKLy10MQ1Ch5JVMWfw==", "X-Received": "by 2002:a05:6000:2584:b0:430:f1d3:fa2 with SMTP id\n\tffacd0b85a97d-432bc9cbee7mr4479936f8f.7.1767718879002; \n\tTue, 06 Jan 2026 09:01:19 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v11 13/24] libcamera: software_isp: Add member variables to\n\ttrack selected input/output pixelFormat", "Date": "Tue, 6 Jan 2026 17:00:48 +0000", "Message-ID": "<20260106170059.56193-14-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260106170059.56193-1-bryan.odonoghue@linaro.org>", "References": "<20260106170059.56193-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In order to have Debayer::start() tell the eGL shader compilation routine what\nthe input and output pixel format is, we need to have a copy of the\nselected format available. Add variables to the inputConfig and\noutputConfig structures to allow tracking of this data for later use.\n\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/debayer.cpp | 10 ++++++++++\n src/libcamera/software_isp/debayer.h | 2 ++\n 2 files changed, 12 insertions(+)", "diff": "diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\nindex 4cb5b4da4..b948efad1 100644\n--- a/src/libcamera/software_isp/debayer.cpp\n+++ b/src/libcamera/software_isp/debayer.cpp\n@@ -290,6 +290,16 @@ Debayer::~Debayer()\n * output image buffer. Set during stream configuration.\n */\n \n+/**\n+ * \\var Debayer::inputPixelFormat_\n+ * \\brief The incoming pixel format\n+ */\n+\n+/**\n+ * \\var Debayer::outputPixelFormat_\n+ * \\brief The output pixel format\n+ */\n+\n /**\n * \\var Debayer::red_\n * \\brief Lookup table for red channel gain and correction values\ndiff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h\nindex b8287166e..d716ad080 100644\n--- a/src/libcamera/software_isp/debayer.h\n+++ b/src/libcamera/software_isp/debayer.h\n@@ -75,6 +75,8 @@ public:\n \n \tDebayerInputConfig inputConfig_;\n \tDebayerOutputConfig outputConfig_;\n+\tPixelFormat inputPixelFormat_;\n+\tPixelFormat outputPixelFormat_;\n \tDebayerParams::LookupTable red_;\n \tDebayerParams::LookupTable green_;\n \tDebayerParams::LookupTable blue_;\n", "prefixes": [ "v11", "13/24" ] }