Patch Detail
Show a patch.
GET /api/patches/25663/?format=api
{ "id": 25663, "url": "https://patchwork.libcamera.org/api/patches/25663/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25663/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260106170059.56193-11-bryan.odonoghue@linaro.org>", "date": "2026-01-06T17:00:45", "name": "[v11,10/24] libcamera: shaders: Add support for Gamma", "commit_ref": "46aac79a4458589f7539f59fb915c85dacc3f57b", "pull_url": null, "state": "accepted", "archived": false, "hash": "3b84f0f5b603856659bfecac8e4eaaab2a6d7aa8", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25663/mbox/", "series": [ { "id": 5689, "url": "https://patchwork.libcamera.org/api/series/5689/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5689", "date": "2026-01-06T17:00:35", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 10, "mbox": "https://patchwork.libcamera.org/series/5689/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25663/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25663/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BE0A7BDCC0\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 6 Jan 2026 17:01:20 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5E5B962019;\n\tTue, 6 Jan 2026 18:01:20 +0100 (CET)", "from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com\n\t[IPv6:2a00:1450:4864:20::42b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9AC6A6200C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 6 Jan 2026 18:01:15 +0100 (CET)", "by mail-wr1-x42b.google.com with SMTP id\n\tffacd0b85a97d-42e2ba54a6fso452688f8f.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 06 Jan 2026 09:01:15 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-432bd0dadcfsm5515322f8f.3.2026.01.06.09.01.13\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 06 Jan 2026 09:01:14 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"FNKauIS/\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1767718875; x=1768323675;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=ZRuITSMve+FWc8iDUneEG5zb0QDixsRjAIi5XBQ3RYM=;\n\tb=FNKauIS/0dsSJ14v1qXPu6hy/xqD5CDby92U9OEV5hjxK+fm8iCrpp143ubGRhDN1+\n\tG1iU770ii5gWvC+Fwr/YVhUb9CIB7v99wJjwU3rwRPH3v8tukuDFW4Qn0WkFNzaacUkw\n\tOvTJDdat6jtitPTf7h+srb2NKsqhjRzcdibOcqZmGK2iPG+pX9i/ZHG3MasZG2r9Sbh/\n\t7Tp2EBjPrYkBtu9/gcK/NOQJpFrOomCKGiyiLcNQcxWc9afx9jeCPhiZ5wUreyllmhHa\n\taZqIpsZWAg5qeGWrBeZR7PzDszffpmyMlPU8PYGFw8Eh8WiXSCR2X1TRIJMASCmOw5Uj\n\tinaQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1767718875; x=1768323675;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=ZRuITSMve+FWc8iDUneEG5zb0QDixsRjAIi5XBQ3RYM=;\n\tb=NTrMgg3I4Ff2FKvxKEKlD3iMXndt7Akowa0adO6niobRqYePlxncMcS1qxfWwy3hMp\n\t4gTg+JB0ZT1YVBXNEI0icfkzxjbWKgixo5Pr6kS9kfRcbOorM65U4dbYwzBAlgEAhK6A\n\tTb4cbFaeSYLJrw7CVpK3a8hVRPfjn75QrEFHT36VJ4ifUK8ZY6OF+4n8/QBXBkEMVlcj\n\t3agJlX4ruwm3cB6yJL9KPWi07MYm4yCCnfR8QcLHSly12s3YAY2loVT0T8pwC23wBmP1\n\t7tCbB+4i6QmU8MS66dbeFlI7ZRMGKrmH1jNn8NU9V1GH8CpHxLSrofo0ePI2yZvl0iDK\n\t/Vzg==", "X-Gm-Message-State": "AOJu0YyZ8cKqjJvLbaIWcfWEw+KW6RMdhEy03ISlHuWdD2ll5002rxMP\n\tgpqm74fhLG6CcSJRci1UbE8MDk4eggXKvhTOvzIQuTo/LE6shYyQlX8g+vOARFFSsD9+9s7fpVJ\n\t2cTYCjL0=", "X-Gm-Gg": "AY/fxX4jSE7ttjnDFSD08Si6+fK0Yvm6X8OC4ZWfEDiZCYhpbiHGjUuqHewC+LhLv7Q\n\tyeuni1gP8M7cnlTY08JsEkNrpiij3klzzBSieDs3gqfZR8rFPP7NiXL0mX/5FnAapZpu39/twEL\n\tS5waAv9tCt+nPqboVPmzribMkzQq/thWI7at72SJmoS3vNFR0Gdfa39WpNnmLYBL4ApHDUTEZAn\n\twWcApTiS5ETdbkmyMTv1cKwfeu7RerxkpHmopuMhBlUl6BUQZ0oW8E5hjj7PQVYvlQr9YETOnpx\n\tQhkZ+SJjNuebGhThmS5TFIZdvSTJAxcrlOVL16MXfyD4EaDWr/4gacTgOnhU6WhLu6f1hPCE02a\n\tLQ7lCvhl75sevqvrYzzkwB6kvrGshc25Hc6URd16ke9tgvtpTaObzB6uCWStfXZF6SZQ75WwaMM\n\t2iunfZNM/1RwGnKDDfCgBw+fjzm9K/m3tXExmRFSkgIWQCkaHofr8hswD9Sya2Om5buwQ=", "X-Google-Smtp-Source": "AGHT+IHjztrKp6NRVqwM91T18D8N7dDx7S3P1yh7Osny7IqH5lH71GasDNyTKcn2cFJMkDzvNtqL0Q==", "X-Received": "by 2002:a05:6000:4014:b0:431:a0:7de0 with SMTP id\n\tffacd0b85a97d-432bca4867cmr4894735f8f.35.1767718874737; \n\tTue, 06 Jan 2026 09:01:14 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v11 10/24] libcamera: shaders: Add support for Gamma", "Date": "Tue, 6 Jan 2026 17:00:45 +0000", "Message-ID": "<20260106170059.56193-11-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260106170059.56193-1-bryan.odonoghue@linaro.org>", "References": "<20260106170059.56193-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add gamma compensation to the debayer shaders after colour correction is\napplied.\n\nSimilarly only apply the calculated Gamma curve when using the CCM as the\nlookup tables already contain the data.\n\nSuggested-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/shaders/bayer_1x_packed.frag | 4 ++++\n src/libcamera/shaders/bayer_unpacked.frag | 4 ++++\n 2 files changed, 8 insertions(+)", "diff": "diff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag\nindex 7036fe278..77d9fbfa7 100644\n--- a/src/libcamera/shaders/bayer_1x_packed.frag\n+++ b/src/libcamera/shaders/bayer_1x_packed.frag\n@@ -67,6 +67,7 @@ uniform vec2 tex_bayer_first_red;\n uniform sampler2D tex_y;\n uniform mat3 ccm;\n uniform vec3 blacklevel;\n+uniform float gamma;\n \n void main(void)\n {\n@@ -260,6 +261,9 @@ void main(void)\n \trgb.g = (rin * ccm[1][0]) + (gin * ccm[1][1]) + (bin * ccm[1][2]);\n \trgb.b = (rin * ccm[2][0]) + (gin * ccm[2][1]) + (bin * ccm[2][2]);\n \n+\t/* Apply gamma after colour correction */\n+\trgb = pow(rgb, vec3(gamma));\n+\n #if defined (SWAP_BLUE)\n \tgl_FragColor = vec4(rgb.bgr, 1.0);\n #else\ndiff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag\nindex f0d8cd1e2..aba11a87f 100644\n--- a/src/libcamera/shaders/bayer_unpacked.frag\n+++ b/src/libcamera/shaders/bayer_unpacked.frag\n@@ -26,6 +26,7 @@ varying vec4 yCoord;\n varying vec4 xCoord;\n uniform mat3 ccm;\n uniform vec3 blacklevel;\n+uniform float gamma;\n \n void main(void) {\n vec3 rgb;\n@@ -155,6 +156,9 @@ void main(void) {\n rgb.g = (rin * ccm[1][0]) + (gin * ccm[1][1]) + (bin * ccm[1][2]);\n rgb.b = (rin * ccm[2][0]) + (gin * ccm[2][1]) + (bin * ccm[2][2]);\n \n+ /* Apply gamma after colour correction */\n+ rgb = pow(rgb, vec3(gamma));\n+\n #if defined (SWAP_BLUE)\n gl_FragColor = vec4(rgb.bgr, 1.0);\n #else\n", "prefixes": [ "v11", "10/24" ] }