Patch Detail
Show a patch.
GET /api/patches/25661/?format=api
{ "id": 25661, "url": "https://patchwork.libcamera.org/api/patches/25661/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25661/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260106170059.56193-9-bryan.odonoghue@linaro.org>", "date": "2026-01-06T17:00:43", "name": "[v11,08/24] libcamera: shaders: Extend bayer shaders to support swapping R and B on output", "commit_ref": "58823cbf688168baf8bdd6fc3b747e40e6da8263", "pull_url": null, "state": "accepted", "archived": false, "hash": "c8fe7f0d90359367374670fccaad26c63fe1bcac", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25661/mbox/", "series": [ { "id": 5689, "url": "https://patchwork.libcamera.org/api/series/5689/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5689", "date": "2026-01-06T17:00:35", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 10, "mbox": "https://patchwork.libcamera.org/series/5689/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25661/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25661/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 563D4C3213\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 6 Jan 2026 17:01:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F19A162004;\n\tTue, 6 Jan 2026 18:01:16 +0100 (CET)", "from mail-wr1-x442.google.com (mail-wr1-x442.google.com\n\t[IPv6:2a00:1450:4864:20::442])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DBA3961FB7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 6 Jan 2026 18:01:12 +0100 (CET)", "by mail-wr1-x442.google.com with SMTP id\n\tffacd0b85a97d-430f2ee2f00so579008f8f.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 06 Jan 2026 09:01:12 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-432bd0dadcfsm5515322f8f.3.2026.01.06.09.01.11\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 06 Jan 2026 09:01:11 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"Jixm7b+N\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1767718872; x=1768323672;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=nAlpCB4iJopL0Pn768w20N/UlmcrQmnghUNHBy8yJOY=;\n\tb=Jixm7b+NPpIz9DA7+kErB9jEU2ezavMvvN1QMAcWF5Nd+UanmMobw0PmDlXfPbJnjL\n\tGfHb1HFzLvMQTOefKycCNAaaoELn+2BeGe45SaOLHLNDs45eX12lzt9+xnz6SKgJJVf1\n\t6PgvyvTx42U2elOtc2MBwHy+rpUuNke2f0f8LFb+bhFpFqyc80PKADAq1VtOcSj01+4U\n\ttGJhXPwqk5tsOxgRPNfIEBMuPD69U0i4yk0lyJ070Px+cqgDFeSVGkWfKE8ynYPOQoLJ\n\tyAYSvn23PRN5jhnw8EAXiL2sBGoZ+qSZjnpIsvBn9jAmZ6wBbsovFxDI9JecCy+BmjHF\n\tSvyg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1767718872; x=1768323672;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=nAlpCB4iJopL0Pn768w20N/UlmcrQmnghUNHBy8yJOY=;\n\tb=jGLClE7Sqbreh0DAXsZrIqy+2Bi36W5WtLJLFxpzxtF6Xbx7BxGQvPuo5Dx1rb2jOR\n\tHmeuASn+TQjJpuUo6P2RxMVIQlk/cTRR3hYtNfLG7qTd41VLHZJLqgoNByc8zWAw0d0N\n\t90fUz+2LhlQ3vBo8gjwGVBKafwNI2Frvdj4gg2HZHYthVXktY+ULwa6TacKg5L6edYWP\n\tGCg1eWVJp4MktWhVgs5zSzBDwCa15ofLqnV52qJkjt8AxpSZMXOfytPKI/DmMUFJmvGa\n\tj1Yk7gz4hRX/3kdGLlewyGxQRN6r1VaQ6aj7kbQGxN922pEcHKcdd+RKaf25Gzaxk8u2\n\tph3g==", "X-Gm-Message-State": "AOJu0Yxwtyx32quyylu2/iszTdrpYbe6ahN34zDFflLW60yJnCN/TlL5\n\tO6Pen+2f5u3w0UXqFWBXgaqy2PAF3a7D5fU4zP8zHrTn5HsQ1gDn1+oKTBFvjVlYPE5Zaxea3JU\n\t0HTcBtEfHLg==", "X-Gm-Gg": "AY/fxX7PK7nDoi8vWvjyIbiDUdu/9CEu0JK5t9l/OAyrw6EoI5MxKkvj9TSCOyYVgg7\n\tSE5zg4mguCwVbRTvEqc19GbWmCC5nHJZxO/a9ONhRK31BMU50mVptqqeKkkrt8neDkDslGhu2vB\n\t0I7PQz2ZtFhI3Uq8Uyp8YcHkZNW6c2JW7L6udNxs0TFCn9E1s4O0PCMorrBGAXxlOAe6rkuuNN/\n\tEJDKzcJwJn4WVHHvgL8FbSP0JInC8ehQfEVDNu6oqk+Sq9/NupaAsMpq2yw8JI+mLHGBu110W91\n\tfOqB8UziDgvnEEq9fyHGr7CqJ7qZvrwdX4ud2vGFa3xrDKF5uRWPQlxI23Z05tFeWkdLiILpewa\n\tAoIbmKq9PTRI/Y7StP1ZtE3t7uGF9YrsG7n7zlDx6BdsicYmSmdZgv1ZHa4p4vD99NiFLDaN7gB\n\tkEU+9B0cEsaamJwDtKRTQDMfv/4yvPQ/VwzUMyrsXFv+LjTqOdRnZ8CKMdFcUt1cQ2c94=", "X-Google-Smtp-Source": "AGHT+IH1XYy9baiES9UT5C5d2cXk0dpA8cWnmrLNNJXTzi/7Z2GvMxXG5yV7o8l7Zr0HvEYa272V0w==", "X-Received": "by 2002:a05:6000:2c0c:b0:401:5ad1:682 with SMTP id\n\tffacd0b85a97d-432bca29ae0mr4326605f8f.14.1767718872150; \n\tTue, 06 Jan 2026 09:01:12 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tMilan Zamazal <mzamazal@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v11 08/24] libcamera: shaders: Extend bayer shaders to\n\tsupport swapping R and B on output", "Date": "Tue, 6 Jan 2026 17:00:43 +0000", "Message-ID": "<20260106170059.56193-9-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260106170059.56193-1-bryan.odonoghue@linaro.org>", "References": "<20260106170059.56193-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We can easily facilitate swapping R and B on output. Pivot on an\nenvironment define for this purpose.\n\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nAcked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/shaders/bayer_1x_packed.frag | 4 ++++\n src/libcamera/shaders/bayer_unpacked.frag | 6 +++++-\n 2 files changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag\nindex 171a928c2..db8c2a0b3 100644\n--- a/src/libcamera/shaders/bayer_1x_packed.frag\n+++ b/src/libcamera/shaders/bayer_1x_packed.frag\n@@ -257,5 +257,9 @@ void main(void)\n \trgb.g = (rin * ccm[1][0]) + (gin * ccm[1][1]) + (bin * ccm[1][2]);\n \trgb.b = (rin * ccm[2][0]) + (gin * ccm[2][1]) + (bin * ccm[2][2]);\n \n+#if defined (SWAP_BLUE)\n+\tgl_FragColor = vec4(rgb.bgr, 1.0);\n+#else\n \tgl_FragColor = vec4(rgb, 1.0);\n+#endif\n }\ndiff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag\nindex c41d72f4f..06d80f3dd 100644\n--- a/src/libcamera/shaders/bayer_unpacked.frag\n+++ b/src/libcamera/shaders/bayer_unpacked.frag\n@@ -152,5 +152,9 @@ void main(void) {\n rgb.g = (rin * ccm[1][0]) + (gin * ccm[1][1]) + (bin * ccm[1][2]);\n rgb.b = (rin * ccm[2][0]) + (gin * ccm[2][1]) + (bin * ccm[2][2]);\n \n- gl_FragColor.rgb = rgb;\n+#if defined (SWAP_BLUE)\n+ gl_FragColor = vec4(rgb.bgr, 1.0);\n+#else\n+ gl_FragColor = vec4(rgb, 1.0);\n+#endif\n }\n", "prefixes": [ "v11", "08/24" ] }