Patch Detail
Show a patch.
GET /api/patches/25626/?format=api
{ "id": 25626, "url": "https://patchwork.libcamera.org/api/patches/25626/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25626/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260105143206.115011-1-naush@raspberrypi.com>", "date": "2026-01-05T14:31:45", "name": "[v2] v4l2_camera_proxy: Fix for getting deafult controls::FrameDurationLimits", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "cc0d04083333d95bf250bfa898527d6f95767c9f", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25626/mbox/", "series": [ { "id": 5685, "url": "https://patchwork.libcamera.org/api/series/5685/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5685", "date": "2026-01-05T14:31:45", "name": "[v2] v4l2_camera_proxy: Fix for getting deafult controls::FrameDurationLimits", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5685/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25626/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25626/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3026CBDCC0\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 5 Jan 2026 14:32:23 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 484D661F9F;\n\tMon, 5 Jan 2026 15:32:22 +0100 (CET)", "from mail-wm1-x331.google.com (mail-wm1-x331.google.com\n\t[IPv6:2a00:1450:4864:20::331])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 003F861F35\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 5 Jan 2026 15:32:19 +0100 (CET)", "by mail-wm1-x331.google.com with SMTP id\n\t5b1f17b1804b1-47798f4059fso13298705e9.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 05 Jan 2026 06:32:19 -0800 (PST)", "from naush-dell.pitowers.org\n\t([2a00:1098:3142:1f:9644:8cdc:57dc:9223])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-4327778e27bsm67402053f8f.12.2026.01.05.06.32.18\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 05 Jan 2026 06:32:18 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"bYfm29NZ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1767623539; x=1768228339;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=SYtvXE1MkuK/e0A5BHOpwSDVdM/or9gU7hgMIsZfgpA=;\n\tb=bYfm29NZ5KVrko+qt1y+Mp8bfdl9ag8fbgILfgFaWitECaDcjvJPWB7jwNCeM0zf81\n\txrRv+8M0m/g8FBahFXOQFZLJtBDL3fBOK4vTM18cHOvIiAeJHyRfd7QwyPPdXQDzWUBu\n\t2LyMCWshg/DMzfs0D6Vc9BC5L12lDwtOqidQ33pwsHOX9s+myfqeo8W6OMzHS6UrhML2\n\ts3n47wxEsAMRoC33s2YhQa8REEqzF+4cDzysJtiaeHqoJ1zhNKHmuYi/TWqvot2CNBBx\n\tH+Gv4EYp+gpAjcJrSi5p8HgTWxw4J3hZJrFUnDbR29x+FXkB4aUPHYbe9uo8NscKbSRF\n\tCopQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1767623539; x=1768228339;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=SYtvXE1MkuK/e0A5BHOpwSDVdM/or9gU7hgMIsZfgpA=;\n\tb=XRS5bFhZOZtJIUhKj7w0nLWJOdDEWDgWwTu5UyKFndgJB0jKxhbKvvKwCd0zrgSoZM\n\tbuBPCa3TPo1g5iCyXi46XCX4JG+mgypr5RmHYCKvG5g/SPOMovZpKd+4uqL0r8r/pdCf\n\tW/jVjC4Fat5FNT9miTKt8SnGSkpOrZFVewfNmW7R9VM3xTmuKIsK+TkE3bjG9LtLfKwk\n\tLkJ7TdVivba51KOv7rWyDJ0teYP1svcCCDkopecwivFEZ/ia7lAEFdSONhjJkeyrfpEl\n\twbVIn1GJ9aGKXK2wDLwNFcg4QT6xUT8wIpvE3pfql8PLbkA0q4+RypYoJhNp2OkRFo49\n\te0Ig==", "X-Gm-Message-State": "AOJu0YzRA/jjssxEH7w4VNBtuuHgTtXwDwokn3tX7jhpDnzFHpymhQ74\n\tWLe9Ytd1exSKUPnyY58GHF/qTi0N8bmD7NUNQurH2womx8w03tTJyd+F2Zhs1XE0TezPPcG2IMA\n\tWBjQC", "X-Gm-Gg": "AY/fxX4ZKzwjME4cZClyEKznViqYe4ACvuwxXY5wc5+7BVI78CdirAPrJJ6pjgBLizt\n\thRcxzhlQvdKpa8290BqatMN6I/Ja/q29VgC7MUDCLrLvYAzQlRzmitlbQw0wHSF+gdaFTI8kzAt\n\ti3XDigcy4RfCHXZ4l2hWvpNnV1mObdUrj6cC+E/juIBggls6E/n4B+bNErKtldcZOdSjiQV9m2O\n\tlYUP55RjdaW/ueV7I6WF8DOsMBeSASEE3y+NAzlR70YfCElM4xg5m8ejt2ZnOVxDIbBcm7q4iai\n\tYuDY1I0Q8F+tG5X2IQgvxmG2n+jCyUsSDlga5hU8DZ5x42rnyCWlAGHE+PTd5UFcjEfW/q7jDT9\n\tlOhsly/rD7ZfPmXr9lAyRiQDTW2aunN3KoIP+O9WWWKN1yLxjndAVznUfIuIW4SEsfhXywHiWiB\n\tPhZ8otCy47sxCs0t0hPm8qd9Id7+/fe9/UKJNXz7tocg==", "X-Google-Smtp-Source": "AGHT+IF+fZeEaAQySW7t+vcsm0VQQK2QnRPcVsAkG9vyBGNy1UeAyX5VDFW//xJjE2ksoL9Xcw0GPg==", "X-Received": "by 2002:a05:600c:4fd3:b0:477:a450:7aa2 with SMTP id\n\t5b1f17b1804b1-47d1954d406mr388769765e9.1.1767623539068; \n\tMon, 05 Jan 2026 06:32:19 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Naushir Patuck <naush@raspberrypi.com>, =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= <barnabas.pocze@ideasonboard.com>", "Subject": "[PATCH v2] v4l2_camera_proxy: Fix for getting deafult\n\tcontrols::FrameDurationLimits", "Date": "Mon, 5 Jan 2026 14:31:45 +0000", "Message-ID": "<20260105143206.115011-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.51.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The default values for controls::FrameDurationLimits is now an array but\nthe v4l2 proxy is fetching it as a scalar value, causing a runtime\nerror. Fix this by templating the getter with the correct\nSpan<const int64_t, 2> type.\n\nAlso related, fix the RPi IPA's initial default value for\ncontrols::FrameDurationLimits to be an array and use the default const\nvalues.\n\nFixes: 4e9be7d11b9df (\"ipa: ipu3, mali-c55, rkisp1, rpi: Fix reporting non-scalar controls\")\nCloses: https://github.com/raspberrypi/libcamera/issues/321\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/ipa/rpi/common/ipa_base.cpp | 6 ++++--\n src/v4l2/v4l2_camera_proxy.cpp | 4 ++--\n 2 files changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\nindex 14aba4500ae4..322694985e72 100644\n--- a/src/ipa/rpi/common/ipa_base.cpp\n+++ b/src/ipa/rpi/common/ipa_base.cpp\n@@ -84,8 +84,10 @@ const ControlInfoMap::Map ipaControls{\n \t{ &controls::Sharpness, ControlInfo(0.0f, 16.0f, 1.0f) },\n \t{ &controls::ScalerCrop, ControlInfo(Rectangle{}, Rectangle(65535, 65535, 65535, 65535), Rectangle{}) },\n \t{ &controls::FrameDurationLimits,\n-\t ControlInfo(INT64_C(33333), INT64_C(120000),\n-\t\t static_cast<int64_t>(defaultMinFrameDuration.get<std::micro>())) },\n+\t ControlInfo(static_cast<int64_t>(defaultMinFrameDuration.get<std::micro>()),\n+\t\t static_cast<int64_t>(defaultMaxFrameDuration.get<std::micro>()),\n+\t\t Span<const int64_t, 2>{ { static_cast<int64_t>(defaultMinFrameDuration.get<std::micro>()),\n+\t\t\t\t\t\tstatic_cast<int64_t>(defaultMinFrameDuration.get<std::micro>()) } }) },\n \t{ &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) },\n \t{ &controls::rpi::StatsOutputEnable, ControlInfo(false, true, false) },\n };\ndiff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex 559ffc6170b1..03cd4810cc05 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -200,9 +200,9 @@ void V4L2CameraProxy::setFmtFromConfig(const StreamConfiguration &streamConfig)\n \tconst auto &it = controls.find(&controls::FrameDurationLimits);\n \n \tif (it != controls.end()) {\n-\t\tconst int64_t duration = it->second.def().get<int64_t>();\n+\t\tSpan<const int64_t, 2> duration = it->second.def().get<Span<const int64_t, 2>>();\n \n-\t\tv4l2TimePerFrame_.numerator = duration;\n+\t\tv4l2TimePerFrame_.numerator = duration[0];\n \t\tv4l2TimePerFrame_.denominator = 1000000;\n \t} else {\n \t\t/*\n", "prefixes": [ "v2" ] }