Patch Detail
Show a patch.
GET /api/patches/25623/?format=api
{ "id": 25623, "url": "https://patchwork.libcamera.org/api/patches/25623/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25623/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260105103409.50623-1-naush@raspberrypi.com>", "date": "2026-01-05T10:34:03", "name": "[v1] v4l2_camera_proxy: Fix for getting deafult controls::FrameDurationLimits", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "9a53bdcf4c47a7ef0cdb233f359181eecce374ca", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25623/mbox/", "series": [ { "id": 5682, "url": "https://patchwork.libcamera.org/api/series/5682/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5682", "date": "2026-01-05T10:34:03", "name": "[v1] v4l2_camera_proxy: Fix for getting deafult controls::FrameDurationLimits", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5682/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25623/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25623/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4D998BDCC0\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 5 Jan 2026 10:34:16 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 62EA661FA3;\n\tMon, 5 Jan 2026 11:34:15 +0100 (CET)", "from mail-wm1-x332.google.com (mail-wm1-x332.google.com\n\t[IPv6:2a00:1450:4864:20::332])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2109961F9F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 5 Jan 2026 11:34:13 +0100 (CET)", "by mail-wm1-x332.google.com with SMTP id\n\t5b1f17b1804b1-47d211aee52so10730465e9.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 05 Jan 2026 02:34:13 -0800 (PST)", "from naush-dell.pitowers.org\n\t([2a00:1098:3142:1f:9644:8cdc:57dc:9223])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-4324eaa08d9sm99928289f8f.30.2026.01.05.02.34.11\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 05 Jan 2026 02:34:11 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"COKsDyyN\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1767609252; x=1768214052;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=rqoMihRduB5bZDnwH4ifTbRwBT2RGtsF/oHdwbtxZPY=;\n\tb=COKsDyyNMpanXQdP5XQ1ERqJqAg0HtV0aTyS2K8F2U9B+i8kXOoZVrUPyndh8zFK4U\n\tZB7b5qPFJCasJk7ae3qAZbjdJHIILGNX7zDaP+/oABrFIBWKuSEQ9sEVKHzQ1PgY0OdG\n\t2RvD4sccX2Wlg+4sPdB8pSszqHuBB+/U+7GH4OrAErJO1+5Bzlj75aOIiqDvC4gziEWl\n\tbiA9v4OkjDYoIRCEvUSoW6+hKpgyN4K/VI5QxM5S77juW64d+CHS9RsasDZawTVaxSuC\n\tgA9XQ07jBJOOV82xdJoHwWoGMVAXXFyoMSzXPx2qqPGKSGkwAwT3JtzN4627Dc22qo3d\n\tEVeg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1767609252; x=1768214052;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=rqoMihRduB5bZDnwH4ifTbRwBT2RGtsF/oHdwbtxZPY=;\n\tb=PpHI8K43R9+yild3gNdazrpKrynIZuHzCKBnWrbGsPRwAkrStE+/wU+A8G8ck+2/UA\n\tSuIGV7QdDCMLWJfeyrxI0fv2rXTboQsVUJmOQjW7ecwiVtu3RyuheZPjEaAfUe98E6gn\n\tEAKtI8+2jxNAWu99TfScAGq3Z42WcdNedO8Tp3RHfhtr7n7QoC3beydXV2DdM/PZiVUM\n\tWy/XhZ3pDudU9tvshH+EHd+MKjVM3JMhxbah7aiz1pZ2/NHN46NFAIUEEbGKHNSjFK9L\n\t63L03FlJlu4YDsfhLE+aPsX16qvAdAjctCZ9eCzZ7zl9gPKBajhkP8ZqdjCDQ14VO2l9\n\tz34A==", "X-Gm-Message-State": "AOJu0Yz4wo43VXKLq8amnYkXokHJsqi36kwjsqUdvwi9kGUtCfMJrbnW\n\ty15u+dryb15FGBSHS2suNzERUkCuElQNItSWVGDn/eekHfRw9Lnt94bNXHH+zRAscIa5Ou6h7xe\n\ty2lrW", "X-Gm-Gg": "AY/fxX7hbvIKA6HqM7upe2XVeApL6EsOorY8yfw0vJdUKaNJNXb/qUfAuiVqaRN3Hq5\n\tYFsswP1JuwxV1MEjahTX2iUOPTsirt+tiFWQ/Q0+b7KNAdqVefY80mh81U7otI9rN+4vE+7RVxz\n\tF/7SxndtzRYPrqiyORpZOuGI6liDjNUaSt8zKIwUsarPQyGIQQ78ESqvZJiMe9e05XX/+TMk7aq\n\t+EP7oooHuSze4zHZq0bCXTYY2Ux5dlaydG2dRa3rvQmjO13okxdhgIXIc/hbkb/8hl80Ujz6XZU\n\taFxL0e3N/ljR0tJ/F6nEg0bXCD1MMCjfMUxKN69Dm39Ah/2vQMGCvpgRqRNPEO5JgXkkI7iDuEH\n\tS9vlgSLOc8mLwKMNaknmD1IroWCYk0wOiPrPBmB0pVp0XOKqUlCx9PTmVo6tgH8gXh45fleD78m\n\tKLpEThBoMckH+cHZxHouQKnDL57HKjvpA=", "X-Google-Smtp-Source": "AGHT+IFVENV+LyKqoGbh5KVy2qo+da1fyVZXo9l9sk1mf4xPRVz9wWlKA5QSyP4DUIcwt9JGj0uh0Q==", "X-Received": "by 2002:a05:6000:1cd1:b0:432:84ef:7159 with SMTP id\n\tffacd0b85a97d-43284ef7493mr15925990f8f.8.1767609252283; \n\tMon, 05 Jan 2026 02:34:12 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Naushir Patuck <naush@raspberrypi.com>", "Subject": "[PATCH v1] v4l2_camera_proxy: Fix for getting deafult\n\tcontrols::FrameDurationLimits", "Date": "Mon, 5 Jan 2026 10:34:03 +0000", "Message-ID": "<20260105103409.50623-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.51.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The default values for controls::FrameDurationLimits is now an array but\nthe v4l2 proxy is fetching it as a scalar value, causing a runtime\nerror. Fix this by templating the getter with the correct\nSpan<const int64_t, 2> type.\n\nAlso related, fix the RPi IPA's initial default value for\ncontrols::FrameDurationLimits to be an array.\n\nFixes: 4e9be7d11b9df (\"ipa: ipu3, mali-c55, rkisp1, rpi: Fix reporting non-scalar controls\")\nCloses: https://github.com/raspberrypi/libcamera/issues/321\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/ipa/rpi/common/ipa_base.cpp | 3 ++-\n src/v4l2/v4l2_camera_proxy.cpp | 4 ++--\n 2 files changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\nindex 14aba4500ae4..9f8667a2284a 100644\n--- a/src/ipa/rpi/common/ipa_base.cpp\n+++ b/src/ipa/rpi/common/ipa_base.cpp\n@@ -85,7 +85,8 @@ const ControlInfoMap::Map ipaControls{\n \t{ &controls::ScalerCrop, ControlInfo(Rectangle{}, Rectangle(65535, 65535, 65535, 65535), Rectangle{}) },\n \t{ &controls::FrameDurationLimits,\n \t ControlInfo(INT64_C(33333), INT64_C(120000),\n-\t\t static_cast<int64_t>(defaultMinFrameDuration.get<std::micro>())) },\n+\t\t Span<const int64_t, 2>{ { static_cast<int64_t>(defaultMinFrameDuration.get<std::micro>()),\n+\t\t\t\t\t\tstatic_cast<int64_t>(defaultMinFrameDuration.get<std::micro>()) } }) },\n \t{ &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) },\n \t{ &controls::rpi::StatsOutputEnable, ControlInfo(false, true, false) },\n };\ndiff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex 559ffc6170b1..03cd4810cc05 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -200,9 +200,9 @@ void V4L2CameraProxy::setFmtFromConfig(const StreamConfiguration &streamConfig)\n \tconst auto &it = controls.find(&controls::FrameDurationLimits);\n \n \tif (it != controls.end()) {\n-\t\tconst int64_t duration = it->second.def().get<int64_t>();\n+\t\tSpan<const int64_t, 2> duration = it->second.def().get<Span<const int64_t, 2>>();\n \n-\t\tv4l2TimePerFrame_.numerator = duration;\n+\t\tv4l2TimePerFrame_.numerator = duration[0];\n \t\tv4l2TimePerFrame_.denominator = 1000000;\n \t} else {\n \t\t/*\n", "prefixes": [ "v1" ] }