Patch Detail
Show a patch.
GET /api/patches/25612/?format=api
{ "id": 25612, "url": "https://patchwork.libcamera.org/api/patches/25612/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25612/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251218232220.761254-7-rui.wang@ideasonboard.com>", "date": "2025-12-18T23:22:20", "name": "[v6,6/6] ipa: rkisp1: algorithms: data: enable DPF tuning for imx219/ov5640", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "905ecfbd94a417a928b082dca9538419ba7be33d", "submitter": { "id": 241, "url": "https://patchwork.libcamera.org/api/people/241/?format=api", "name": "Rui Wang", "email": "rui.wang@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25612/mbox/", "series": [ { "id": 5673, "url": "https://patchwork.libcamera.org/api/series/5673/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5673", "date": "2025-12-18T23:22:14", "name": "refactor DPF parsing and initialization", "version": 6, "mbox": "https://patchwork.libcamera.org/series/5673/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25612/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25612/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 454F7C326C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Dec 2025 23:23:01 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E06BB61F6D;\n\tFri, 19 Dec 2025 00:23:00 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1930B61F60\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 19 Dec 2025 00:22:59 +0100 (CET)", "from rui-Precision-7560.local (unknown [209.216.103.65])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 51C6C557;\n\tFri, 19 Dec 2025 00:22:51 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ndVJg/l+\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1766100171;\n\tbh=BRiVMmSnevNpJdlhYanBCZkP7hZrbGxTkWp5p5GaZA4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ndVJg/l+tjOdGKTbgY7nfxnsL3STjJFfujzVUcQn8jNR9AJ11VmE8yyOz5OsJLZ06\n\twEGNJ8C2H4a77PSm+Vyx0H4dw6UQZ82UAwQ1YuhWe56p22jQgPrAHSb3KpRnNG9iQ9\n\trjffBdMkr67PODOte4nFsxN/PGG8Gm6EgT/as8Bs=", "From": "Rui Wang <rui.wang@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Rui Wang <rui.wang@ideasonboard.com>", "Subject": "[PATCH v6 6/6] ipa: rkisp1: algorithms: data: enable DPF tuning for\n\timx219/ov5640", "Date": "Thu, 18 Dec 2025 18:22:20 -0500", "Message-ID": "<20251218232220.761254-7-rui.wang@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20251218232220.761254-1-rui.wang@ideasonboard.com>", "References": "<20251218232220.761254-1-rui.wang@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Enable the RkISP1 denoise pre-filter (DPF) for the imx219 sensor by\nadding the required DPF tuning block to imx219.yaml.\n\nAdd DPF tuning config for ov5640 to adapt mode selection\n\nSigned-off-by: Rui Wang <rui.wang@ideasonboard.com>\n---\n\nchangelog since v5: No change\n\n Reviewed-by tags from v5 are carried over (no code changes).\n\n src/ipa/rkisp1/data/imx219.yaml | 38 ++++++++++++++++++++++++\n src/ipa/rkisp1/data/ov5640.yaml | 51 +++++++++++++++++++++++++++++++--\n 2 files changed, 86 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/data/imx219.yaml b/src/ipa/rkisp1/data/imx219.yaml\nindex 0d99cb52..d6068ada 100644\n--- a/src/ipa/rkisp1/data/imx219.yaml\n+++ b/src/ipa/rkisp1/data/imx219.yaml\n@@ -111,4 +111,42 @@ algorithms:\n 1438, 1226, 1059, 1024, 1024, 1024, 1024, 1024, 1024, 1024, 1025, 1054, 1185,\n 1326, 1334, 1334,\n ]\n+ - Dpf:\n+ filter:\n+ g: [ 18, 13, 9, 5, 3, 1 ]\n+ rb: [ 18, 15, 12, 8, 5, 2 ]\n+ nll:\n+ coeff: [\n+ 0, 14, 28, 42, 58, 76, 96, 120,\n+ 148, 180, 216, 256, 300, 348, 400, 456,\n+ 520\n+ ]\n+ scale-mode: \"linear\"\n+ strength:\n+ r: 80\n+ g: 80\n+ b: 80\n+ modes:\n+ - type: \"minimal\"\n+ filter:\n+ g: [ 14, 10, 7, 4, 2, 1 ]\n+ rb: [ 14, 11, 8, 4, 2, 1 ]\n+ nll:\n+ coeff: [ 0, 26, 52, 78, 106, 138, 172, 208, 248, 292, 340, 392, 448, 508, 572, 640, 712 ]\n+ scale-mode: \"linear\"\n+ strength:\n+ r: 60\n+ g: 60\n+ b: 60\n+ - type: \"highquality\"\n+ filter:\n+ g: [ 22, 18, 13, 8, 5, 2 ]\n+ rb: [ 20, 18, 16, 11, 7, 3 ]\n+ nll:\n+ coeff: [ 0, 26, 52, 78, 106, 138, 172, 208, 248, 292, 340, 392, 448, 508, 572, 640, 712 ]\n+ scale-mode: \"linear\"\n+ strength:\n+ r: 130\n+ g: 130\n+ b: 130\n ...\ndiff --git a/src/ipa/rkisp1/data/ov5640.yaml b/src/ipa/rkisp1/data/ov5640.yaml\nindex 4b21d412..f36a45b5 100644\n--- a/src/ipa/rkisp1/data/ov5640.yaml\n+++ b/src/ipa/rkisp1/data/ov5640.yaml\n@@ -232,19 +232,64 @@ algorithms:\n green: 2\n red-blue: 2\n - Dpf:\n- DomainFilter:\n+ filter:\n g: [ 16, 16, 16, 16, 16, 16 ]\n rb: [ 16, 16, 16, 16, 16, 16 ]\n- NoiseLevelFunction:\n+ nll:\n coeff: [\n 1023, 1023, 1023, 1023, 1023, 1023, 1023, 1023,\n 1023, 1023, 1023, 1023, 1023, 1023, 1023, 1023,\n 1023\n ]\n scale-mode: \"linear\"\n- FilterStrength:\n+ strength:\n r: 64\n g: 64\n b: 64\n+ modes:\n+ - type: \"minimal\"\n+ filter:\n+ g: [ 14, 10, 7, 4, 2, 1 ]\n+ rb: [ 14, 11, 8, 4, 2, 1 ]\n+ nll:\n+ coeff: [ 0, 26, 52, 78, 106, 138, 172, 208, 248, 292, 340, 392, 448, 508, 572, 640, 712 ]\n+ scale-mode: \"linear\"\n+ strength:\n+ r: 60\n+ g: 60\n+ b: 60\n+ - type: \"highquality\"\n+ filter:\n+ g: [ 22, 18, 13, 8, 5, 2 ]\n+ rb: [ 20, 18, 16, 11, 7, 3 ]\n+ nll:\n+ coeff: [ 0, 26, 52, 78, 106, 138, 172, 208, 248, 292, 340, 392, 448, 508, 572, 640, 712 ]\n+ scale-mode: \"linear\"\n+ strength:\n+ r: 130\n+ g: 130\n+ b: 130\n+ - type: \"fast\"\n+ filter:\n+ g: [ 16, 12, 9, 5, 3, 1 ]\n+ rb: [ 16, 13, 10, 6, 4, 2 ]\n+ nll:\n+ coeff: [ 0, 16, 32, 48, 66, 86, 108, 132, 160, 192, 228, 268, 312, 360, 412, 468, 528 ]\n+ scale-mode: \"linear\"\n+ strength:\n+ r: 90\n+ g: 90\n+ b: 90\n+ - type: \"zsl\"\n+ filter:\n+ g: [ 18, 14, 10, 6, 3, 1 ]\n+ rb: [ 18, 16, 13, 9, 5, 3 ]\n+ nll:\n+ coeff: [ 0, 20, 40, 60, 82, 106, 132, 160, 192, 228, 268, 312, 360, 412, 468, 528, 592 ]\n+ scale-mode: \"linear\"\n+ strength:\n+ r: 110\n+ g: 110\n+ b: 110\n - Filter:\n ...\n", "prefixes": [ "v6", "6/6" ] }